Eric Lee / smarc-fsl-linux-kernel

04 Jan, 2007

1 commit

09 Dec, 2006

1 commit

07 Dec, 2006

2 commits

03 Dec, 2006

6 commits

31 Oct, 2006

1 commit

23 Sep, 2006

7 commits

  • eb328111e   [GENL]: Provide more information to userspace about registered genl families ... Browse Code »

    Additionaly exports the following information when providing
    the list of registered generic netlink families:
    - protocol version
    - header size
    - maximum number of attributes
    - list of available operations including
    - id
    - flags
    - avaiability of policy and doit/dumpit function

    libnl HEAD provides a utility to read this new information:

    0x0010 nlctrl version 1
    hdrsize 0 maxattr 6
    op GETFAMILY (0x03) [POLICY,DOIT,DUMPIT]
    0x0011 NLBL_MGMT version 1
    hdrsize 0 maxattr 0
    op unknown (0x02) [DOIT]
    op unknown (0x03) [DOIT]
    ....

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     
  • 5176f91ea   [NETLINK]: Make use of NLA_STRING/NLA_NUL_STRING attribute validation ... Browse Code »

    Converts existing NLA_STRING attributes to use the new
    validation features, saving a couple of temporary buffers.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     
  • a5531a5d8   [NETLINK]: Improve string attribute validation ... Browse Code »

    Introduces a new attribute type NLA_NUL_STRING to support NUL
    terminated strings. Attributes of this kind require to carry
    a terminating NUL within the maximum specified in the policy.

    The `old' NLA_STRING which is not required to be NUL terminated
    is extended to provide means to specify a maximum length of the
    string.

    Aims at easing the pain with using nla_strlcpy() on temporary
    buffers.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     
  • ef047f5e1   [NET]: Use BUILD_BUG_ON() for checking size of skb->cb. ... Browse Code »

    Signed-off-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    YOSHIFUJI Hideaki
     
  • d387f6ad1   [NETLINK]: Add notification message sending interface ... Browse Code »

    Adds nlmsg_notify() implementing proper notification logic. The
    message is multicasted to all listeners in the group. The
    applications the requests orignates from can request a unicast
    back report in which case said socket will be excluded from the
    multicast to avoid duplicated notifications.

    nlmsg_multicast() is extended to take allocation flags to
    allow notification in atomic contexts.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     
  • bf8b79e44   [NETLINK]: Convert core netlink handling to new netlink api ... Browse Code »

    Fixes a theoretical memory and locking leak when the size of
    the netlink header would exceed the skb tailroom.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     
  • fe4944e59   [NETLINK]: Extend netlink messaging interface ... Browse Code »

    Adds:
    nlmsg_get_pos() return current position in message
    nlmsg_trim() trim part of message
    nla_reserve_nohdr(skb, len) reserve room for an attribute w/o hdr
    nla_put_nohdr(skb, len, data) add attribute w/o hdr
    nla_find_nested() find attribute in nested attributes

    Fixes nlmsg_new() to take allocation flags and consider size.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf
     

30 Aug, 2006

1 commit

22 Jul, 2006

1 commit

04 Jul, 2006

1 commit

  • 6abd219c6   [PATCH] bcm43xx: netlink deadlock fix ... Browse Code »

    reported by Jure Repinc:

    > > http://bugzilla.kernel.org/show_bug.cgi?id=6773

    > > checked out dmesg output and found the message
    > >
    > > ======================================================
    > > [ BUG: hard-safe -> hard-unsafe lock order detected! ]
    > > ------------------------------------------------------
    > >
    > > starting at line 660 of the dmesg.txt that I will attach.

    The patch below should fix the deadlock, albeit I suspect it's not the
    "right" fix; the right fix may well be to move the rx processing in bcm43xx
    to softirq context. [it's debatable, ipw2200 hit this exact same bug; at
    some point it's better to bite the bullet and move this to the common layer
    as my patch below does]

    Make the nl_table_lock irq-safe; it's taken for read in various netlink
    functions, including functions that several wireless drivers (ipw2200,
    bcm43xx) want to call from hardirq context.

    The deadlock was found by the lock validator.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Ingo Molnar
    Signed-off-by: Herbert Xu
    Cc: Michael Buesch
    Cc: "John W. Linville"
    Cc: Jeff Garzik
    Acked-by: "David S. Miller"
    Cc: jamal
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

01 Jul, 2006

1 commit

30 Jun, 2006

1 commit

  • c7bdb545d   [NETLINK]: Encapsulate eff_cap usage within security framework. ... Browse Code »

    This patch encapsulates the usage of eff_cap (in netlink_skb_params) within
    the security framework by extending security_netlink_recv to include a required
    capability parameter and converting all direct usage of eff_caps outside
    of the lsm modules to use the interface. It also updates the SELinux
    implementation of the security_netlink_send and security_netlink_recv
    hooks to take advantage of the sid in the netlink_skb_params struct.
    This also enables SELinux to perform auditing of netlink capability checks.
    Please apply, for 2.6.18 if possible.

    Signed-off-by: Darrel Goeddel
    Signed-off-by: Stephen Smalley
    Acked-by: James Morris
    Signed-off-by: David S. Miller

    Darrel Goeddel
     

02 May, 2006

1 commit

  • 532f57da4   Merge branch 'audit.b10' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current ... Browse Code »

    * 'audit.b10' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current:
    [PATCH] Audit Filter Performance
    [PATCH] Rework of IPC auditing
    [PATCH] More user space subject labels
    [PATCH] Reworked patch for labels on user space messages
    [PATCH] change lspp ipc auditing
    [PATCH] audit inode patch
    [PATCH] support for context based audit filtering, part 2
    [PATCH] support for context based audit filtering
    [PATCH] no need to wank with task_lock() and pinning task down in audit_syscall_exit()
    [PATCH] drop task argument of audit_syscall_{entry,exit}
    [PATCH] drop gfp_mask in audit_log_exit()
    [PATCH] move call of audit_free() into do_exit()
    [PATCH] sockaddr patch
    [PATCH] deal with deadlocks in audit_free()

    Linus Torvalds
     

01 May, 2006

1 commit

  • e7c349701   [PATCH] Reworked patch for labels on user space messages ... Browse Code »

    The below patch should be applied after the inode and ipc sid patches.
    This patch is a reworking of Tim's patch that has been updated to match
    the inode and ipc patches since its similar.

    [updated:
    > Stephen Smalley also wanted to change a variable from isec to tsec in the
    > user sid patch. ]

    Signed-off-by: Steve Grubb
    Signed-off-by: Al Viro

    Steve Grubb
     

30 Apr, 2006

1 commit

28 Mar, 2006

1 commit

  • e041c6834   [PATCH] Notifier chain update: API changes ... Browse Code »

    The kernel's implementation of notifier chains is unsafe. There is no
    protection against entries being added to or removed from a chain while the
    chain is in use. The issues were discussed in this thread:

    http://marc.theaimsgroup.com/?l=linux-kernel&m=113018709002036&w=2

    We noticed that notifier chains in the kernel fall into two basic usage
    classes:

    "Blocking" chains are always called from a process context
    and the callout routines are allowed to sleep;

    "Atomic" chains can be called from an atomic context and
    the callout routines are not allowed to sleep.

    We decided to codify this distinction and make it part of the API. Therefore
    this set of patches introduces three new, parallel APIs: one for blocking
    notifiers, one for atomic notifiers, and one for "raw" notifiers (which is
    really just the old API under a new name). New kinds of data structures are
    used for the heads of the chains, and new routines are defined for
    registration, unregistration, and calling a chain. The three APIs are
    explained in include/linux/notifier.h and their implementation is in
    kernel/sys.c.

    With atomic and blocking chains, the implementation guarantees that the chain
    links will not be corrupted and that chain callers will not get messed up by
    entries being added or removed. For raw chains the implementation provides no
    guarantees at all; users of this API must provide their own protections. (The
    idea was that situations may come up where the assumptions of the atomic and
    blocking APIs are not appropriate, so it should be possible for users to
    handle these things in their own way.)

    There are some limitations, which should not be too hard to live with. For
    atomic/blocking chains, registration and unregistration must always be done in
    a process context since the chain is protected by a mutex/rwsem. Also, a
    callout routine for a non-raw chain must not try to register or unregister
    entries on its own chain. (This did happen in a couple of places and the code
    had to be changed to avoid it.)

    Since atomic chains may be called from within an NMI handler, they cannot use
    spinlocks for synchronization. Instead we use RCU. The overhead falls almost
    entirely in the unregister routine, which is okay since unregistration is much
    less frequent that calling a chain.

    Here is the list of chains that we adjusted and their classifications. None
    of them use the raw API, so for the moment it is only a placeholder.

    ATOMIC CHAINS
    -------------
    arch/i386/kernel/traps.c: i386die_chain
    arch/ia64/kernel/traps.c: ia64die_chain
    arch/powerpc/kernel/traps.c: powerpc_die_chain
    arch/sparc64/kernel/traps.c: sparc64die_chain
    arch/x86_64/kernel/traps.c: die_chain
    drivers/char/ipmi/ipmi_si_intf.c: xaction_notifier_list
    kernel/panic.c: panic_notifier_list
    kernel/profile.c: task_free_notifier
    net/bluetooth/hci_core.c: hci_notifier
    net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_chain
    net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_expect_chain
    net/ipv6/addrconf.c: inet6addr_chain
    net/netfilter/nf_conntrack_core.c: nf_conntrack_chain
    net/netfilter/nf_conntrack_core.c: nf_conntrack_expect_chain
    net/netlink/af_netlink.c: netlink_chain

    BLOCKING CHAINS
    ---------------
    arch/powerpc/platforms/pseries/reconfig.c: pSeries_reconfig_chain
    arch/s390/kernel/process.c: idle_chain
    arch/x86_64/kernel/process.c idle_notifier
    drivers/base/memory.c: memory_chain
    drivers/cpufreq/cpufreq.c cpufreq_policy_notifier_list
    drivers/cpufreq/cpufreq.c cpufreq_transition_notifier_list
    drivers/macintosh/adb.c: adb_client_list
    drivers/macintosh/via-pmu.c sleep_notifier_list
    drivers/macintosh/via-pmu68k.c sleep_notifier_list
    drivers/macintosh/windfarm_core.c wf_client_list
    drivers/usb/core/notify.c usb_notifier_list
    drivers/video/fbmem.c fb_notifier_list
    kernel/cpu.c cpu_chain
    kernel/module.c module_notify_list
    kernel/profile.c munmap_notifier
    kernel/profile.c task_exit_notifier
    kernel/sys.c reboot_notifier_list
    net/core/dev.c netdev_chain
    net/decnet/dn_dev.c: dnaddr_chain
    net/ipv4/devinet.c: inetaddr_chain

    It's possible that some of these classifications are wrong. If they are,
    please let us know or submit a patch to fix them. Note that any chain that
    gets called very frequently should be atomic, because the rwsem read-locking
    used for blocking chains is very likely to incur cache misses on SMP systems.
    (However, if the chain's callout routines may sleep then the chain cannot be
    atomic.)

    The patch set was written by Alan Stern and Chandra Seetharaman, incorporating
    material written by Keith Owens and suggestions from Paul McKenney and Andrew
    Morton.

    [jes@sgi.com: restructure the notifier chain initialization macros]
    Signed-off-by: Alan Stern
    Signed-off-by: Chandra Seetharaman
    Signed-off-by: Jes Sorensen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Stern
     

27 Mar, 2006

1 commit

  • 14cc3e2b6   [PATCH] sem2mutex: misc static one-file mutexes ... Browse Code »

    Semaphore to mutex conversion.

    The conversion was generated via scripts, and the result was validated
    automatically via a script as well.

    Signed-off-by: Ingo Molnar
    Cc: Dave Jones
    Cc: Paul Mackerras
    Cc: Ralf Baechle
    Cc: Jens Axboe
    Cc: Neil Brown
    Acked-by: Alasdair G Kergon
    Cc: Greg KH
    Cc: Dominik Brodowski
    Cc: Adam Belay
    Cc: Martin Schwidefsky
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

21 Mar, 2006

1 commit

13 Mar, 2006

1 commit

14 Feb, 2006

1 commit

  • e200bd806   [NETLINK] genetlink: Fix bugs spotted by Andrew Morton. ... Browse Code »

    - panic() doesn't return.

    - Don't forget to unlock on genl_register_family() error path

    - genl_rcv_msg() is called via pointer so there's no point in declaring it
    `inline'.

    Notes:

    genl_ctrl_event() ignores the genlmsg_multicast() return value.

    lots of things ignore the genl_ctrl_event() return value.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     

10 Feb, 2006

1 commit

  • a70ea994a   [NETLINK]: Fix a severe bug ... Browse Code »

    netlink overrun was broken while improvement of netlink.
    Destination socket is used in the place where it was meant to be source socket,
    so that now overrun is never sent to user netlink sockets, when it should be,
    and it even can be set on kernel socket, which results in complete deadlock
    of rtnetlink.

    Suggested fix is to restore status quo passing source socket as additional
    argument to netlink_attachskb().

    A little explanation: overrun is set on a socket, when it failed
    to receive some message and sender of this messages does not or even
    have no way to handle this error. This happens in two cases:
    1. when kernel sends something. Kernel never retransmits and cannot
    wait for buffer space.
    2. when user sends a broadcast and the message was not delivered
    to some recipients.

    Signed-off-by: Alexey Kuznetsov
    Signed-off-by: David S. Miller

    Alexey Kuznetsov
     

14 Jan, 2006

1 commit

  • 23b0ca5bf   [PATCH] genetlink: don't touch module ref count ... Browse Code »

    Increasing the module ref count at registration will block the module from
    ever being unloaded. In fact, genetlink should not care about the owner at
    all. This patch removes the owner field from the struct registered with
    genetlink.

    Signed-off-by: Per Liden
    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Per Liden
     

12 Jan, 2006

1 commit

11 Jan, 2006

1 commit

10 Jan, 2006

1 commit

04 Jan, 2006

2 commits

  • b461d2f21   [NETLINK] genetlink: fix cmd type in genl_ops to be consistent to u8 ... Browse Code »

    Signed-off-by: Per Liden
    ACKed-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Per Liden
     
  • 90ddc4f04   [NET]: move struct proto_ops to const ... Browse Code »

    I noticed that some of 'struct proto_ops' used in the kernel may share
    a cache line used by locks or other heavily modified data. (default
    linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
    least)

    This patch makes sure a 'struct proto_ops' can be declared as const,
    so that all cpus can share all parts of it without false sharing.

    This is not mandatory : a driver can still use a read/write structure
    if it needs to (and eventually a __read_mostly)

    I made a global stubstitute to change all existing occurences to make
    them const.

    This should reduce the possibility of false sharing on SMP, and
    speedup some socket system calls.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

23 Nov, 2005

1 commit

10 Nov, 2005

1 commit

  • 482a8524f   [NETLINK]: Generic netlink family ... Browse Code »

    The generic netlink family builds on top of netlink and provides
    simplifies access for the less demanding netlink users. It solves
    the problem of protocol numbers running out by introducing a so
    called controller taking care of id management and name resolving.

    Generic netlink modules register themself after filling out their
    id card (struct genl_family), after successful registration the
    modules are able to register callbacks to command numbers by
    filling out a struct genl_ops and calling genl_register_op(). The
    registered callbacks are invoked with attributes parsed making
    life of simple modules a lot easier.

    Although generic netlink modules can request static identifiers,
    it is recommended to use GENL_ID_GENERATE and to let the controller
    assign a unique identifier to the module. Userspace applications
    will then ask the controller and lookup the idenfier by the module
    name.

    Due to the current multicast implementation of netlink, the number
    of generic netlink modules is restricted to 1024 to avoid wasting
    memory for the per socket multiacst subscription bitmask.

    Signed-off-by: Thomas Graf
    Signed-off-by: David S. Miller

    Thomas Graf