Eric Lee / smarc-fsl-linux-kernel

23 Nov, 2011

1 commit

01 Nov, 2011

1 commit

31 Aug, 2011

1 commit

13 Mar, 2011

2 commits

24 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

18 Jan, 2010

1 commit

26 Nov, 2009

1 commit

  • 09ad9bc75   net: use net_eq to compare nets ... Browse Code »

    Generated with the following semantic patch

    @@
    struct net *n1;
    struct net *n2;
    @@
    - n1 == n2
    + net_eq(n1, n2)

    @@
    struct net *n1;
    struct net *n2;
    @@
    - n1 != n2
    + !net_eq(n1, n2)

    applied over {include,net,drivers/net}.

    Signed-off-by: Octavian Purdila
    Signed-off-by: David S. Miller

    Octavian Purdila
     

25 Nov, 2009

1 commit

06 Feb, 2009

1 commit

29 Dec, 2008

1 commit

  • 0191b625c   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6 ... Browse Code »

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1429 commits)
    net: Allow dependancies of FDDI & Tokenring to be modular.
    igb: Fix build warning when DCA is disabled.
    net: Fix warning fallout from recent NAPI interface changes.
    gro: Fix potential use after free
    sfc: If AN is enabled, always read speed/duplex from the AN advertising bits
    sfc: When disabling the NIC, close the device rather than unregistering it
    sfc: SFT9001: Add cable diagnostics
    sfc: Add support for multiple PHY self-tests
    sfc: Merge top-level functions for self-tests
    sfc: Clean up PHY mode management in loopback self-test
    sfc: Fix unreliable link detection in some loopback modes
    sfc: Generate unique names for per-NIC workqueues
    802.3ad: use standard ethhdr instead of ad_header
    802.3ad: generalize out mac address initializer
    802.3ad: initialize ports LACPDU from const initializer
    802.3ad: remove typedef around ad_system
    802.3ad: turn ports is_individual into a bool
    802.3ad: turn ports is_enabled into a bool
    802.3ad: make ntt bool
    ixgbe: Fix set_ringparam in ixgbe to use the same memory pools.
    ...

    Fixed trivial IPv4/6 address printing conflicts in fs/cifs/connect.c due
    to the conversion to %pI (in this networking merge) and the addition of
    doing IPv6 addresses (from the earlier merge of CIFS).

    Linus Torvalds
     

26 Nov, 2008

1 commit

  • 55205d400   ipv6: fix warning in net/ipv6/ip6_flowlabel.c ... Browse Code »

    this warning:

    net/ipv6/ip6_flowlabel.c: In function ‘ipv6_flowlabel_opt’:
    net/ipv6/ip6_flowlabel.c:467: warning: ‘err’ may be used uninitialized in this function

    triggers because GCC does not recognize the (correct) error flow
    between fl_create() and 'err'.

    Annotate it.

    Signed-off-by: Ingo Molnar
    Signed-off-by: David S. Miller

    Ingo Molnar
     

14 Nov, 2008

1 commit

  • f82b35902   CRED: Wrap task credential accesses in the IPv6 protocol ... Browse Code »

    Wrap access to task credentials so that they can be separated more easily from
    the task_struct during the introduction of COW creds.

    Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

    Change some task->e?[ug]id to task_e?[ug]id(). In some places it makes more
    sense to use RCU directly rather than a convenient wrapper; these will be
    addressed by later patches.

    Signed-off-by: David Howells
    Reviewed-by: James Morris
    Acked-by: Serge Hallyn
    Cc: netdev@vger.kernel.org
    Signed-off-by: James Morris

    David Howells
     

30 Oct, 2008

1 commit

29 Oct, 2008

1 commit

05 Jun, 2008

1 commit

27 Mar, 2008

2 commits

29 Jan, 2008

2 commits

  • 9a429c498   [NET]: Add some acquires/releases sparse annotations. ... Browse Code »

    Add __acquires() and __releases() annotations to suppress some sparse
    warnings.

    example of warnings :

    net/ipv4/udp.c:1555:14: warning: context imbalance in 'udp_seq_start' - wrong
    count at exit
    net/ipv4/udp.c:1571:13: warning: context imbalance in 'udp_seq_stop' -
    unexpected unlock

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • 0a3e78ac2   [IPV6]: make flowlabel to return an error ... Browse Code »

    This patch makes the flowlab subsystem to return an error code and makes
    some cleanup with procfs ifdefs.
    The af_inet6 will use the flowlabel init return code to check the initialization
    was correct.

    Signed-off-by: Daniel Lezcano
    Signed-off-by: David S. Miller

    Daniel Lezcano
     

18 Oct, 2007

4 commits

  • 52f095ee8   [IPV6]: Fix again the fl6_sock_lookup() fixed locking ... Browse Code »

    YOSHIFUJI fairly pointed out, that the users increment should
    be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a
    chance to put this count to zero and release the flowlabel.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • 78c2e5025   [IPV6]: Fix race in ipv6_flowlabel_opt() when inserting two labels ... Browse Code »

    In the IPV6_FL_A_GET case the hash is checked for flowlabels
    with the given label. If it is not found, the lock, protecting
    the hash, is dropped to be re-get for writing. After this a
    newly allocated entry is inserted, but no checks are performed
    to catch a classical SMP race, when the conflicting label may
    be inserted on another cpu.

    Use the (currently unused) return value from fl_intern() to
    return the conflicting entry (if found) and re-check, whether
    we can reuse it (IPV6_FL_F_EXCL) or return -EEXISTS.

    Also add the comment, about why not re-lookup the current
    sock for conflicting flowlabel entry.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • bd0bf5770   [IPV6]: Lost locking in fl6_sock_lookup ... Browse Code »

    This routine scans the ipv6_fl_list whose update is
    protected with the socket lock and the ip6_sk_fl_lock.

    Since the socket lock is not taken in the lookup, use
    the other one.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • 04028045a   [IPV6]: Lost locking when inserting a flowlabel in ipv6_fl_list ... Browse Code »

    The new flowlabels should be inserted into the sock list
    under the ip6_sk_fl_lock. This was lost in one place.

    This list is naturally protected with the socket lock, but
    the fl6_sock_lookup() is called without it, so another
    protection is required.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     

11 Oct, 2007

2 commits

  • cf7732e4c   [NET]: Make core networking code use seq_open_private ... Browse Code »

    This concerns the ipv4 and ipv6 code mostly, but also the netlink
    and unix sockets.

    The netlink code is an example of how to use the __seq_open_private()
    call - it saves the net namespace on this private.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • 457c4cbc5   [NET]: Make /proc/net per network namespace ... Browse Code »

    This patch makes /proc/net per network namespace. It modifies the global
    variables proc_net and proc_net_stat to be per network namespace.
    The proc_net file helpers are modified to take a network namespace argument,
    and all of their callers are fixed to pass &init_net for that argument.
    This ensures that all of the /proc/net files are only visible and
    usable in the initial network namespace until the code behind them
    has been updated to be handle multiple network namespaces.

    Making /proc/net per namespace is necessary as at least some files
    in /proc/net depend upon the set of network devices which is per
    network namespace, and even more files in /proc/net have contents
    that are relevant to a single network namespace.

    Signed-off-by: Eric W. Biederman
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

11 Jul, 2007

1 commit

13 Feb, 2007

1 commit

  • 9a32144e9   [PATCH] mark struct file_operations const 7 ... Browse Code »

    Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

11 Feb, 2007

1 commit

03 Dec, 2006

1 commit

31 Oct, 2006

3 commits

  • 1b7c2dbc0   [IPV6]: fix flowlabel seqfile handling ... Browse Code »

    There's a bug in the seqfile show operation for flowlabel objects, where
    each hash chain is traversed cumulatively for each element. The following
    function is called for each element of each chain:

    static void ip6fl_fl_seq_show(struct seq_file *seq, struct ip6_flowlabel *fl)
    {
    while(fl) {
    seq_printf...

    fl = fl->next;
    }
    }

    Thus, objects can appear mutliple times when reading
    /proc/net/ip6_flowlabel, as the above is called for each element in the
    chain.

    The solution is to remove the while() loop from the above, and traverse
    each chain exactly once, per the patch below. This also removes the
    ip6fl_fl_seq_show() function, which does nothing else.

    Signed-off-by: James Morris
    Signed-off-by: David S. Miller

    James Morris
     
  • c6817e4c3   [IPV6]: return EINVAL for invalid address with flowlabel lease request ... Browse Code »

    Currently, when an application requests a lease for a flowlabel via the
    IPV6_FLOWLABEL_MGR socket option, no error is returned if an invalid type
    of destination address is supplied as part of the request, leading to a
    silent failure. This patch ensures that EINVAL is returned to the
    application in this case.

    Signed-off-by: James Morris
    Signed-off-by: David S. Miller

    James Morris
     
  • bcd620757   [IPV6]: fix lockup via /proc/net/ip6_flowlabel ... Browse Code »

    There's a bug in the seqfile handling for /proc/net/ip6_flowlabel, where,
    after finding a flowlabel, the code will loop forever not finding any
    further flowlabels, first traversing the rest of the hash bucket then just
    looping.

    This patch fixes the problem by breaking after the hash bucket has been
    traversed.

    Note that this bug can cause lockups and oopses, and is trivially invoked
    by an unpriveleged user.

    Signed-off-by: James Morris
    Signed-off-by: David S. Miller

    James Morris
     

01 Jul, 2006

1 commit

21 Mar, 2006

1 commit

17 Jan, 2006

1 commit

14 Jan, 2006

1 commit

  • 46b86a2da   [NET]: Use NIP6_FMT in kernel.h ... Browse Code »

    There are errors and inconsistency in the display of NIP6 strings.
    ie: net/ipv6/ip6_flowlabel.c

    There are errors and inconsistency in the display of NIPQUAD strings too.
    ie: net/netfilter/nf_conntrack_ftp.c

    This patch:
    adds NIP6_FMT to kernel.h
    changes all code to use NIP6_FMT
    fixes net/ipv6/ip6_flowlabel.c
    adds NIPQUAD_FMT to kernel.h
    fixes net/netfilter/nf_conntrack_ftp.c
    changes a few uses of "%u.%u.%u.%u" to NIPQUAD_FMT for symmetry to NIP6_FMT

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

12 Jan, 2006

1 commit

04 Jan, 2006

1 commit