15 Jul, 2011
4 commits
-
crypto/ablkcipher.c's setkey() has already checked against the min, max
key sizes before it calls here, and all max_keysize assignments in the
algorithm template array do not exceed TALITOS_MAX_KEY_SIZE.Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu -
Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu -
IRQ done notification is always set. Remove its explicit
assignment from the hot path by including it in the
descriptor header template assignment in talitos_cra_init.Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu -
Assign single target channel per tfm in talitos_cra_init instead of
performing channel scheduling dynamically during the encryption request.
This changes the talitos_submit interface to accept a new channel
number argument. Without this, rapid bursts of misc. sized requests
could make it possible for IPsec packets to be encrypted out-of-order,
which would result in packet drops due to sequence numbers falling
outside the anti-reply window on a peer gateway.Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu
08 Jul, 2011
1 commit
-
In gf128mul_lle() and gf128mul_bbe() r isn't completely initialized with
zero because the size argument passed to memset() is the size of the
pointer, not the structure it points to.Luckily there are no in-kernel users of those functions so the ABI
change implied by this fix should break no existing code.Based on a patch by the PaX Team.
Signed-off-by: Mathias Krause
Cc: PaX Team
Acked-by: David S. Miller
Signed-off-by: Herbert Xu
04 Jul, 2011
1 commit
-
On recent s390 machines hardware acceleration is available for SHA-256.
SHA-224 is based on SHA-256 so it can also be accelerated by hardware.
Do this by adding the proper algorithm description and initialization.Signed-off-by: Jan Glauber
Signed-off-by: Herbert Xu
30 Jun, 2011
25 commits
-
When the first call to af_alg_make_sg fails, we may return garbage
instead of the real error. This patch fixes it by setting the error
if "copied" is zero.Based on a patch by Jesper Juhl.
Reported-by: Jesper Juhl
Signed-off-by: Herbert Xu -
Modify sha1_update to use SHA1_BLOCK_SIZE.
Signed-off-by: Mandeep Singh Baines
Signed-off-by: Herbert Xu -
Various PowerPC 4xx SoCs contain a TRNG embedded in the Security function.
This adds a device driver for that TRNG.Signed-off-by: Josh Boyer
Acked-by: Matt Mackall
Signed-off-by: Herbert Xu -
The Security function on the AMCC SoCs has multiple engines within a
single MMIO range. The crypto driver currently enables the 3DES
functionality by doing a blind write to the device control register.
This can unintentionally disable other functions like the PKA or TRNG
when the driver is loaded.Perform a read/modify/write to enable the 3DES function instead.
Signed-off-by: Josh Boyer
Signed-off-by: Herbert Xu -
drivers/crypto/caam/ctrl.c: In function 'caam_probe':
drivers/crypto/caam/ctrl.c:55:23: warning: unused variable 'perfmon'Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu -
Fixed coding style issues: unnecessary spaces, parentheses on wrong lines.
Signed-off-by: Mati Vait
Signed-off-by: Herbert Xu -
Removed coding style issue: space before tabs.
Signed-off-by: Mati Vait
Signed-off-by: Herbert Xu -
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
It could be a situation, that tasklet is executed twice because of
certain delay between dma callback and irq handler execution.
In that case, second tasklet execution could actually corrupt the data
of the new started dma transactions.This patch improves tasklet logic and prevents above described cases.
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Calling omap_sham_handle_queue from "done" tasklet should be done
after irq scheduled tasklet completes.
Having additional tasklet does not solve that issue because it might
be execute before.
So queue handling tasklet has been removed and functionality integrated
into single tasklet.Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Couple of context flags have been moved to device flags.
IRQ and tasklet handlers does not need to access request
context anymore.Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Some flags are changed in interrupt handlers and verified in the tasklet.
There might be a race condition when tasklet is interrupted or another
cpu/core will run IRQ handler and tasklet in parallel.
Atomic bitops functions are now used instead of bitmask operations.Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Flags mask cannot be used with atomic bit operations.
This patch changes masks to bit numbers.
Atomic bit operations will be used by following patches.Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Request pointer is already available in the function.
Signed-off-by: Dmitry Kasatkin
Signed-off-by: Herbert Xu -
Signed-off-by: H Hartley Sweeten
Acked-by: Matt Mackall
Signed-off-by: Herbert Xu -
Jump to the end of the function for the clk_disable and clk_put rather than
returning directly.A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@r exists@
expression e1,e2;
statement S;
@@e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
//Signed-off-by: Julia Lawall
Signed-off-by: Matt Mackall
Signed-off-by: Herbert Xu -
Convert a return to a jump to an existing label that calls clk_put.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@r exists@
expression e1,e2;
statement S;
@@e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
//Signed-off-by: Julia Lawall
Signed-off-by: Matt Mackall
Signed-off-by: Herbert Xu -
CRYPTO_GHASH_CLMUL_NI_INTEL and CRYPTO_AES_NI_INTEL cannot be used
on UML.
Commit 3e02e5cb and 54b6a1b enabled them by accident.Signed-off-by: Richard Weinberger
Signed-off-by: Herbert Xu -
FIPS compliance requires a known-answer self-test for all approved
cipher and mode combinations, for all valid key sizes. Presently,
there are only self-tests for xts-aes-128. This adds a 256-bit one,
pulled from the same reference document, which should satisfy the
requirement.Signed-off-by: Jarod Wilson
Signed-off-by: Herbert Xu -
Signed-off-by: Gustavo F. Padovan
Signed-off-by: Herbert Xu -
setkey allocates 16 bytes (CAAM_CMD_SZ *
DESC_AEAD_SHARED_TEXT_LEN) shy of what is needed to
store the shared descriptor, resulting in memory
corruption. Fix this.Signed-off-by: Kim Phillips
Signed-off-by: Herbert Xu
27 Jun, 2011
2 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6:
cifs: mark CONFIG_CIFS_NFSD_EXPORT as BROKEN
cifs: free blkcipher in smbhash -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6:
cifs: propagate errors from cifs_get_root() to mount(2)
cifs: tidy cifs_do_mount() up a bit
cifs: more breakage on mount failures
cifs: close sget() races
cifs: pull freeing mountdata/dropping nls/freeing cifs_sb into cifs_umount()
cifs: move cifs_umount() call into ->kill_sb()
cifs: pull cifs_mount() call up
sanitize cifs_umount() prototype
cifs: initialize ->tlink_tree in cifs_setup_cifs_sb()
cifs: allocate mountdata earlier
cifs: leak on mount if we share superblock
cifs: don't pass superblock to cifs_mount()
cifs: don't leak nls on mount failure
cifs: double free on mount failure
take bdi setup/destruction into cifs_mount/cifs_umountAcked-by: Steve French
26 Jun, 2011
1 commit
25 Jun, 2011
6 commits
-
…l/git/tip/linux-2.6-tip
* 'timer-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
rtc: vt8500: Fix build error & cleanup rtc_class_ops->update_irq_enable()
alarmtimers: Return -ENOTSUPP if no RTC device is present
alarmtimers: Handle late rtc module loading -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: Remove unneeded version.h includes from sound/
ASoC: pxa-ssp: Correct check for stream presence
ASoC: imx: add missing module informations
ASoC: imx: Remove unused Kconfig SND_MXC_SOC_SSI entry
ALSA: HDA: Pinfix quirk for HP Z200 Workstation
ALSA: VIA HDA: Create a master amplifier control for VT1718S.
ALSA: VIA HDA: Mute/unmute mixer conncted to Headphone for VT1718S.
ALSA: VIA HDA: Modify initial verbs list for VT1718S.
ALSA: hda - Remove ALC268 model override for CPR2000
ALSA: HDA: Remove quirk for an HP device
ASoC: Remove unused and about to be broken SND_SOC_CUSTOM I/O bus -
…/linux into timers/urgent
* rtc: vt8500: Fix build error & cleanup rtc_class_ops->update_irq_enable()
-
* 'drm-intel-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/keithp/linux-2.6:
drm/i915: save/resume forcewake lock fixes
Revert "drm/i915: Kill GTT mappings when moving from GTT domain"
drm/i915: Apply HWSTAM workaround for BSD ring on SandyBridge
drm/i915: Call intel_enable_plane from i9xx_crtc_mode_set (again) -
... instead of just failing with -EINVAL
Acked-by: Pavel Shilovsky
Reviewed-by: Jeff Layton
Signed-off-by: Al Viro -
Acked-by: Pavel Shilovsky
Reviewed-by: Jeff Layton
Signed-off-by: Al Viro
