12 Jul, 2005

14 commits

  • Upon suggestion by Nils Roeder, here is an update to the i2c
    documentation to clarify which header files user-space applications
    relying on the i2c-dev interface should include.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • Fix documentation to match code in include/linux/i2c-dev.h

    Signed-off-by: Jan Veldeman
    Signed-off-by: Greg Kroah-Hartman

    Jan Veldeman
     
  • The I2C stack has long had "id" fields, of rather dubious utility, in
    many data structures. This removes mention of one of them from the
    documentation about how to write an I2C driver, so that only drivers
    that really need to use them (probably old/legacy code) will have any
    reason to use this field.

    Signed-off-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    david-b@pacbell.net
     
  • This simple patch drops an out-of-date comment in the eeprom i2c chip
    driver.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • This patch uses the already existing IDR mechanism to simplify and
    improve the i2c_get_adapter function in i2c-core.

    Signed-off-by: Mark M. Hoffman
    Signed-off-by: Greg Kroah-Hartman

    Mark M. Hoffman
     
  • Here is a simple path fixing an incorrect kfree in the m41t00 i2c chip
    driver. The current code happens to work by accident, but the freed
    pointer isn't the one which was allocated in the first place, which
    could cause problems later.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • Here is a proposed Kconfig update for the new max6875 i2c chip driver.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • Here is a proposed documentation update for the new max6875 i2c chip
    driver.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • After a careful code analysis on the new max6875 driver
    (drivers/i2c/chips/max6875.c), I have come to the conclusion that this
    driver may cause EEPROM corruptions if used on random systems.

    The EEPROM part of the MAX6875 chip is accessed using rather uncommon
    I2C sequences. What is seen by the MAX6875 as reads can be seen by a
    standard EEPROM (24C02) as writes. If you check the detection method
    used by the driver, you'll find that the first SMBus command it will
    send on the bus is i2c_smbus_write_byte_data(client, 0x80, 0x40). For
    the MAX6875 it makes an internal pointer point to a specific offset of
    the EEPROM waiting for a subsequent read command, so it's not an actual
    data write operation, but for a standard EEPROM, this instead means
    writing value 0x40 to offset 0x80. Blame Philips and Intel for the
    obscure protocol.

    Since the MAX6875 and the standard, common 24C02 EEPROMs share two I2C
    addresses (0x50 and 0x52), loading the max6875 driver on a system with
    standard EEPROMs at either address will trigger a write on these
    EEPROMs, which will lead to their corruption if they happen not to be
    write protected. This kind of EEPROMs can be found on memory modules
    (SPD), ethernet adapters (MAC address), laptops (proprietary data) and
    displays (EDID/DDC). Most of these are hopefully write-protected, but
    not all of them.

    For this reason, I would recommend that the max6875 driver be
    neutralized, in a way that nobody can corrupt his/her EEPROMs by just
    loading the driver. This means either deleting the driver completely, or
    not listing any default address for it. I'd like this to be done before
    2.6.13-rc1 is released.

    Additionally, the max6875 driver lacks the 24RF08 corruption preventer
    present in the eeprom driver, which means that loading this driver in a
    system with such a chip would corrupt it as well.

    Here is a proposed quick patch addressing the issue, although I wouldn't
    mind a complete removal if it makes everyone feel safer. I think Ben
    has plans to replace this driver by a much simplified one anyway.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • Here is a simple patch originally from Denis Vlasenko, which strips a
    useless trailing whitespace from 8 strings in 4 i2c drivers. Please
    apply, thanks.

    From: Denis Vlasenko
    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     
  • This includes various small cleanups and fixes to the TPS 6501x driver that
    came mostly from review feedback by Jean Delvare; thanks Jean! Also some
    goofy whitespace gets fixed.

    Signed-off-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    david-b@pacbell.net
     
  • On Wednesday 22 June 2005 08:17, Greg KH wrote:
    > [PATCH] I2C: Coding style cleanups to via686a
    >
    > The via686a hardware monitoring driver has infamous coding style at the
    > moment. I'd like to clean up the mess before I start working on other
    > changes to this driver. Is the following patch acceptable? No code
    > change, only coding style (indentation, alignments, trailing white
    > space, a few parentheses and a typo).
    >
    > Signed-off-by: Jean Delvare
    > Signed-off-by: Greg Kroah-Hartman

    Nice.

    You missed some. This one is on top of your patch:

    Signed-off-by: Greg Kroah-Hartman

    Denis Vlasenko
     
  • Linus Torvalds
     
  • Linus Torvalds
     

11 Jul, 2005

25 commits


10 Jul, 2005

1 commit