27 Apr, 2008

2 commits


18 Apr, 2008

1 commit


06 Feb, 2008

1 commit


03 Feb, 2008

3 commits


02 Feb, 2008

1 commit

  • Delete filenames/versions from comments.

    I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s
    to maintainers of the respective drivers.

    While at it:

    * Remove unused VERSION define from ide.c.

    * Remove unused/stale DRV_VERSION define from au1xxx-ide.c.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

27 Jan, 2008

1 commit


26 Jan, 2008

3 commits

  • * Set taskfile flags for REQ_TYPE_ATA_TASKFILE requests before
    adding the request to the queue.

    * Cleanup execute_drive_cmd().

    * Remove unnecessary writes to HOB taskfile registers when using
    LBA48 disk for the following cases:

    - Power Management requests
    (WIN_FLUSH_CACHE[_EXT], WIN_STANDBYNOW1, WIN_IDLEIMMEDIATE commands)

    - special commands (WIN_SPECIFY, WIN_RESTORE, WIN_SETMULT)

    - Host Protected Area support (WIN_READ_NATIVE_MAX, WIN_SET_MAX)

    - /proc/ide/ SMART support (WIN_SMART with SMART_ENABLE,
    SMART_READ_VALUES and SMART_READ_THRESHOLDS subcommands)

    - write cache enabling/disabling in ide-disk
    (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_WCACHE)

    - write cache flushing in ide-disk (WIN_FLUSH_CACHE[_EXT])

    - acoustic management in ide-disk
    (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_AAM)

    - door (un)locking in ide-disk (WIN_DOORLOCK, WIN_DOORUNLOCK)

    - /proc/ide/hd?/identify support (WIN_IDENTIFY)

    - ACPI _GTF taskfiles

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • * Add ide_no_data_taskfile() helper and convert ide_raw_taskfile() w/ NO DATA
    protocol users to use it instead.

    * Set ->data_phase explicitly in ide_no_data_taskfile()
    (TASKFILE_NO_DATA is defined as 0x0000).

    * Unexport task_no_data_intr().

    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7]
    in idedisk_set_max_address_ext().

    * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[]
    and hobRegister[].

    * Remove no longer needed IDE_CONTROL_OFFSET_HOB define.

    * Add #ifndef/#endif __KERNEL__ around definitions of {task,hob}_struct_t.

    While at it:

    * Use ATA_LBA define for LBA bit (0x40) as suggested by Tejun Heo.

    v2:
    * Add missing newlines. (Noticed by Sergei)

    * Use ~ATA_LBA instead of 0xBF. (Noticed by Sergei)

    * Use unnamed unions for error/feature and status/command.
    (Suggested by Sergei).

    There should be no functionality changes caused by this patch.

    Acked-by: Sergei Shtylyov
    Cc: Tejun Heo
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

12 Jan, 2008

1 commit


11 Jan, 2008

1 commit

  • http://bugzilla.kernel.org/show_bug.cgi?id=9673

    ACPI _PS3 cause S4 breaks in the second attempt. The system has a _PS3
    method for IDE, which will call into SMM mode. Currently we haven't clue
    why just the second attempt fails, as it's totally in BIOS code, so
    blacklist the system so far for 2.6.24.

    A possible suspect is ACPI NVS isn't save/restore, we will revisit the
    bug after linux does ACPI NVS save/restore.

    Bart:
    - fix scripts/checkpatch.pl complaints
    - const-ify ide_acpi_dmi_table[]

    Signed-off-by: Shaohua Li
    Cc: "Rafael J. Wysocki"
    Reported-by: Mikko Vinni
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Shaohua Li
     

20 Oct, 2007

1 commit


13 Oct, 2007

1 commit


12 Oct, 2007

1 commit

  • ACPI spec defines the sequence of IDE power on/off:
    Powering down:
    Call _GTM.
    Power down drive (calls _PS3 method and turns off power planes).
    Powering up:
    Power up drive (calls _PS0 method if present and turns on power planes).
    Call _STM passing info from _GTM (possibly modified), with ID data from
    each drive.
    Initialize the channel.
    May modify the results of _GTF.
    For each drive:
    Call _GTF.
    Execute task file (possibly modified).
    This patch adds the missed _PS0/_PS3 methods call.

    Signed-off-by: Shaohua Li
    Acked-by: Len Brown
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Shaohua Li
     

08 Feb, 2007

2 commits

  • drivers/ide/ide-acpi.c: In function 'ide_acpi_get_timing':
    drivers/ide/ide-acpi.c:537: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'

    Signed-off-by: Andrew Morton
    Signed-off-by: Hannes Reinecke
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Andrew Morton
     
  • This patch implements ACPI integration for generic IDE devices.
    The ACPI spec mandates that some methods are called during suspend and
    resume. And consequently there most modern Laptops cannot resume
    properly without it.

    According to the spec, we should call '_GTM' (Get Timing) upon suspend
    to store the current IDE adapter settings.
    Upon resume we should call '_STM' (Set Timing) to initialize the
    adapter with the stored settings; afterwards '_GTF' (Get Taskfile)
    should be called which returns a buffer with some IDE initialisation
    commands. Those commands should be passed to the drive.

    There are two module params which control the behaviour of this patch:

    'ide=noacpi'
    Do not call any ACPI methods (Disables any ACPI method calls)
    'ide=acpigtf'
    Enable execution of _GTF methods upon resume.
    Has no effect if 'ide=noacpi' is set.
    'ide=acpionboot'
    Enable execution of ACPI methods during boot.
    This might be required on some machines if 'ide=acpigtf' is
    selected as some machines modify the _GTF information
    depending on the drive identification passed down with _STM.

    Signed-off-by: Hannes Reinecke
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Hannes Reinecke