Eric Lee / smarc-fsl-linux-kernel

09 May, 2007

2 commits

  • e63340ae6   header cleaning: don't include smp_lock.h when not used ... Browse Code »

    Remove includes of where it is not used/needed.
    Suggested by Al Viro.

    Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
    sparc64, and arm (all 59 defconfigs).

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • fedee54d8   ext3: dirindex error pointer issues ... Browse Code »

    - ext3_dx_find_entry() exit with out setting proper error pointer

    - do_split() exit with out setting proper error pointer
    it is realy painful because many callers contain folowing code:

    de = do_split(handle,dir, &bh, frame, &hinfo, &retval);
    if (!(de))
    return retval;
    <<< WOW retval wasn't changed by do_split(), so caller failed
    <<< but return SUCCESS :)

    - Rearrange do_split() error path. Current error path is realy ugly, all
    this up and down jump stuff doesn't make code easy to understand.

    [dmonakhov@sw.ru: fix annoying fake error messages]
    Signed-off-by: Monakhov Dmitriy
    Cc: Andreas Dilger
    Cc: Theodore Ts'o
    Signed-off-by: Monakhov Dmitriy
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dmitriy Monakhov
     

13 Feb, 2007

1 commit

  • 754661f14   [PATCH] mark struct inode_operations const 1 ... Browse Code »

    Many struct inode_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

12 Feb, 2007

2 commits

  • 731b9a549   [PATCH] remove ext[34]_inc_count and _dec_count ... Browse Code »

    - Naming is confusing, ext3_inc_count manipulates i_nlink not i_count
    - handle argument passed in is not used
    - ext3 and ext4 already call inc_nlink and dec_nlink directly in other places

    Signed-off-by: Eric Sandeen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric Sandeen
     
  • 2988a7740   [PATCH] return ENOENT from ext3_link when racing with unlink ... Browse Code »

    Return -ENOENT from ext[34]_link if we've raced with unlink and i_nlink is
    0. Doing otherwise has the potential to corrupt the orphan inode list,
    because we'd wind up with an inode with a non-zero link count on the list,
    and it will never get properly cleaned up & removed from the orphan list
    before it is freed.

    [akpm@osdl.org: build fix]
    Signed-off-by: Eric Sandeen
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric Sandeen
     

09 Dec, 2006

1 commit

08 Dec, 2006

1 commit

  • 40b851348   [PATCH] handle ext3 directory corruption better ... Browse Code »

    I've been using Steve Grubb's purely evil "fsfuzzer" tool, at
    http://people.redhat.com/sgrubb/files/fsfuzzer-0.4.tar.gz

    Basically it makes a filesystem, splats some random bits over it, then
    tries to mount it and do some simple filesystem actions.

    At best, the filesystem catches the corruption gracefully. At worst,
    things spin out of control.

    As you might guess, we found a couple places in ext3 where things spin out
    of control :)

    First, we had a corrupted directory that was never checked for
    consistency... it was corrupt, and pointed to another bad "entry" of
    length 0. The for() loop looped forever, since the length of
    ext3_next_entry(de) was 0, and we kept looking at the same pointer over and
    over and over and over... I modeled this check and subsequent action on
    what is done for other directory types in ext3_readdir...

    (adding this check adds some computational expense; I am testing a followup
    patch to reduce the number of times we check and re-check these directory
    entries, in all cases. Thanks for the idea, Andreas).

    Next we had a root directory inode which had a corrupted size, claimed to
    be > 200M on a 4M filesystem. There was only really 1 block in the
    directory, but because the size was so large, readdir kept coming back for
    more, spewing thousands of printk's along the way.

    Per Andreas' suggestion, if we're in this read error condition and we're
    trying to read an offset which is greater than i_blocks worth of bytes,
    stop trying, and break out of the loop.

    With these two changes fsfuzz test survives quite well on ext3.

    Signed-off-by: Eric Sandeen
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric Sandeen
     

01 Oct, 2006

4 commits

27 Sep, 2006

3 commits

01 Aug, 2006

1 commit

  • 2ccb48ebb   [PATCH] ext3: avoid triggering ext3_error on bad NFS file handle ... Browse Code »

    The inode number out of an NFS file handle gets passed eventually to
    ext3_get_inode_block() without any checking. If ext3_get_inode_block()
    allows it to trigger an error, then bad filehandles can have unpleasant
    effect - ext3_error() will usually cause a forced read-only remount, or a
    panic if `errors=panic' was used.

    So remove the call to ext3_error there and put a matching check in
    ext3/namei.c where inode numbers are read off storage.

    [akpm@osdl.org: fix off-by-one error]
    Signed-off-by: Neil Brown
    Signed-off-by: Jan Kara
    Cc: Marcel Holtmann
    Cc:
    Cc: "Stephen C. Tweedie"
    Cc: Eric Sandeen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Neil Brown
     

26 Jun, 2006

1 commit

12 Mar, 2006

1 commit

  • 0adb25d2e   [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside ... Browse Code »

    This patch fixes illegal __GFP_FS allocation inside ext3 transaction in
    ext3_symlink(). Such allocation may re-enter ext3 code from
    try_to_free_pages. But JBD/ext3 code keeps a pointer to current journal
    handle in task_struct and, hence, is not reentrable.

    This bug led to "Assertion failure in journal_dirty_metadata()" messages.

    http://bugzilla.openvz.org/show_bug.cgi?id=115

    Signed-off-by: Andrey Savochkin
    Signed-off-by: Kirill Korotaev
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kirill Korotaev
     

15 Jan, 2006

1 commit

09 Jan, 2006

1 commit

31 Oct, 2005

1 commit

  • 381be2545   [PATCH] ext3: sparse fixes ... Browse Code »

    Fix warnings from sparse due to un-declared functions that should either
    have a header file or have been declared static

    fs/ext2/bitmap.c:14:15: warning: symbol 'ext2_count_free' was not declared. Should it be static?
    fs/ext2/namei.c:92:15: warning: symbol 'ext2_get_parent' was not declared. Should it be static?
    fs/ext3/bitmap.c:15:15: warning: symbol 'ext3_count_free' was not declared. Should it be static?
    fs/ext3/namei.c:1013:15: warning: symbol 'ext3_get_parent' was not declared. Should it be static?
    fs/ext3/xattr.c:214:1: warning: symbol 'ext3_xattr_block_get' was not declared. Should it be static?
    fs/ext3/xattr.c:358:1: warning: symbol 'ext3_xattr_block_list' was not declared. Should it be static?
    fs/ext3/xattr.c:630:1: warning: symbol 'ext3_xattr_block_find' was not declared. Should it be static?
    fs/ext3/xattr.c:863:1: warning: symbol 'ext3_xattr_ibody_find' was not declared. Should it be static?

    Signed-off-by: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     

24 Jun, 2005

2 commits

  • 1f54587be   [PATCH] quota: ext3: Improve quota credit estimates ... Browse Code »

    Use improved credits estimates for quota operations. Also reserve a space
    for a quota operation in a transaction only if filesystem was mounted with
    some quota options.

    Signed-off-by: Jan Kara
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Kara
     
  • acfa1823d   [PATCH] Support for dx directories in ext3_get_parent (NFSD) ... Browse Code »

    Henrik Grubbstrom noted:

    The 2.6.10 ext3_get_parent attempts to use ext3_find_entry to look up the
    entry "..", which fails for dx directories since ".." is not present in the
    directory hash table. The patch below solves this by looking up the dotdot
    entry in the dx_root block.

    Typical symptoms of the above bug are intermittent claims by nfsd that
    files or directories are missing on exported ext3 filesystems.

    cf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=3D150759 and
    https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=3D144556

    ext3_get_parent() is IMHO the wrong place to fix this bug as it introduces
    a lot of internals from htree into that function. Instead, I think this
    should be fixed in ext3_find_entry() as in the below patch. This has the
    added advantage that it works for any callers of ext3_find_entry() and not
    just ext3_lookup_parent().

    Signed-off-by: Andreas Dilger
    Signed-off-by: Henrik Grubbstrom
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andreas Dilger
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds