Eric Lee / smarc-fsl-linux-kernel

12 Dec, 2011

1 commit

07 Aug, 2009

1 commit

27 Apr, 2009

1 commit

  • 992d7ced7   locking: Documentation: lockdep-design.txt, fix note of state bits ... Browse Code »

    From source code of get_usage_char(), the previous note is not correct,
    so fix it.

    static char get_usage_char(struct lock_class *class, enum lock_usage_bit bit)
    {
    char c = '.';

    if (class->usage_mask & lock_flag(bit + 2))/*LOCK_ENABLED_##STATE*/
    c = '+';
    if (class->usage_mask & lock_flag(bit)) {/*LOCK_USED_IN_##STATE*/
    c = '-';
    if (class->usage_mask & lock_flag(bit + 2))
    c = '?';
    }

    return c;
    }

    note:

    1) The 'bit' parameter always is passed as LOCK_USED_IN_##STATE
    or LOCK_USED_IN_##STATE_READ , from get_usage_chars().

    Signed-off-by: Ming Lei
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     

15 Feb, 2009

1 commit

12 Oct, 2006

1 commit

  • 5fcce7432   [PATCH] fix lockdep-design.txt ... Browse Code »

    I was looking at lockdep-desing.txt and i guess i am confused with the
    changes with respect to fd7bcea35e7efb108c34ee2b3840942a3749cadb. It
    says

    + '.' acquired while irqs enabled
    + '+' acquired in irq context
    + '-' acquired in process context with irqs disabled
    + '?' read-acquired both with irqs enabled and in irq context
    +

    But the get_usage_chars() function does this for '-'
    if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
    *c1 = '-';

    So i guess what would be correct would be
    '.' acquired while irqs disabled
    '+' acquired in irq context
    '-' acquired with irqs enabled
    '?' read acquired in irq context with irqs enabled.

    Acked-by: Ingo Molnar
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Aneesh Kumar
     

04 Oct, 2006

3 commits

01 Oct, 2006

1 commit

04 Jul, 2006

1 commit