25 Jun, 2010

2 commits


18 Feb, 2010

1 commit


03 Nov, 2009

4 commits

  • This patch adds code to disable the TXC and RXC reference clocks if link
    is not available.

    Signed-off-by: Matt Carlson
    Reviewed-by: Michael Chan
    Signed-off-by: David S. Miller

    Matt Carlson
     
  • The 5785 does not use the RXC reference clock. Turning it off is
    desirable as it saves power.

    By default, the 50610 enables the RXC reference clock and the 50610M
    disables it. Presumably this is one of the reasons why the hardware
    architect chose one over the other.

    Adding a "rx reference clock disable" flag is not the ideal way to
    describe the option, as it would force the MAC using a 50610M to set
    the flag. Ideally we want the flags to represent opt-in behavior that
    deviates from hardware defaults. Furthermore, the lack of a
    "disable" flag implies that the requester wants the rx reference clock
    enabled, which doesn't necessarily follow.

    By presenting the option as a passive statement (rx reference clock
    unused) rather than a command, I hope to convey an opt-in option to
    disable the rx reference clock that falls back to hardware defaults if
    not set. A secondary benefit of this is that it keeps the
    intelligence about phy defaults in the broadcom module where it belongs
    and allows the broadcom module more latitude should a bug arise.

    Signed-off-by: Matt Carlson
    Reviewed-by: Michael Chan
    Signed-off-by: David S. Miller

    Matt Carlson
     
  • Broadcom 50610M parts changed the default definitions of the RGMII mode
    shadow register. The 5785 needs the RGMII mode selection bits [4:3]
    cleared.

    The default value of the remaining bits in this register are zero.
    Rather than unnecessarily burn an extra bit in the dev_flags member in
    an attempt to enumerate all possible combinations, this patch take a
    more course grained approach and labels the option as "clear all bits".

    Signed-off-by: Matt Carlson
    Reviewed-by: Michael Chan
    Signed-off-by: David S. Miller

    Matt Carlson
     
  • This patch moves all the dev_flags enumerations outside the broadcom.c
    file to include/linux/brcmphy.h. The existing flags were not used yet
    and have been re-enumerated to avoid conflicts.

    Signed-off-by: Matt Carlson
    Reviewed-by: Michael Chan
    Signed-off-by: David S. Miller

    Matt Carlson
     

29 May, 2008

1 commit