29 Nov, 2010

1 commit

• fa9f90be7   Kill off a bunch of warning: ‘inline’ is not at beginning of declaration ... Browse Code »

  These warnings are spewed during a build of a 'allnoconfig' kernel
  (especially the ones from u64_stats_sync.h show up a lot) when building
  with -Wextra (which I often do)..
  They are
  a) annoying
  b) easy to get rid of.
  This patch kills them off.

  include/linux/u64_stats_sync.h:70:1: warning: ‘inline’ is not at beginning of declaration
  include/linux/u64_stats_sync.h:77:1: warning: ‘inline’ is not at beginning of declaration
  include/linux/u64_stats_sync.h:84:1: warning: ‘inline’ is not at beginning of declaration
  include/linux/u64_stats_sync.h:96:1: warning: ‘inline’ is not at beginning of declaration
  include/linux/u64_stats_sync.h:115:1: warning: ‘inline’ is not at beginning of declaration
  include/linux/u64_stats_sync.h:127:1: warning: ‘inline’ is not at beginning of declaration
  kernel/time.c:241:1: warning: ‘inline’ is not at beginning of declaration
  kernel/time.c:257:1: warning: ‘inline’ is not at beginning of declaration
  kernel/perf_event.c:4513:1: warning: ‘inline’ is not at beginning of declaration
  mm/page_alloc.c:4012:1: warning: ‘inline’ is not at beginning of declaration

  Signed-off-by: Jesper Juhl
  Signed-off-by: Jiri Kosina

  Jesper Juhl

  2010-11-29 06:08:04 +0800  

29 Jun, 2010

2 commits

• 33d91f00c   net: u64_stats_fetch_begin_bh() and u64_stats_fetch_retry_bh() ... Browse Code »

  - Must disable preemption in case of 32bit UP in u64_stats_fetch_begin()
  and u64_stats_fetch_retry()

  - Add new u64_stats_fetch_begin_bh() and u64_stats_fetch_retry_bh() for
  network usage, disabling BH on 32bit UP only.

  Signed-off-by: Eric Dumazet
  Signed-off-by: David S. Miller

  Eric Dumazet

  2010-06-29 14:24:30 +0800  
• b6b3ecc71   net: u64_stats_sync improvements ... Browse Code »

  - Add a comment about interrupts:

  6) If counter might be written by an interrupt, readers should block
  interrupts.

  - Fix a typo in sample of use.

  Signed-off-by: Eric Dumazet
  Signed-off-by: David S. Miller

  Eric Dumazet

  2010-06-29 14:24:29 +0800  

24 Jun, 2010

1 commit

• 16b8a4761   net: Introduce u64_stats_sync infrastructure ... Browse Code »

  To properly implement 64bits network statistics on 32bit or 64bit hosts,
  we provide one new type and four methods, to ease conversions.

  Stats producer should use following template granted it already got an
  exclusive access to counters (include/linux/u64_stats_sync.h contains
  some documentation about details)

  u64_stats_update_begin(&stats->syncp);
  stats->bytes64 += len;
  stats->packets64++;
  u64_stats_update_end(&stats->syncp);

  While a consumer should use following template to get consistent
  snapshot :

  u64 tbytes, tpackets;
  unsigned int start;

  do {
  start = u64_stats_fetch_begin(&stats->syncp);
  tbytes = stats->bytes64;
  tpackets = stats->packets64;
  } while (u64_stats_fetch_retry(&stats->lock, syncp));

  Suggested by David Miller, and comments courtesy of Nick Piggin.

  Signed-off-by: Eric Dumazet
  Signed-off-by: David S. Miller

  Eric Dumazet

  2010-06-24 03:59:47 +0800