07 Feb, 2006

2 commits


06 Feb, 2006

8 commits

  • When we pull the PPP protocol off the skb, we forgot to update the
    hardware RX checksum. This may lead to messages such as

    dsl0: hw csum failure.

    Similarly, we need to clear the hardware checksum flag when we use
    the existing packet to store the decompressed result.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     
  • I thought we had fixed up all non-gpl USB drivers, and was wrong to do
    this.

    Signed-off-by: Greg Kroah-Hartman
    Signed-off-by: Linus Torvalds

    Greg KH
     
  • Allocate memory for read-gathering at open time, when it is known just how
    much memory is needed. This avoids wasting kernel memory when the real packet
    size is smaller than the maximum packet size supported by the driver. This is
    always the case when using DVD discs.

    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Osterlund
     
  • Unless the help text is outdated, this seems to be logical.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • The version information is not useful for a driver that is maintained in
    Linus' kernel tree.

    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Osterlund
     
  • The pktcdvd driver was using an 8 bit field to store the packet length
    obtained from the disc track info. This causes it to overflow packet length
    values of 128KB or more. I changed the field to 32 bits to fix this.

    The pktcdvd driver defaulted to its maximum allowed packet length when it
    detected a 0 in the track info field. I changed this to fail the operation
    and refuse to access the media. This seems more sane than attempting to
    access it with a value that almost certainly will not work.

    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Phillip Susi
     
  • Fix http://bugzilla.kernel.org/show_bug.cgi?id=5923

    When a scsi command failed, an oops would result.

    Back-to-back SMART queries would make the Seagate drives unhappy. The
    second SMART query would timeout, and the command would be aborted.

    Acked-by: Markus Lidel
    Cc: Kenny Simpson
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Markus Lidel
     
  • percpu_data blindly allocates bootmem memory to store NR_CPUS instances of
    cpudata, instead of allocating memory only for possible cpus.

    As a preparation for changing that, we need to convert various 0 -> NR_CPUS
    loops to use for_each_cpu().

    (The above only applies to users of asm-generic/percpu.h. powerpc has gone it
    alone and is presently only allocating memory for present CPUs, so it's
    currently corrupting memory).

    Signed-off-by: Eric Dumazet
    Cc: "David S. Miller"
    Cc: James Bottomley
    Acked-by: Ingo Molnar
    Cc: Jens Axboe
    Cc: Anton Blanchard
    Acked-by: William Irwin
    Cc: Andi Kleen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric Dumazet
     

05 Feb, 2006

3 commits


04 Feb, 2006

27 commits

  • Linus Torvalds
     
  • Linus Torvalds
     
  • Linus Torvalds
     
  • Prevent SERIAL_8250_RUNTIME_UARTS being larger than SERIAL_8250_NR_UARTS.

    Signed-off-by: Russell King

    Russell King
     
  • Linus Torvalds
     
  • Remove the CONFIG_PDC202XX_FORCE=n case.

    Signed-off-by: Adrian Bunk
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • I just purchased a HighPoint Rocket 1520 SATA controller. There seems to
    be no libata driver (yet), but there is an ide driver, hpt366. When the
    driver gets loaded, it causes a kernel NULL pointer dereference in
    pci_bus_clock_list. It seems to be because the driver is waiting for clock
    stabilization in init_hpt37x() which never comes. The driver just
    continues on with the pci drvdata set to NULL, instead of a valid clock
    entry. The following patch prevents the NULL dereference from happening,
    but instead exit with an error.

    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Loren M. Lang
     
  • Signed-off-by: Alan Cox
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • Restore a missing space in a log message, which was accidentally
    removed by a previous change: 3e087b575496b8aa445192f58e7d996b1cdfa121

    Signed-off-by: Jean Delvare
    Cc: Tejun Heo
    Cc: Jens Axboe
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     
  • Since there's no longer any external user, we can make __ide_end_request()
    static.

    Signed-off-by: Adrian Bunk
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Signed-off-by: Ingo Molnar
    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Cc: Rogio Brito
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     
  • This patch stops CompactFlash devices being marked as removable. They are
    not removable (as defined by Linux) as the media and device are
    inseparable. When a card is removed, the whole device is removed from the
    system and never sits in a media-less state.

    This stops some nasty udev device creation/destruction loops.

    Further, once this change is made, there is no need for ide to can be
    removed from ide_drive_t.

    Signed-off-by: Richard Purdie
    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Richard Purdie
     
  • CONFIG_BLK_DEV_IDECS docu mentions everything and the kitchen sink, yet
    fails to list the most important/widespread (IMHO) device: Compact Flash
    PCMCIA adapters.

    This incomplete description recently caused me to deselect the ide_cs
    module, causing great pain soon thereafter when I realized why I had
    actually enabled it some years ago.

    Updates:
    - make sure to mention Compact Flash adapters
    - fix some random typos in ide Kconfig

    Signed-off-by: Andreas Mohr
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andreas Mohr
     
  • There's no reason MAX_HWIFS needs to be ia64-specific, so set MAX_HWIFS
    from CONFIG_IDE_MAX_HWIFS.

    This reduces the default from 10 to 4, but I don't think that's a problem.

    Signed-off-by: Bjorn Helgaas
    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Cc: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bjorn Helgaas
     
  • Signed-off-by: Jason Gaston
    Acked-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jason Gaston
     
  • While looking to the report by Coverity in ipmi, I came across the
    following issue:

    The IPMI message handler relies on two defines which are the same -one in
    include/linux/ipmi.h
    #define IPMI_NUM_CHANNELS 0x10
    and one in drivers/char/ipmi/ipmi_msghandler.
    #define IPMI_MAX_CHANNELS 16
    These are used interchangeably in ipmi_msghandler.c, but since the array
    addr->channels[] is of size IPMI_MAX_CHANNELS, I have made a patch that
    uses IPMI_MAX_CHANNELS for all the checks for the array index.

    NOTE: You could probably remove the line that defines IPMI_NUM_CHANNELS
    from ipmi.h, or move IPMI_MAX_CHANNELS to ipmi.h

    Signed-off-by: Jayachandran C.
    Cc: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jayachandran C
     
  • drivers/isdn/hisax/hscx_irq.c: In function `hscx_interrupt':
    drivers/isdn/hisax/hscx_irq.c:201: warning: comparison is always 1 due to width of bit-field

    It's due to

    (PACKET_NOACK != bcs->tx_skb->pkt_type)

    pkt_type is only three bit wide.

    I think this should fix it for the moment, pkt_type 7 is not used yet and
    this is only used internal in hisax.

    Signed-off-by: Karsten keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Keil
     
  • With Eric's "i386: Add a temporary to make put_user more type safe" patch we
    get a pile of warnings out of ip2m1in.c:

    drivers/char/ip2main.c: In function `ip2_ipl_ioctl':
    drivers/char/ip2main.c:2910: warning: assignment makes integer from pointer without a cast
    drivers/char/ip2main.c:2911: warning: assignment makes integer from pointer without a cast
    drivers/char/ip2main.c:2912: warning: assignment makes integer from pointer without a cast
    etc.

    This ioctl is copying the kernel virtual address of a large number of
    functions out to userspace. Heaven knows why.

    Rather than fixing the warnings, I think we'll just nuke that code.

    The patch also fixes a couple of `defined but not used' warnings.

    Cc: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • By including version.h edac_mc was rebuilding on every incremental build.
    Which defeats the point of incremental builds.

    Signed-off-by: Eric W. Biederman
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric W. Biederman
     
  • Change locking in the new tty buffering facility from using tty->read_lock,
    which is currently ignored by drivers and thus ineffective. New locking
    uses a new tty buffering specific lock enforced centrally in the tty
    buffering code.

    Two drivers (esp and cyclades) are updated to use the tty buffering
    functions instead of accessing tty buffering internals directly. This is
    required for the new locking to work.

    Minor checks for NULL buffers added to
    tty_prepare_flip_string/tty_prepare_flip_string_flags

    Signed-off-by: Paul Fulghum
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul Fulghum
     
  • On mips:

    drivers/char/ipmi/ipmi_si_intf.c:1274: error: conflicting types for 'mem_inb'
    include/asm/io.h:436: error: previous definition of 'mem_inb' was here

    Don't look at line 436 unless you really know what you're doing.

    Move those static functions out of more or less generic namespace.

    Signed-off-by: Alexey "## should be banned" Dobriyan
    Acked-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • The patch implements cpu topology exportation by sysfs.

    Items (attributes) are similar to /proc/cpuinfo.

    1) /sys/devices/system/cpu/cpuX/topology/physical_package_id:
    represent the physical package id of cpu X;
    2) /sys/devices/system/cpu/cpuX/topology/core_id:
    represent the cpu core id to cpu X;
    3) /sys/devices/system/cpu/cpuX/topology/thread_siblings:
    represent the thread siblings to cpu X in the same core;
    4) /sys/devices/system/cpu/cpuX/topology/core_siblings:
    represent the thread siblings to cpu X in the same physical package;

    To implement it in an architecture-neutral way, a new source file,
    driver/base/topology.c, is to export the 5 attributes.

    If one architecture wants to support this feature, it just needs to
    implement 4 defines, typically in file include/asm-XXX/topology.h.
    The 4 defines are:
    #define topology_physical_package_id(cpu)
    #define topology_core_id(cpu)
    #define topology_thread_siblings(cpu)
    #define topology_core_siblings(cpu)

    The type of **_id is int.
    The type of siblings is cpumask_t.

    To be consistent on all architectures, the 4 attributes should have
    deafult values if their values are unavailable. Below is the rule.

    1) physical_package_id: If cpu has no physical package id, -1 is the
    default value.

    2) core_id: If cpu doesn't support multi-core, its core id is 0.

    3) thread_siblings: Just include itself, if the cpu doesn't support
    HT/multi-thread.

    4) core_siblings: Just include itself, if the cpu doesn't support
    multi-core and HT/Multi-thread.

    So be careful when declaring the 4 defines in include/asm-XXX/topology.h.

    If an attribute isn't defined on an architecture, it won't be exported.

    Thank Nathan, Greg, Andi, Paul and Venki.

    The patch provides defines for i386/x86_64/ia64.

    Signed-off-by: Zhang, Yanmin
    Cc: Ingo Molnar
    Cc: Nick Piggin
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Zhang, Yanmin
     
  • j->write_buffer_rp is a pointer.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     
  • - jsm_driver.c: remove the now unused jsm_rawreadok module_param
    - jsm_tty.c: remove a now unused variable

    Is there any problem with removing the now useless jsm_rawreadok
    module_param?

    Signed-off-by: Adrian Bunk
    Cc: V. Ananda Krishnan
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Signed-off-by: V. Ananda Krishnan
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    V. Ananda Krishnan
     
  • - This controller violates the I2O spec for the I/O registers. The patch
    contains a workaround which moves the registers to the proper location.
    (originally author: Matthew Starzewski)

    - If a message frame is beyond the mapped address range a error is
    returned.

    Signed-off-by: Markus Lidel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Markus Lidel
     
  • If PCI device is enabled before probing, it will not be disabled at exit.

    Signed-off-by: Markus Lidel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Markus Lidel