Eric Lee / smarc-fsl-linux-kernel

05 Feb, 2006

3 commits

  • ee4bb818a   [NETFILTER]: Fix possible overflow in netfilters do_replace() ... Browse Code »

    netfilter's do_replace() can overflow on addition within SMP_ALIGN()
    and/or on multiplication by NR_CPUS, resulting in a buffer overflow on
    the copy_from_user(). In practice, the overflow on addition is
    triggerable on all systems, whereas the multiplication one might require
    much physical memory to be present due to the check above. Either is
    sufficient to overwrite arbitrary amounts of kernel memory.

    I really hate adding the same check to all 4 versions of do_replace(),
    but the code is duplicate...

    Found by Solar Designer during security audit of OpenVZ.org

    Signed-Off-By: Kirill Korotaev
    Signed-Off-By: Solar Designer
    Signed-off-by: Patrck McHardy
    Signed-off-by: David S. Miller

    Kirill Korotaev
     
  • ad2ad0f96   [NETFILTER]: Fix undersized skb allocation in ipt_ULOG/ebt_ulog/nfnetlink_log ... Browse Code »

    The skb allocated is always of size nlbufsize, even if that is smaller than
    the size needed for the current packet.

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • c2db29243   [NETFILTER]: ULOG/nfnetlink_log: Use better default value for 'nlbufsiz' ... Browse Code »

    Performance tests showed that ULOG may fail on heavy loaded systems
    because of failed order-N allocations (N >= 1).

    The default value of 4096 is not optimal in the sense that it actually
    allocates _two_ contigous physical pages. Reasoning: ULOG uses
    alloc_skb(), which adds another ~300 bytes for skb_shared_info.

    This patch sets the default value to NLMSG_GOODSIZE and adds some
    documentation at the top.

    Signed-off-by: Holger Eitzenberger
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Holger Eitzenberger
     

01 Feb, 2006

1 commit

  • 3f4cfc2d1   [BRIDGE]: Fix device delete race. ... Browse Code »

    This is a simpler fix for the two races in bridge device removal.
    The Xen race of delif and notify is managed now by a new deleted flag.
    No need for barriers or other locking because of rtnl mutex.

    The del_timer_sync()'s are unnecessary, because br_stp_disable_port
    delete's the timers, and they will finish running before RCU callback.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

18 Jan, 2006

1 commit

13 Jan, 2006

1 commit

  • 2e4e6a17a   [NETFILTER] x_tables: Abstraction layer for {ip,ip6,arp}_tables ... Browse Code »

    This monster-patch tries to do the best job for unifying the data
    structures and backend interfaces for the three evil clones ip_tables,
    ip6_tables and arp_tables. In an ideal world we would never have
    allowed this kind of copy+paste programming... but well, our world
    isn't (yet?) ideal.

    o introduce a new x_tables module
    o {ip,arp,ip6}_tables depend on this x_tables module
    o registration functions for tables, matches and targets are only
    wrappers around x_tables provided functions
    o all matches/targets that are used from ip_tables and ip6_tables
    are now implemented as xt_FOOBAR.c files and provide module aliases
    to ipt_FOOBAR and ip6t_FOOBAR
    o header files for xt_matches are in include/linux/netfilter/,
    include/linux/netfilter_{ipv4,ipv6} contains compatibility wrappers
    around the xt_FOOBAR.h headers

    Based on this patchset we're going to further unify the code,
    gradually getting rid of all the layer 3 specific assumptions.

    Signed-off-by: Harald Welte
    Signed-off-by: David S. Miller

    Harald Welte
     

12 Jan, 2006

3 commits

11 Jan, 2006

2 commits

07 Jan, 2006

2 commits

06 Jan, 2006

1 commit

05 Jan, 2006

2 commits

04 Jan, 2006

8 commits

27 Dec, 2005

1 commit

  • 79cac2a22   [BR_NETFILTER]: Fix leak if skb traverses > 1 bridge ... Browse Code »

    Call nf_bridge_put() before allocating a new nf_bridge structure and
    potentially overwriting the pointer to a previously allocated one.
    This fixes a memory leak which can occur when the bridge topology
    allows for an skb to traverse more than one bridge.

    Signed-off-by: David Kimdon
    Signed-off-by: David S. Miller

    David Kimdon
     

20 Dec, 2005

1 commit

  • b03664869   [BRIDGE-NF]: Fix bridge-nf ipv6 length check ... Browse Code »

    A typo caused some bridged IPv6 packets to get dropped randomly,
    as reported by Sebastien Chaumontet. The patch below fixes this
    (using skb->nh.raw instead of raw) and also makes the jumbo packet
    length checking up-to-date with the code in
    net/ipv6/exthdrs.c::ipv6_hop_jumbo.

    Signed-off-by: Bart De Schuymer
    Signed-off-by: David S. Miller

    Bart De Schuymer
     

24 Nov, 2005

1 commit

  • 133747e8d   [BRIDGE]: recompute features when adding a new device ... Browse Code »

    We must recompute bridge features everytime the list of underlying
    devices changes, or we might end up with features that are not
    supported by all devices (eg. NETIF_F_TSO)
    This patch adds the missing recompute when adding a device to the bridge.

    Signed-off-by: Olaf Rempel
    Signed-off-by: David S. Miller

    Olaf Rempel
     

01 Nov, 2005

1 commit

14 Oct, 2005

1 commit

  • c8923c6b8   [NETFILTER]: Fix OOPSes on machines with discontiguous cpu numbering. ... Browse Code »

    Original patch by Harald Welte, with feedback from Herbert Xu
    and testing by Sébastien Bernard.

    EBTABLES, ARP tables, and IP/IP6 tables all assume that cpus
    are numbered linearly. That is not necessarily true.

    This patch fixes that up by calculating the largest possible
    cpu number, and allocating enough per-cpu structure space given
    that.

    Signed-off-by: David S. Miller

    David S. Miller
     

13 Oct, 2005

1 commit

  • ab4060e85   [BRIDGE]: fix race on bridge del if ... Browse Code »

    This fixes the RCU race on bridge delete interface. Basically,
    the network device has to be detached from the bridge in the first
    step (pre-RCU), rather than later. At that point, no more bridge traffic
    will come in, and the other code will not think that network device
    is part of a bridge.

    This should also fix the XEN test problems.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

23 Sep, 2005

1 commit

15 Sep, 2005

1 commit

30 Aug, 2005

6 commits

  • ba89966c1   [NET]: use __read_mostly on kmem_cache_t , DEFINE_SNMP_STAT pointers ... Browse Code »

    This patch puts mostly read only data in the right section
    (read_mostly), to help sharing of these data between CPUS without
    memory ping pongs.

    On one of my production machine, tcp_statistics was sitting in a
    heavily modified cache line, so *every* SNMP update had to force a
    reload.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • 066286071   [NETLINK]: Add "groups" argument to netlink_kernel_create ... Browse Code »

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • ac6d439d2   [NETLINK]: Convert netlink users to use group numbers instead of bitmasks ... Browse Code »

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • a61bbcf28   [NET]: Store skb->timestamp as offset to a base timestamp ... Browse Code »

    Reduces skb size by 8 bytes on 64-bit.

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • 4fdb3bb72   [NETLINK]: Add properly module refcounting for kernel netlink sockets. ... Browse Code »

    - Remove bogus code for compiling netlink as module
    - Add module refcounting support for modules implementing a netlink
    protocol
    - Add support for autoloading modules that implement a netlink protocol
    as soon as someone opens a socket for that protocol

    Signed-off-by: Harald Welte
    Signed-off-by: David S. Miller

    Harald Welte
     
  • 6869c4d8e   [NETFILTER]: reduce netfilter sk_buff enlargement ... Browse Code »

    As discussed at netconf'05, we're trying to save every bit in sk_buff.
    The patch below makes sk_buff 8 bytes smaller. I did some basic
    testing on my notebook and it seems to work.

    The only real in-tree user of nfcache was IPVS, who only needs a
    single bit. Unfortunately I couldn't find some other free bit in
    sk_buff to stuff that bit into, so I introduced a separate field for
    them. Maybe the IPVS guys can resolve that to further save space.

    Initially I wanted to shrink pkt_type to three bits (PACKET_HOST and
    alike are only 6 values defined), but unfortunately the bluetooth code
    overloads pkt_type :(

    The conntrack-event-api (out-of-tree) uses nfcache, but Rusty just
    came up with a way how to do it without any skb fields, so it's safe
    to remove it.

    - remove all never-implemented 'nfcache' code
    - don't have ipvs code abuse 'nfcache' field. currently get's their own
    compile-conditional skb->ipvs_property field. IPVS maintainers can
    decide to move this bit elswhere, but nfcache needs to die.
    - remove skb->nfcache field to save 4 bytes
    - move skb->nfctinfo into three unused bits to save further 4 bytes

    Signed-off-by: Harald Welte
    Signed-off-by: David S. Miller

    Harald Welte
     

20 Jul, 2005

1 commit

  • eb3f8f5e2   [NET]: BRIDGE_EBT_ARPREPLY must depend on INET ... Browse Code »

    BRIDGE_EBT_ARPREPLY=y and INET=n results in the following compile error:

    net/built-in.o: In function `ebt_target_reply':
    ebt_arpreply.c:(.text+0x68fb9): undefined reference to `arp_send'
    make: *** [.tmp_vmlinux1] Error 1

    Signed-off-by: Adrian Bunk
    Signed-off-by: David S. Miller

    Adrian Bunk
     

12 Jul, 2005

1 commit

  • 6a2e9b738   [NET]: move config options out to individual protocols ... Browse Code »

    Move the protocol specific config options out to the specific protocols.
    With this change net/Kconfig now starts to become readable and serve as a
    good basis for further re-structuring.

    The menu structure is left almost intact, except that indention is
    fixed in most cases. Most visible are the INET changes where several
    "depends on INET" are replaced with a single ifdef INET / endif pair.

    Several new files were created to accomplish this change - they are
    small but serve the purpose that config options are now distributed
    out where they belongs.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: David S. Miller

    Sam Ravnborg