26 Apr, 2007

9 commits


13 Mar, 2007

1 commit


06 Mar, 2007

1 commit

  • In active-backup mode, the current bonding code duplicates IGMP
    traffic to all slaves, so that switches are up to date in case of a
    failover from an active to a backup interface. If bonding then fails
    back to the original active interface, it is likely that the "active
    slave" switch's IGMP forwarding for the port will be out of date until
    some event occurs to refresh the switch (e.g., a membership query).

    This patch alters the behavior of bonding to no longer flood
    IGMP to all ports, and to issue IGMP JOINs to the newly active port at
    the time of a failover. This insures that switches are kept up to date
    for all cases.

    "GOELLESCH Niels" originally
    reported this problem, and included a patch. His original patch was
    modified by Jay Vosburgh to additionally remove the existing IGMP flood
    behavior, use RCU, streamline code paths, fix trailing white space, and
    adjust for style.

    Signed-off-by: Jay Vosburgh
    Signed-off-by: Jeff Garzik

    Jay Vosburgh
     

13 Feb, 2007

1 commit

  • Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

11 Feb, 2007

1 commit


09 Feb, 2007

1 commit


03 Dec, 2006

1 commit


29 Sep, 2006

5 commits


23 Sep, 2006

2 commits


18 Aug, 2006

2 commits


22 Jul, 2006

1 commit


01 Jul, 2006

1 commit


18 Jun, 2006

1 commit


21 Mar, 2006

2 commits


08 Feb, 2006

1 commit


01 Feb, 2006

1 commit


31 Jan, 2006

1 commit


19 Jan, 2006

1 commit

  • 1) fix "mld_marksources()" to
    a) send nothing when all queried sources are excluded
    b) send full exclude report when source queried sources are
    not excluded
    c) don't schedule a timer when there's nothing to report

    2) fix "add_grec()" to send empty-source records when it should
    The original check doesn't account for a non-empty source
    list with all sources inactive; the new code keeps that
    short-circuit case, and also generates the group header
    with an empty list if needed.

    3) fix mca_crcount decrement to be after add_grec(), which needs
    its original value

    4) add/remove delete records and prevent current advertisements
    when an exclude-mode filter moves from "active" to "inactive"
    or vice versa based on new filter additions.

    Items 1-3 are just IPv4 versions of the IPv6 bugs found
    by Yan Zheng and fixed earlier. Item #4 is a related bug that
    affects exclude-mode change records only (but not queries) and
    also occurs in IPv6 (IPv6 version coming soon).

    Signed-off-by: David L Stevens
    Signed-off-by: David S. Miller

    David L Stevens
     

12 Jan, 2006

1 commit


04 Jan, 2006

1 commit


03 Dec, 2005

1 commit

  • From: David Stevens

    As explained at:

    http://www.cs.ucsb.edu/~krishna/igmp_dos/

    With IGMP version 1 and 2 it is possible to inject a unicast
    report to a client which will make it ignore multicast
    reports sent later by the router.

    The fix is to only accept the report if is was sent to a
    multicast or unicast address.

    Signed-off-by: David S. Miller

    David Stevens
     

11 Nov, 2005

1 commit

  • Here is the patch that introduces the generic skb_checksum_complete
    which also checks for hardware RX checksum faults. If that happens,
    it'll call netdev_rx_csum_fault which currently prints out a stack
    trace with the device name. In future it can turn off RX checksum.

    I've converted every spot under net/ that does RX checksum checks to
    use skb_checksum_complete or __skb_checksum_complete with the
    exceptions of:

    * Those places where checksums are done bit by bit. These will call
    netdev_rx_csum_fault directly.

    * The following have not been completely checked/converted:

    ipmr
    ip_vs
    netfilter
    dccp

    This patch is based on patches and suggestions from Stephen Hemminger
    and David S. Miller.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

03 Nov, 2005

1 commit

  • And filter mode is exclude.

    Further explanation by David Stevens:

    Multicast source filters aren't widely used yet, and that's really the only
    feature that's affected if an application actually exercises this bug, as far
    as I can tell. An ordinary filter-less multicast join should still work, and
    only forwarded multicast traffic making use of filters and doing empty-source
    filters with the MSFILTER ioctl would be at risk of not getting multicast
    traffic forwarded to them because the reports generated would not be based on
    the correct counts.

    Signed-off-by: Yan Zheng
    Signed-off-by: Arnaldo Carvalho de Melo

    Yan Zheng
     

04 Oct, 2005

1 commit

  • The following patch renames __in_dev_get() to __in_dev_get_rtnl() and
    introduces __in_dev_get_rcu() to cover the second case.

    1) RCU with refcnt should use in_dev_get().
    2) RCU without refcnt should use __in_dev_get_rcu().
    3) All others must hold RTNL and use __in_dev_get_rtnl().

    There is one exception in net/ipv4/route.c which is in fact a pre-existing
    race condition. I've marked it as such so that we remember to fix it.

    This patch is based on suggestions and prior work by Suzanne Wood and
    Paul McKenney.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

15 Sep, 2005

1 commit