Eric Lee / smarc-fsl-linux-kernel

03 Sep, 2020

1 commit

28 Apr, 2020

1 commit

25 Feb, 2020

8 commits

  • d80cbef35   dmaengine: stm32-dma: use vchan_terminate_vdesc() in .terminate_all ... Browse Code »

    To avoid race with vchan_complete, use the race free way to terminate
    running transfer.

    Move vdesc->node list_del in stm32_dma_start_transfer instead of in
    stm32_mdma_chan_complete to avoid another race in vchan_dma_desc_free_list.

    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-9-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Amelie Delaunay
     
  • 409ffc4d9   dmaengine: stm32-dma: fix sleeping function called from invalid context ... Browse Code »

    This patch fixes BUG: sleeping function called from invalid context in
    stm32_dma_disable_chan function.

    The goal of this function is to force channel disable if it has not been
    disabled by hardware. This consists in clearing STM32_DMA_SCR_EN bit and
    read it as 0 to ensure the channel is well disabled and the last transfer
    is over.

    In previous implementation, the waiting loop was based on a do...while (1)
    with a call to cond_resched to give the scheduler a chance to run a higher
    priority process.

    But in some conditions, stm32_dma_disable_chan can be called while
    preemption is disabled, on a stm32_dma_stop call for example. So
    cond_resched must not be used.

    To avoid this, use readl_relaxed_poll_timeout_atomic to poll
    STM32_DMA_SCR_EN bit cleared.

    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-8-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Amelie Delaunay
     
  • 32ce10883   dmaengine: stm32-dma: add copy_align constraint ... Browse Code »

    This patch adds copy_align property in accordance with hardware
    restriction.

    Signed-off-by: Ludovic Barre
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-7-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Amelie Delaunay
     
  • d7a9e4260   dmaengine: stm32-dma: use dma_set_max_seg_size to set the sg limit ... Browse Code »

    This patch adds dma_set_max_seg_size to define sg dma constraint.
    This constraint may be taken into account by client to scatter/gather
    its buffer.

    Signed-off-by: Ludovic Barre
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-6-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Amelie Delaunay
     
  • 22a0bb297   dmaengine: stm32-dma: enable descriptor_reuse ... Browse Code »

    Enable client to resubmit already processed descriptors
    in order to save descriptor creation time.

    Signed-off-by: Pierre-Yves MORDRET
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-5-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Pierre-Yves MORDRET
     
  • 615eee2c4   dmaengine: stm32-dma: driver defers probe for reset ... Browse Code »

    Change STM32 DMA driver to defer its probe operation when reset
    controller is expected but has not been probed yet when DMA
    device is probed.

    Changes error traces when failing to get a system resource so that
    it is not printed on failure with deferred probing.

    Signed-off-by: Etienne Carriere
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-4-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Etienne Carriere
     
  • 8cf1e0fc5   dmaengine: stm32-dma: use reset controller only at probe time ... Browse Code »

    Remove reset controller reference from device instance since it is
    used only at probe time.

    Signed-off-by: Etienne Carriere
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-3-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Etienne Carriere
     
  • 05f8740a0   dmaengine: stm32-dma: add suspend/resume power management support ... Browse Code »

    Add suspend/resume power management relying on PM Runtime engine.

    Signed-off-by: Pierre-Yves MORDRET
    Signed-off-by: Amelie Delaunay
    Link: https://lore.kernel.org/r/20200129153628.29329-2-amelie.delaunay@st.com
    Signed-off-by: Vinod Koul

    Pierre-Yves MORDRET
     

04 Sep, 2019

1 commit

  • 402096cb5   dmaengine: stm32-dma: Use struct_size() helper ... Browse Code »

    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:

    struct stm32_dma_desc {
    ...
    struct stm32_dma_sg_req sg_req[];
    };

    Make use of the struct_size() helper instead of an open-coded version
    in order to avoid any potential type mistakes.

    So, replace the following function:

    static struct stm32_dma_desc *stm32_dma_alloc_desc(u32 num_sgs)
    {
    return kzalloc(sizeof(struct stm32_dma_desc) +
    sizeof(struct stm32_dma_sg_req) * num_sgs, GFP_NOWAIT);
    }

    with:

    kzalloc(struct_size(desc, sg_req, num_sgs), GFP_NOWAIT)

    This code was detected with the help of Coccinelle.

    Signed-off-by: Gustavo A. R. Silva
    Link: https://lore.kernel.org/r/20190830161423.GA3483@embeddedor
    Signed-off-by: Vinod Koul

    Gustavo A. R. Silva
     

31 Jul, 2019

1 commit

  • e17be6e1b   dmaengine: Remove dev_err() usage after platform_get_irq() ... Browse Code »

    We don't need dev_err() messages when platform_get_irq() fails now that
    platform_get_irq() prints an error message itself when something goes
    wrong. Let's remove these prints with a simple semantic patch.

    //
    @@
    expression ret;
    struct platform_device *E;
    @@

    ret =
    (
    platform_get_irq(E, ...)
    |
    platform_get_irq_byname(E, ...)
    );

    if ( \( ret < 0 \| ret

    While we're here, remove braces on if statements that only have one
    statement (manually).

    Cc: Vinod Koul
    Cc: Dan Williams
    Cc: dmaengine@vger.kernel.org
    Cc: Greg Kroah-Hartman
    Signed-off-by: Stephen Boyd
    Link: https://lore.kernel.org/r/20190730181557.90391-11-swboyd@chromium.org
    Signed-off-by: Vinod Koul

    Stephen Boyd
     

18 Jul, 2019

1 commit

  • 47ebe00b6   Merge tag 'dmaengine-5.3-rc1' of git://git.infradead.org/users/vkoul/slave-dma ... Browse Code »

    Pull dmaengine updates from Vinod Koul:

    - Add support in dmaengine core to do device node checks for DT devices
    and update bunch of drivers to use that and remove open coding from
    drivers

    - New driver/driver support for new hardware, namely:
    - MediaTek UART APDMA
    - Freescale i.mx7ulp edma2
    - Synopsys eDMA IP core version 0
    - Allwinner H6 DMA

    - Updates to axi-dma and support for interleaved cyclic transfers

    - Greg's debugfs return value check removals on drivers

    - Updates to stm32-dma, hsu, dw, pl330, tegra drivers

    * tag 'dmaengine-5.3-rc1' of git://git.infradead.org/users/vkoul/slave-dma: (68 commits)
    dmaengine: Revert "dmaengine: fsl-edma: add i.mx7ulp edma2 version support"
    dmaengine: at_xdmac: check for non-empty xfers_list before invoking callback
    Documentation: dmaengine: clean up description of dmatest usage
    dmaengine: tegra210-adma: remove PM_CLK dependency
    dmaengine: fsl-edma: add i.mx7ulp edma2 version support
    dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma
    dmaengine: fsl-edma-common: version check for v2 instead
    dmaengine: fsl-edma-common: move dmamux register to another single function
    dmaengine: fsl-edma: add drvdata for fsl-edma
    dmaengine: Revert "dmaengine: fsl-edma: support little endian for edma driver"
    dmaengine: rcar-dmac: Reject zero-length slave DMA requests
    dmaengine: dw: Enable iDMA 32-bit on Intel Elkhart Lake
    dmaengine: dw-edma: fix semicolon.cocci warnings
    dmaengine: sh: usb-dmac: Use [] to denote a flexible array member
    dmaengine: dmatest: timeout value of -1 should specify infinite wait
    dmaengine: dw: Distinguish ->remove() between DW and iDMA 32-bit
    dmaengine: fsl-edma: support little endian for edma driver
    dmaengine: hsu: Revert "set HSU_CH_MTSR to memory width"
    dmagengine: pl330: add code to get reset property
    dt-bindings: pl330: document the optional resets property
    ...

    Linus Torvalds
     

31 May, 2019

1 commit

  • af873fcec   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194 ... Browse Code »

    Based on 1 normalized pattern(s):

    license terms gnu general public license gpl version 2

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 161 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Alexios Zavras
    Reviewed-by: Steve Winslow
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190528170027.447718015@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit

04 May, 2019

1 commit

  • 2a4885abf   dmaengine: stm32-dma: fix residue calculation in stm32-dma ... Browse Code »

    In double buffer mode, during residue calculation, the DMA can
    automatically switch to the next transfer. Indeed the CT bit that
    gives position in the double buffer can has been updated by the
    hardware, during calculation.
    In this case the SxNDTR register value can not be trusted.
    If a transition is detected we consider that the DMA has switched to
    the beginning of next sg.

    Signed-off-by: Arnaud Pouliquen
    Signed-off-by: Pierre-Yves MORDRET
    Signed-off-by: Vinod Koul

    Arnaud Pouliquen
     

29 Apr, 2019

1 commit

  • c6504be53   dmaengine: stm32-dma: Fix unsigned variable compared with zero ... Browse Code »

    Commit f4fd2ec08f17: ("dmaengine: stm32-dma: use platform_get_irq()") used
    unsigned variable irq to store the results and check later for negative
    errors, so update the code to use signed variable for this

    Fixes: f4fd2ec08f17 ("dmaengine: stm32-dma: use platform_get_irq()")
    Reported-by: kbuild test robot
    Reported-by: Julia Lawall
    Acked-by: Julia Lawall
    Signed-off-by: Vinod Koul

    Vinod Koul
     

27 Apr, 2019

1 commit

  • f4fd2ec08   dmaengine: stm32-dma: use platform_get_irq() ... Browse Code »

    platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
    requesting IRQ's resources, as they can be not ready yet. Using
    platform_get_irq() instead is preferred for getting IRQ even if it was
    not retrieved earlier.

    Signed-off-by: Fabien Dessenne
    Reviewed-by: Pierre-Yves MORDRET
    Signed-off-by: Vinod Koul

    Fabien Dessenne
     

07 Jan, 2019

2 commits

02 Oct, 2018

1 commit

10 Jul, 2018

1 commit

04 Apr, 2018

7 commits

06 Mar, 2017

1 commit

22 Feb, 2017

1 commit

  • 97a229f90   Merge tag 'dmaengine-4.11-rc1' of git://git.infradead.org/users/vkoul/slave-dma ... Browse Code »

    Pull dmaengine updates from Vinod Koul:
    "This time we fairly boring and bit small update.

    - Support for Intel iDMA 32-bit hardware
    - deprecate broken support for channel switching in async_tx
    - bunch of updates on stm32-dma
    - Cyclic support for zx dma and making in generic zx dma driver
    - Small updates to bunch of other drivers"

    * tag 'dmaengine-4.11-rc1' of git://git.infradead.org/users/vkoul/slave-dma: (29 commits)
    async_tx: deprecate broken support for channel switching
    dmaengine: rcar-dmac: Widen DMA mask to 40 bits
    dmaengine: sun6i: allow build on ARM64 platforms (sun50i)
    dmaengine: Provide a wrapper for memcpy operations
    dmaengine: zx: fix build warning
    dmaengine: dw: we do support Merrifield SoC in PCI mode
    dmaengine: dw: add support of iDMA 32-bit hardware
    dmaengine: dw: introduce register mappings for iDMA 32-bit
    dmaengine: dw: introduce block2bytes() and bytes2block()
    dmaengine: dw: extract dwc_chan_pause() for future use
    dmaengine: dw: replace convert_burst() with one liner
    dmaengine: dw: register IRQ and DMA pool with instance ID
    dmaengine: dw: Fix data corruption in large device to memory transfers
    dmaengine: ste_dma40: indicate granularity on channels
    dmaengine: ste_dma40: indicate directions on channels
    dmaengine: stm32-dma: Add error messages if xlate fails
    dmaengine: dw: pci: remove LPE Audio DMA ID
    dmaengine: stm32-dma: Add max_burst support
    dmaengine: stm32-dma: Add synchronization support
    dmaengine: stm32-dma: Fix residue computation issue in cyclic mode
    ...

    Linus Torvalds
     

10 Jan, 2017

1 commit

03 Jan, 2017

4 commits

02 Jan, 2017

2 commits

13 Dec, 2016

2 commits

  • cad0eca39   dmaengine: stm32-dma: remove unused ‘src_addr’ ... Browse Code »

    In stm32_dma_set_xfer_param(), variable ‘src_addr’ is initialized but never used, which
    leads to warning with W=1

    drivers/dma/stm32-dma.c: In function ‘stm32_dma_set_xfer_param’:
    drivers/dma/stm32-dma.c:577:13: warning: variable ‘src_addr’ set but not used [-Wunused-but-set-variable]
    dma_addr_t src_addr, dst_addr;

    So remove it.

    Reviewed-by: M'boumba Cedric Madianga
    Signed-off-by: Vinod Koul

    Vinod Koul
     
  • 2a440bd41   dmaengine: stm32-dma: remove unused ‘dst_addr’ ... Browse Code »

    In stm32_dma_set_xfer_param(), variable ‘dst_addr’ is initialized but never used, which
    leads to warning with W=1

    drivers/dma/stm32-dma.c: In function ‘stm32_dma_set_xfer_param’:
    drivers/dma/stm32-dma.c:577:23: warning: variable ‘dst_addr’ set but not used [-Wunused-but-set-variable]
    dma_addr_t src_addr, dst_addr;

    So remove it.

    Reviewed-by: M'boumba Cedric Madianga
    Signed-off-by: Vinod Koul

    Vinod Koul