23 Nov, 2011
1 commit
-
10-bit addresses overlap with traditional 7-bit addresses, leading in
device name collisions. Add an arbitrary offset to 10-bit addresses to
prevent this collision. The offset was chosen so that the address is
still easily recognizable.Signed-off-by: Jean Delvare
Acked-by: Wolfram Sang
25 Jul, 2011
1 commit
-
Currently, if an i2c bus driver supports both static and dynamic bus
ids, it needs to choose between calling i2c_add_numbered_adapter() and
i2c_add_adapter(). This patch makes i2c_add_numbered_adapter()
redirect to i2c_add_adapter() if the requested bus id is -1.Signed-off-by: Grant Likely
Signed-off-by: Jean Delvare
17 Apr, 2011
1 commit
-
When warning on the use of deprecated i2c_driver methods
attach_adapter and detach_adapter, mention the name of the driver
which needs to be updated.Signed-off-by: Jean Delvare
Cc: Benjamin Herrenschmidt
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
20 Mar, 2011
3 commits
-
The last legitimate user of i2c_driver.attach_adapter and
.detach_adapter is gone, so we can finally deprecate these callbacks.
The last few drivers which still use these will have to be updated to
make use of standard I2C device instantiation ways instead.Signed-off-by: Jean Delvare
-
Introduce i2c_for_each_dev(), an i2c device iterator with proper
locking for use by i2c-dev. This is needed so that we can get rid of
the attach_adapter and detach_adapter legacy callback functions.Signed-off-by: Jean Delvare
-
Rename the parameter of i2c_get_adapter() to "nr", to make it clear we
are passing an adapter number and not an adapter ID (which have gone
away by now.)Signed-off-by: Jean Delvare
22 Jan, 2011
1 commit
-
Having conditional around the of_match_table and the of_node pointers
turns out to make driver code use ugly #ifdef blocks. Drop the
conditionals and remove the #ifdef blocks from the affected drivers.Also tidy up minor whitespace issues within the same hunks.
Signed-off-by: Grant Likely
Acked-by: Greg Kroah-Hartman
15 Jan, 2011
3 commits
-
Since the PM core wishes to transition away from the legacy suspend
and resume methods and since removing them makes using PM core features
like runtime PM much easier start warning when a driver is registered
using the legacy methods.Signed-off-by: Mark Brown
Signed-off-by: Jean Delvare -
When devices use dev_pm_ops the I2C API is implementing standard functionality
for integration with runtime PM and for checking for the presence of a per
device op. The PM core provides pm_generic_ functions implementing this
behaviour - use them to reduce coupling with future PM updates.Signed-off-by: Mark Brown
Signed-off-by: Jean Delvare -
Remove real devices first and dummy devices last. This gives device
driver which instantiated dummy devices themselves a chance to clean
them up before we do.Signed-off-by: Jean Delvare
Tested-by: Hans Verkuil
Cc: stable@kernel.org
11 Jan, 2011
1 commit
-
Helper functions for I2C and SMBus transactions don't modify the
i2c_client that is passed to them, so it can be marked const.Signed-off-by: Jean Delvare
16 Nov, 2010
1 commit
-
Make sure I2C adapters being registered have the required struct
fields set. If they don't, problems will happen later.Signed-off-by: Jean Delvare
25 Oct, 2010
3 commits
-
Check the class flags before allocating the temporary i2c_client
structure, to avoid allocating it when we don't need it.Also optimize the inner loop a bit.
Signed-off-by: Jean Delvare
Cc: Jacob Pan -
The "new_device" sysfs interface has been there for quite some time
now, nobody complained about it so it must be good enough. Time to
remove the warning and call it stable.Signed-off-by: Jean Delvare
Acked-by: Michael Lawnick -
This makes the calling site's code clearer IMHO.
Signed-off-by: Jean Delvare
Acked-by: Michael Lawnick
30 Sep, 2010
3 commits
-
Commit 959e85f7, "i2c: add OF-style registration and binding" caused a
module dependency loop where of_i2c.c calls functions in i2c-core, and
i2c-core calls of_i2c_register_devices() in of_i2c. This means that
when i2c support is built as a module when CONFIG_OF is set, then
neither i2c_core nor of_i2c are able to be loaded.This patch fixes the problem by moving the of_i2c_register_devices()
calls back into the device drivers. Device drivers already
specifically request the core code to parse the device tree for
devices anyway by setting the of_node pointer, so it isn't a big
deal to also call the registration function. The drivers just become
slightly more verbose.Signed-off-by: Grant Likely
Signed-off-by: Jean Delvare -
For devices which are not adapted to runtime PM a call to
pm_runtime_suspended always returns true.Hence the pm_runtime_suspended checks below prevent legacy
suspend from getting called.So do a pm_runtime_suspended check only for devices with a
dev_pm_ops populated (which hence do not rely on the legacy
suspend.)Signed-off-by: Rajendra Nayak
Acked-by: Rafael J. Wysocki
Cc: Ben Dooks
Cc: Mark Brown
Cc: Kevin Hilman
Signed-off-by: Jean Delvare -
In current i2c core driver, call to pm_runtime_set_active from
i2c_device_pm_resume will unconditionally enable i2c module and
increment child count of the parent. Because of this, in CPU Idle
path, i2c does not idle, preventing Core to enter retention. Also i2c
module will not be suspended upon system suspend as
pm_runtime_set_suspended is not called from i2c_device_pm_suspend.This issue is fixed by removing pm_runtime_set_active call from resume
path which is not necessary.
This fix has been tested on OMAP4430.Signed-off-by: Partha Basak
Signed-off-by: Vishwanath BS
Acked-by: Rafael J. Wysocki
Cc: Kevin Hilman
Cc: Ben Dooks
Signed-off-by: Jean Delvare
12 Aug, 2010
7 commits
-
Add multiplexed bus core support. I2C multiplexer and switches
like pca954x get instantiated as new adapters per port.Signed-off-by: Michael Lawnick
Acked-by: Rodolfo Giometti
Signed-off-by: Jean Delvare -
Moving userspace-instantiated clients to separate lists wasn't nearly
enough to avoid deadlocks in multiplexed bus cases. We also want to
have a dedicated mutex to protect each list.Signed-off-by: Jean Delvare
Cc: Michael Lawnick -
Make i2c_default_probe self-sufficient, so that callers don't have to
do functionality checks themselves. This ensures everything is and
will stay consistent.Signed-off-by: Jean Delvare
-
Now that bus_for_each_drv() is no longer __must_check, we can drop the
dummy variable that was used to store the returned value.Signed-off-by: Jean Delvare
Cc: Justin P. Mattock -
Uninline i2c adapter locking helper functions, move them to i2c-core,
and use them in i2c-core itself. The functions are still exported for
external users. This makes future updates to the locking model (which
will be needed for multiplexing support) possible and transparent.Signed-off-by: Jean Delvare
Cc: Michael Lawnick -
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.Signed-off-by: Jean Delvare
Acked-by: Mauro Carvalho Chehab -
The probe method used by i2c_new_probed_device() may not be suitable
for all cases. Let the caller provide its own, optional probe
function.Signed-off-by: Jean Delvare
Acked-by: Mauro Carvalho Chehab
24 Jul, 2010
1 commit
-
Conflicts:
arch/sparc/kernel/prom_64.c
10 Jul, 2010
1 commit
-
The new unified probing function differs from the original code, and
the preliminary test whether probing is possible must be updated
accordingly.Signed-off-by: Jean Delvare
06 Jul, 2010
1 commit
-
This patch adds OF hooks to the i2c core so that devices can automatically
be registered based on device tree data.Signed-off-by: Grant Likely
03 Jun, 2010
4 commits
-
Otherwise it's not clear what it is checking.
Also move the function to save a forward declaration.
Signed-off-by: Jean Delvare
-
Move strict I2C address validity check to a single function, and
document the reserved I2C addresses there.Signed-off-by: Jean Delvare
Cc: Hans Verkuil -
Do basic address validity checks when a client is being registered. We
already had checks in place for devices which are being detected, but
not for devices which are simply instantiated.This is a very basic check. We don't want to do strict checking here
because some devices are known to infringe the I2C address constraints
(e.g. IR receivers at 7-bit address 0x7a while this value is
supposedly reserved for 10-bit addresses.) So we assume the caller
knows what it is doing.Signed-off-by: Jean Delvare
Cc: Matthieu Castet -
Use the same I2C device presence detection code for legacy and new
device detection functions. This is more consistent and makes the code
smaller.Signed-off-by: Jean Delvare
Cc: Matthieu Castet
22 May, 2010
2 commits
-
Merging in current state of Linus' tree to deal with merge conflicts and
build failures in vio.c after merge.Conflicts:
drivers/i2c/busses/i2c-cpm.c
drivers/i2c/busses/i2c-mpc.c
drivers/net/gianfar.cAlso fixed up one line in arch/powerpc/kernel/vio.c to use the
correct node pointer.Signed-off-by: Grant Likely
-
Fix up coding style issues found by the checkpatch.pl tool.
Signed-off-by: Farid Hammane
Signed-off-by: Jean Delvare
11 May, 2010
1 commit
-
There are three issues with the i2c bus type's power management
callbacks at the moment. First, they don't include any hibernate
callbacks, although they should at least include the .restore()
callback (there's no guarantee that the driver will be present in
memory before loading the image kernel and we must restore the
pre-hibernation state of the device). Second, the "legacy"
callbacks are not going to be invoked by the PM core since the bus
type's pm object is not NULL. Finally, the system sleep PM
(ie. suspend/resume) callbacks don't check if the device has been
already suspended at run time, in which case they should skip
suspending it. Also, it looks like the i2c bus type can use the
generic subsystem-level runtime PM callbacks.For these reasons, rework the system sleep PM callbacks provided by
the i2c bus type to handle hibernation correctly and to invoke the
"legacy" callbacks for drivers that provide them. In addition to
that make the i2c bus type use the generic subsystem-level runtime
PM callbacks.Signed-off-by: Rafael J. Wysocki
Acked-by: Mark Brown
Acked-by: Jean Delvare
04 May, 2010
3 commits
-
Using a single list for all userspace devices leads to a dead lock
on multiplexed buses in some circumstances (mux chip instantiated
from userspace). This is solved by using a separate list for each
bus segment.Signed-off-by: Jean Delvare
Acked-by: Michael Lawnick -
Some FSC hardware monitoring chips (Syleus at least) doesn't like
quick writes we typically use to probe for I2C chips. Use a regular
byte read instead for the address they live at (0x73). These are the
only known chips living at this address on PC systems.For clarity, this fix should not be needed for kernels 2.6.30 and
later, as we started instantiating the hwmon devices explicitly based
on DMI data. Still, this fix is valuable in the following two cases:
* Support for recent FSC chips on older kernels. The DMI-based device
instantiation is more difficult to backport than the device support
itself.
* Case where the DMI-based device instantiation fails, whatever the
reason. We fall back to probing in that case, so it should work.This fixes kernel bug #15634:
https://bugzilla.kernel.org/show_bug.cgi?id=15634Signed-off-by: Jean Delvare
Acked-by: Hans de Goede
Cc: stable@kernel.org -
After discovering that a lot of i2c-drivers leave the pointer to their
clientdata dangling, it was decided to let the core handle this issue.
It is assumed that the core may access the private data after remove()
as there are no guarantees for the lifetime of such pointers anyhow (see
thread starting at http://lkml.org/lkml/2010/3/21/68)Signed-off-by: Wolfram Sang
Signed-off-by: Jean Delvare
29 Apr, 2010
1 commit
-
The struct device_node *of_node pointer is moving out of dev->archdata
and into the struct device proper. of_i2c.c needs to set the of_node
pointer before the device is registered. Since the i2c subsystem
doesn't allow 2 stage allocation and registration of i2c devices, the
of_node pointer needs to be passed via the i2c_board_info structure
so that it is set prior to registration.This patch adds of_node to struct i2c_board_info (conditional on
CONFIG_OF), sets of_node in i2c_new_device(), and modifies of_i2c.c
to use the new parameter. The calling of dev_archdata_set_node()
from of_i2c will be removed in a subsequent patch when of_node is
removed from archdata and all users are converted over.Signed-off-by: Grant Likely