Eric Lee / smarc-fsl-linux-kernel

31 Mar, 2011

1 commit

28 Oct, 2010

1 commit

  • f35691062   drivers/video/gbefb.c: eliminate memory leak ... Browse Code »

    This code is preceded by a call to framebuffer_alloc, which allocates
    memory, so this memory should be freed before leaving the function in an
    error case. out_release_framebuffer just frees the frame buffer and
    returns.

    A simplified version of the semantic match that finds this problem is:
    (http://coccinelle.lip6.fr/)

    //
    @r exists@
    local idexpression x;
    expression E;
    identifier f1;
    iterator I;
    @@

    x = framebuffer_alloc(...);
    }
    when != I (...) { }
    (
    x == NULL
    |
    x == E
    |
    x->f1
    )
    ...>
    * return ...;
    //

    Signed-off-by: Julia Lawall
    Cc: Ralf Baechle
    Cc: Arnaud Patard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

27 Jul, 2010

1 commit

  • 18f9f11a0   VIDEO. gbefb: Fix section mismatches. ... Browse Code »

    WARNING: drivers/video/built-in.o(.devinit.text+0x54): Section mismatch in reference from the function gbefb_probe() to the function .init.text:gbefb_setup()
    The function __devinit gbefb_probe() references
    a function __init gbefb_setup().
    If gbefb_setup is only used by gbefb_probe then
    annotate gbefb_setup with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x208): Section mismatch in reference from the function gbefb_probe() to the variable .init.data:mode_option
    The function __devinit gbefb_probe() references
    a variable __initdata mode_option.
    If mode_option is only used by gbefb_probe then
    annotate mode_option with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x214): Section mismatch in reference from the function gbefb_probe() to the variable .init.data:default_mode
    The function __devinit gbefb_probe() references
    a variable __initdata default_mode.
    If default_mode is only used by gbefb_probe then
    annotate default_mode with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x23c): Section mismatch in reference from the function gbefb_probe() to the variable .init.data:default_var
    The function __devinit gbefb_probe() references
    a variable __initdata default_var.
    If default_var is only used by gbefb_probe then
    annotate default_var with a matching annotation.

    Fixing these results in more mismatches:

    WARNING: drivers/video/built-in.o(.devinit.text+0x3c): Section mismatch in reference from the function gbefb_setup() to the variable .init.data:default_var_LCD
    The function __devinit gbefb_setup() references
    a variable __initdata default_var_LCD.
    If default_var_LCD is only used by gbefb_setup then
    annotate default_var_LCD with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x14c): Section mismatch in reference from the function gbefb_setup() to the variable .init.data:default_mode_LCD
    The function __devinit gbefb_setup() references
    a variable __initdata default_mode_LCD.
    If default_mode_LCD is only used by gbefb_setup then
    annotate default_mode_LCD with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x150): Section mismatch in reference from the function gbefb_setup() to the variable .init.data:default_var_CRT
    The function __devinit gbefb_setup() references
    a variable __initdata default_var_CRT.
    If default_var_CRT is only used by gbefb_setup then
    annotate default_var_CRT with a matching annotation.

    WARNING: drivers/video/built-in.o(.devinit.text+0x154): Section mismatch in reference from the function gbefb_setup() to the variable .init.data:default_mode_CRT
    The function __devinit gbefb_setup() references
    a variable __initdata default_mode_CRT.
    If default_mode_CRT is only used by gbefb_setup then
    annotate default_mode_CRT with a matching annotation.

    Signed-off-by: Ralf Baechle

    Ralf Baechle
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

08 Mar, 2010

1 commit

  • c2e13037e   platform-drivers: move probe to .devinit.text in drivers/video ... Browse Code »

    A pointer to a probe callback is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König
    Cc: Adrian Bunk
    Cc: Alberto Mardegan
    Cc: Andrew Morton
    Cc: Andriy Skulysh
    Cc: Antonino Daplas
    Cc: Anton Vorontsov
    Cc: Ben Dooks
    Cc: Chandramouli Narayanan
    Cc: Christoph Hellwig
    Cc: Frans Pop
    Cc: Geert Uytterhoeven
    Cc: Greg Kroah-Hartman
    Cc: Helge Deller
    Cc: Huang Ying
    Cc: Ian Molton
    Cc: Joshua Kinard
    Cc: Kaj-Michael Lang
    Cc: Krzysztof Helt
    Cc: linux-fbdev-devel@lists.sourceforge.net
    Cc: Maciej W. Rozycki
    Cc: Magnus Damm
    Cc: Martin Michlmayr
    Cc: Matthias Kaehlcke
    Cc: Paul Mundt
    Cc: Pavel Machek
    Cc: Philipp Zabel
    Cc: Richard Purdie
    Cc: Roel Kluin
    Cc: Roland Stigge
    Cc: Russell King
    Cc: Thomas Bogendoerfer
    Cc: Vincent Sanders
    Cc: Yoichi Yuasa
    Acked-by: Ralf Baechle
    Acked-by: Arnaud Patard
    Acked-by: James Simmons
    Acked-by: Peter Jones
    Acked-by: Jaya Kumar
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

08 Dec, 2009

1 commit

04 Dec, 2009

1 commit

  • af901ca18   tree-wide: fix assorted typos all over the place ... Browse Code »

    That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

03 Dec, 2009

1 commit

  • 0fdd07f77   VIDEO: Correct use of request_region/request_mem_region ... Browse Code »

    request_region should be used with release_region, not request_mem_region.

    Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c,
    the problem is actually the other way around; request_mem_region should be
    used instead of request_region.

    The semantic patch that finds/fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r1@
    expression start;
    @@

    request_region(start,...)

    @b1@
    expression r1.start;
    @@

    request_mem_region(start,...)

    @depends on !b1@
    expression r1.start;
    expression E;
    @@

    - release_mem_region
    + release_region
    (start,E)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Ralf Baechle

    Julia Lawall
     

14 May, 2009

1 commit

07 Jan, 2009

1 commit

31 Jul, 2008

1 commit

  • 8d0b1c51e   gbefb: cmap FIFO timeout ... Browse Code »

    Writes to the cmap fifo while the display is blanked caused cmap FIFO
    timeout messages and a wrong colormap. To avoid this the driver now
    maintains a colormap in memory and updates the colormap after the display
    is unblanked.

    Signed-off-by: Thomas Bogendoerfer
    Cc: Krzysztof Helt
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Thomas Bogendoerfer
     

15 Nov, 2007

1 commit

  • 579d6d93c   gbefb: fix section mismatch warnings ... Browse Code »

    Make 'default_mode' and 'default_var' be __initdata.
    Fixes these section warnings:

    WARNING: vmlinux.o(.data+0x128e0): Section mismatch: reference to .init.data:default_mode_CRT (between 'default_mode' and 'default_var')
    WARNING: vmlinux.o(.data+0x128e4): Section mismatch: reference to .init.data:default_var_CRT (between 'default_var' and 'dev_attr_size')

    Signed-off-by: Randy Dunlap
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

18 Jul, 2007

1 commit

01 Jul, 2006

1 commit

25 Feb, 2006

1 commit

  • 68b06deb2   [PATCH] gbefb: IP32 gbefb depth change fix ... Browse Code »

    The gbefb driver does not update the framebuffer layers visual setting when
    depth is changed with fbset, resulting in strange colors (very dark blue in
    16-bit, almost black in 24-bit).

    Signed-off-by: Kaj-Michael Lang
    Signed-off-by: Martin Michlmayr
    Signed-off-by: Antonino Daplas
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kaj-Michael Lang
     

18 Feb, 2006

1 commit

  • d30864392   [PATCH] Fix SGI O2 compile error in drivers/video/gbefb.c ... Browse Code »

    A sysfs function call uses the wrong parameter, and thus breaks a build on
    SGI O2.

    CC drivers/video/gbefb.o
    drivers/video/gbefb.c: In function ‘gbefb_remove’:
    drivers/video/gbefb.c:1246: error: ‘dev’ undeclared (first use in this function)
    drivers/video/gbefb.c:1246: error: (Each undeclared identifier is reported only once
    drivers/video/gbefb.c:1246: error: for each function it appears in.)
    make[2]: *** [drivers/video/gbefb.o] Error 1

    Signed-off-by: Joshua Kinard
    Signed-off-by: Antonino Daplas
    Signed-off-by: Martin Michlmayr
    Signed-off-by: Linus Torvalds

    Joshua Kinard
     

15 Jan, 2006

1 commit

  • 216d526c8   [PATCH] fbdev: Sanitize ->fb_mmap prototype ... Browse Code »

    No need for a file argument. If we'd really need it it's in vma->vm_file
    already. gbefb and sgivwfb used to set vma->vm_file to the file argument, but
    the kernel alrady did that.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

10 Nov, 2005

1 commit

07 Nov, 2005

1 commit

  • c465e05a0   [PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon ... Browse Code »

    According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
    drivers that do not support hardware cursors is redundant. The soft_cursor
    function is usable by all drivers because it is just a wrapper around
    fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
    moved to the console directory.

    Thus, drivers that do not support hardware cursors can leave the fb_cursor
    field blank. For drivers that do, they can fill up this field with their own
    version.

    The end result is a smaller code size. And if the framebuffer console is not
    loaded, module/kernel size is also reduced because the soft_cursor module will
    also not be loaded.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

06 Nov, 2005

1 commit

  • abbf268ae   [DRIVER MODEL] Fix gbefb ... Browse Code »

    Statically allocated devices in module data is a potential cause
    of oopsen. The device may be in use by a userspace process, which
    will keep a reference to the device. If the module is unloaded,
    the module data will be freed. Subsequent use of the platform
    device will cause a kernel oops.

    Use generic platform device allocation/release code in modules.

    Signed-off-by: Russell King
    Acked-by: Greg Kroah-Hartman

    Russell King
     

31 Oct, 2005

1 commit

30 Oct, 2005

2 commits

21 Jun, 2005

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds