04 Dec, 2011

1 commit

  • This patch fixes the checkpatch errors listed below:

    ERROR: do not initialise statics to 0 or NULL
    WARNING: Use #include instead of
    WARNING: braces {} are not necessary for single statement blocks
    WARNING: braces {} are not necessary for any arm of this statement
    WARNING: static char array declaration should probably be static const char
    WARNING: line over 80 characters
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

    Signed-off-by: Jingoo Han
    Signed-off-by: Florian Tobias Schandinat

    Jingoo Han
     

03 Oct, 2011

1 commit

  • Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: David Brown
    Signed-off-by: Florian Tobias Schandinat

    Yong Zhang
     

13 Jul, 2011

1 commit


24 May, 2011

1 commit


12 Jan, 2011

1 commit

  • clk_get() returns a struct clk cookie to the driver and some platforms
    may return NULL if they only support a single clock. clk_get() has only
    failed if it returns a ERR_PTR() encoded pointer.

    Cc: Vincent Sanders
    Cc: linux-fbdev@vger.kernel.org
    Signed-off-by: Jamie Iles
    Signed-off-by: Paul Mundt

    Jamie Iles
     

25 May, 2010

1 commit

  • Since the drivers probe calls were changed from .init.text to
    .devinit.text in commit c2e13037e6794bd0d9de3f9ecabf5615f15c160b
    ("platform-drivers: move probe to .devinit.text in drivers/video") all the
    function from .init.text should be moved to .devinit.text, too.

    The drivers remove calls can also be move from .text to .devexit.text.

    Signed-off-by: Henrik Kretzschmar
    Cc: Vincent Sanders
    Acked-by: Arnaud Patard
    Tested-by: Arnaud Patard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Henrik Kretzschmar
     

08 Mar, 2010

1 commit

  • A pointer to a probe callback is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König
    Cc: Adrian Bunk
    Cc: Alberto Mardegan
    Cc: Andrew Morton
    Cc: Andriy Skulysh
    Cc: Antonino Daplas
    Cc: Anton Vorontsov
    Cc: Ben Dooks
    Cc: Chandramouli Narayanan
    Cc: Christoph Hellwig
    Cc: Frans Pop
    Cc: Geert Uytterhoeven
    Cc: Greg Kroah-Hartman
    Cc: Helge Deller
    Cc: Huang Ying
    Cc: Ian Molton
    Cc: Joshua Kinard
    Cc: Kaj-Michael Lang
    Cc: Krzysztof Helt
    Cc: linux-fbdev-devel@lists.sourceforge.net
    Cc: Maciej W. Rozycki
    Cc: Magnus Damm
    Cc: Martin Michlmayr
    Cc: Matthias Kaehlcke
    Cc: Paul Mundt
    Cc: Pavel Machek
    Cc: Philipp Zabel
    Cc: Richard Purdie
    Cc: Roel Kluin
    Cc: Roland Stigge
    Cc: Russell King
    Cc: Thomas Bogendoerfer
    Cc: Vincent Sanders
    Cc: Yoichi Yuasa
    Acked-by: Ralf Baechle
    Acked-by: Arnaud Patard
    Acked-by: James Simmons
    Acked-by: Peter Jones
    Acked-by: Jaya Kumar
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

23 Sep, 2009

1 commit

  • In the final part of the calculation for the tft display clockrate we
    divide the output pf s3c2410fb_calc_pixclk() by 2 which leaves us with a
    rounding error if the result is odd.

    Change to using DIV_ROUND_UP() to ensure that we always choose a higher
    divisor and thus a lower frequency.

    Signed-off-by: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     

21 Sep, 2009

1 commit


17 Jun, 2009

1 commit


19 Feb, 2009

1 commit


07 Aug, 2008

1 commit


25 May, 2008

4 commits

  • Add a correct MODULE_ALIAS() entry for this driver to enable udev module
    loading.

    Signed-off-by: Ben Dooks
    Cc: Arnaud Patard
    Acked-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     
  • Remove the old changelog entries which are now out of date and should be
    extractable from git anyway. Also tidy up the copyright for the driver.

    Signed-off-by: Ben Dooks
    Cc: Arnaud Patard
    Acked-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     
  • Fix the following warning by checking the result of device_create_file and
    printing an error but not removing the device (loss of debug registers is
    not fatal).

    drivers/video/s3c2410fb.c:905: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result

    Signed-off-by: Ben Dooks
    Cc: Arnaud Patard
    Acked-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     
  • When a blank level of FB_BLANK_POWERDOWN is used, we should shut down the
    controller so that it no longer tries to produce any panel signals or
    data, and shuts down the DMA which is not needed.

    Signed-off-by: Ben Dooks
    Cc: Arnaud Patard
    Acked-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     

28 Apr, 2008

1 commit

  • __FUNCTION__ is gcc-specific, use __func__

    Signed-off-by: Harvey Harrison
    Cc: "Antonino A. Daplas"
    Cc: Krzysztof Helt
    Cc: Antonino Daplas
    Cc: Antonino A. Daplas
    Cc: Antonino Daplas
    Cc: Richard Purdie
    Cc: Jean Delvare
    Cc: Adrian Bunk
    Cc: Russell King
    Cc: Benjamin Herrenschmidt
    Cc: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     

07 Feb, 2008

4 commits


22 Jan, 2008

1 commit

  • Fix line length calculation. var->width is the size of the display in mm. We
    like to use the pixel size.

    Without this fix, dynamic (fbset) based resolution and depths changes with
    s3c2410_fb don't work at all.

    Spotted by john cass

    Signed-off-by: Stefan Schmidt
    Signed-off-by: Harald Welte
    Acked-by: Ben Dooks
    Acked-by: Arnaud Patard
    Acked-by: Krzysztof Helt
    Cc: "Antonino A. Daplas"
    Cc: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stefan Schmidt
     

15 Jan, 2008

1 commit


20 Oct, 2007

1 commit

  • * Convert files to UTF-8.

    * Also correct some people's names
    (one example is Eißfeldt, which was found in a source file.
    Given that the author used an ß at all in a source file
    indicates that the real name has in fact a 'ß' and not an 'ss',
    which is commonly used as a substitute for 'ß' when limited to
    7bit.)

    * Correct town names (Goettingen -> Göttingen)

    * Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313)

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Adrian Bunk

    Jan Engelhardt
     

17 Oct, 2007

14 commits

  • This patch changes mode selection to always prefer default mode if possible
    and always honor type of display set by default mode settings.

    This patch is required in case the same display modes were defined for
    different panels (e.g. STN and TFT).

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch removes lcdcon1 register field from the s3c2410fb_display as all
    bits are calculated from other fields.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch adds pixelclock field to the s3c2410fb_display structure and make
    use of it in the driver.

    The Bast machine defined 9 modes but pixclock and margin values are defined
    only for the 640x480 modes so I removed other modes.

    This patch also fixes wrong display type constant for the SMDK2440 board.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch:
    - moves more display mode preparations to s3c2410fb_check_var()
    - reduces number of fields in s3c2410fb_info
    - removes redundant values setting in s3c2410fb_probe()
    - removes static mach_info pointer
    - releases fb_info structure in s3c2410fb_remove()
    - changes s3c2410fb_init to __init from __devinit
    - fixes few typos in comments and removes unused includes

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch sets correct bits related to the byte ordering of the
    framebuffer. This was tested on little endian kernel only. The big endian
    kernel may require different settings.

    The patch also adds 32 bpp mode which is called 24 bpp by Samsung. One
    pixel takes 32 bits but only 24 bits are used in this mode.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch adds missing virtual register offsets where
    appropriate. This fixes crashes in the driver.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch removes unused lcdcon2 and lcdcon3 register value
    from the s3c2410fb_display structure.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch adds synchronization pulse lenght fields to
    the s3c2410fb_display structure and makes use of them
    in the driver.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch makes use of vertical margins fields in
    the s3c2410fb_display structure.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch removes unused lcdcon3 register from the
    s3c2410fb_display structure.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch makes use of margins fields in the s3c2410fb_display
    structure.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch adds a new structure to describe and handle
    more than one panel (display mode) for the s3c2410 framebuffer.
    This structure is added after the pxafb driver.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch removes redundant fb field from
    the s3c2410fb_info structure. This breaks circular
    reference fb_info -> s3c2410fb_info -> fb_info again.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • This patch cleans up the driver a bit. It contains
    coding style fixes (pointed by Lindent and checkpatch),
    white space clean ups and few minor code improvements.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     

01 Aug, 2007

1 commit

  • The implicit mapping has been removed from the arch
    as this should be handled in the driver, this patch
    fixes the s3c2410_fb driver to ioremap() the necessary
    registers.

    Signed-off-by: Ben Dooks
    Acked-by: Arnaud Patard
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     

17 Feb, 2007

1 commit