25 Nov, 2009

4 commits


20 Sep, 2009

2 commits


08 Apr, 2009

1 commit


31 Aug, 2008

1 commit


12 Aug, 2008

1 commit


21 Jul, 2008

2 commits

  • Today's linux-next build (sparc64 defconfig) failed like this:

    drivers/serial/sunhv.c: In function `receive_chars':
    drivers/serial/sunhv.c:188: error: structure has no member named `tty'
    drivers/serial/sunsu.c: In function `receive_chars':
    drivers/serial/sunsu.c:314: error: structure has no member named `tty'
    drivers/serial/sunsab.c: In function `receive_chars':
    drivers/serial/sunsab.c:121: error: structure has no member named `tty'

    I applied the following patch (which, again, may not be correct).

    Signed-off-by: Stephen Rothwell
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Stephen Rothwell
     
  • This patch removes CVS keywords that weren't updated for a long time in
    comments, printk's and MODULE_DESCRIPTION's (no printk's or
    MODULE_DESCRIPTION's are completely removed).

    While doing this I also found and fixed a missing \n in a printk
    in m32r_sio.c

    Signed-off-by: Adrian Bunk
    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     

02 May, 2008

1 commit

  • They were all "serial" so if multiple of these drivers registered,
    we'd trigger sysfs directory creation errors:

    [ 1.695793] proc_dir_entry 'serial' already registered
    [ 1.695839] Call Trace:
    [ 1.831891] [00000000004f2534] create_proc_entry+0x7c/0x98
    [ 1.833608] [00000000004f3a58] proc_tty_register_driver+0x40/0x70
    [ 1.833663] [0000000000594700] tty_register_driver+0x1fc/0x208
    [ 1.835371] [00000000005aade4] uart_register_driver+0x134/0x16c
    [ 1.841762] [00000000005ac274] sunserial_register_minors+0x34/0x68
    [ 1.841818] [00000000007db2a4] sunsu_init+0xf8/0x150
    [ 1.867697] [00000000007c62a4] kernel_init+0x190/0x330
    [ 1.939147] [0000000000426cf8] kernel_thread+0x38/0x48
    [ 1.939198] [00000000006a0d90] rest_init+0x18/0x5c

    Signed-off-by: David S. Miller

    David S. Miller
     

12 Dec, 2007

1 commit

  • This patch against 2.6.23 sparc-2.6.git contains a number of minor
    cleanups of the sparc serial drivers. Initially I fixed this build
    warning:

    WARNING: vmlinux.o(.text+0x107a2c): Section mismatch: reference to .init.text:add_preferred_console (between 'sunserial_console_match' and 'sunserial_console_termios')

    which is done by declaring sunserial_console_match() as __init. This
    resulted in build warnings on sunserial_current_minor. To resolve
    these the variable was changed so it is no longer global, and to hide
    operations on it inside 2 new functions. These functions handle the
    UART minor handling code that is common to all sparc serial drivers.

    These changes allowed to clean up the uart counters in all the sparc
    serial drivers, and the administration of minor device numbers.

    Lastly, sunserial_console_termios() does not need to be exported since
    it is only called from non-modular code.

    Sadly, the following build warning still exists:

    WARNING: vmlinux.o(__ksymtab+0x2910): Section mismatch: reference to .init.text:sunserial_console_match (between '__ksymtab_sunserial_console_match' and '__ksymtab_sunserial_unregister_minors')

    This could be resolved by not exporting sunserial_console_match(), but
    this is not possible at the moment because it is being called from
    modular code. On the other hand, this is a bogus warning since it
    comes from a ksymtab section.

    Signed-off-by: Martin Habets
    Signed-off-by: David S. Miller

    Martin Habets
     

27 Aug, 2007

1 commit


21 Jul, 2007

1 commit

  • The current scheme works on static interpretation of text names, which
    is wrong.

    The output-device setting, for example, must be resolved via an alias
    or similar to a full path name to the console device.

    Paths also contain an optional set of 'options', which starts with a
    colon at the end of the path. The option area is used to specify
    which of two serial ports ('a' or 'b') the path refers to when a
    device node drives multiple ports. 'a' is assumed if the option
    specification is missing.

    This was caught by the UltraSPARC-T1 simulator. The 'output-device'
    property was set to 'ttya' and we didn't pick upon the fact that this
    is an OBP alias set to '/virtual-devices/console'. Instead we saw it
    as the first serial console device, instead of the hypervisor console.

    The infrastructure is now there to take advantage of this to resolve
    the console correctly even in multi-head situations in fbcon too.

    Thanks to Greg Onufer for the bug report.

    Signed-off-by: David S. Miller

    David S. Miller
     

16 Jul, 2007

1 commit


07 May, 2007

1 commit


26 Apr, 2007

1 commit


15 Feb, 2007

1 commit

  • After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

01 Jan, 2007

1 commit


09 Dec, 2006

1 commit

  • This is the grungy swap all the occurrences in the right places patch that
    goes with the updates. At this point we have the same functionality as
    before (except that sgttyb() returns speeds not zero) and are ready to
    begin turning new stuff on providing nobody reports lots of bugs

    If you are a tty driver author converting an out of tree driver the only
    impact should be termios->ktermios name changes for the speed/property
    setting functions from your upper layers.

    If you are implementing your own TCGETS function before then your driver
    was broken already and its about to get a whole lot more painful for you so
    please fix it 8)

    Also fill in c_ispeed/ospeed on init for most devices, although the current
    code will do this for you anyway but I'd like eventually to lose that extra
    paranoia

    [akpm@osdl.org: bluetooth fix]
    [mp3@de.ibm.com: sclp fix]
    [mp3@de.ibm.com: warning fix for tty3270]
    [hugh@veritas.com: fix tty_ioctl powerpc build]
    [jdike@addtoit.com: uml: fix ->set_termios declaration]
    Signed-off-by: Alan Cox
    Signed-off-by: Martin Peschke
    Acked-by: Peter Oberparleiter
    Cc: Cornelia Huck
    Signed-off-by: Hugh Dickins
    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

01 Oct, 2006

1 commit


15 Jul, 2006

1 commit


13 Jul, 2006

1 commit

  • The sunsu_ports[] array exists merely to be able to easily
    use an integer index to get at the proper serial console
    port struct.

    We size this only for real ports, not for the keyboard and
    mouse, and thus keyboard and mouse port registration would
    fail.

    Fix this by dynamically allocating the port struct for the
    keyboard and mouse, instead of using the sunsu_ports[]
    array.

    Signed-off-by: David S. Miller

    David S. Miller
     

03 Jul, 2006

1 commit


01 Jul, 2006

3 commits


30 Jun, 2006

2 commits


27 Jun, 2006

1 commit


24 Jun, 2006

1 commit


20 Jun, 2006

1 commit

  • This ugly hack was long overdue to die.

    It was a way to print out Sparc interrupts in a more freindly format,
    since IRQ numbers were arbitrary opaque 32-bit integers which vectored
    into PIL levels. These 32-bit integers were not necessarily in the
    0-->NR_IRQS range, but the PILs they vectored to were.

    The idea now is that we will increase NR_IRQS a little bit and use a
    virtualreal IRQ number mapping scheme similar to PowerPC.

    That makes this IRQ printing hack irrelevant, and furthermore only a
    handful of drivers actually used __irq_itoa() making it even less
    useful.

    Signed-off-by: David S. Miller

    David S. Miller
     

22 May, 2006

1 commit


29 Mar, 2006

1 commit


23 Mar, 2006

2 commits


21 Mar, 2006

1 commit

  • Glen Turner reported that writing LFCR rather than the more
    traditional CRLF causes issues with some terminals.

    Since this aflicts many serial drivers, extract the common code
    to a library function (uart_console_write) and arrange for each
    driver to supply a "putchar" function.

    Signed-off-by: Russell King

    Russell King
     

20 Mar, 2006

1 commit