24 Oct, 2015
5 commits
-
Upon registering a FPGA Manager low level driver, FPGA Manager
core overwrites the platform drvdata pointer. Prior to this commit
zynq-fpga falsely relied on this pointer to still be valid at remove()
time.Reported-by: Alan Tull
Signed-off-by: Moritz Fischer
Acked-by: Alan Tull
Signed-off-by: Greg Kroah-Hartman -
Remove unnecessary null pointer checks. We want the caller of
these functions to do their own pointer checks. Add some
comments to document this.Signed-off-by: Alan Tull
Reviewed-by: Moritz Fischer
Signed-off-by: Greg Kroah-Hartman -
Ensure device and driver lifetime from of_fpga_mgr_get() to
fpga_mgr_put().* Don't put_device() in of_fpga_mgr_get, do it in fpga_mgr_put().
(still do put_device if there is an error).
* Do module_get on the low level driver.
* Don't need to module_get(THIS_MODULE) since we won't be allowed
to unload the fpga manager core without unloading low level
driver first.
* Remove unnedessary null check for node pointer.Signed-off-by: Alan Tull
Signed-off-by: Greg Kroah-Hartman -
This gets rid of the code to strip away the header and byteswap,
as well as the check for the sync word.Signed-off-by: Moritz Fischer
Reviewed-by: Josh Cartwright
Acked-by: Michal Simek
Signed-off-by: Greg Kroah-Hartman -
This commit fixes the unbalanced clock handling, where
a failed probe would leave the clock with an enable count of -1.Reported-by: Josh Cartwright
Signed-off-by: Moritz Fischer
Signed-off-by: Greg Kroah-Hartman
19 Oct, 2015
1 commit
-
The change fixes a warning found by sparse:
drivers/misc/sram.c:134:20: warning: incorrect type in assignment (different address spaces)
drivers/misc/sram.c:134:20: expected void *base
drivers/misc/sram.c:134:20: got void [noderef] *Signed-off-by: Vladimir Zapolskiy
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2015
34 commits
-
Supplementing ABI documentation with a description of the newly
added interface.Signed-off-by: Mathieu Poirier
Signed-off-by: Greg Kroah-Hartman -
Fixes an off by one array size.
Signed-off-by: Dmitry Kalinkin
Signed-off-by: Greg Kroah-Hartman -
This commit adds FPGA Manager support for the Xilinx Zynq chip.
The code borrows some from the xdevcfg driver in Xilinx'
vendor tree.Signed-off-by: Moritz Fischer
Signed-off-by: Greg Kroah-Hartman -
Added addtional nodes required for FPGA Manager operation
of the Xilinx Zynq Devc configuration interface.Reviewed-by: Sören Brinkmann
Signed-off-by: Moritz Fischer
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Moritz Fischer
Signed-off-by: Greg Kroah-Hartman -
This patch is more of a personal preference, rather than a fix for a problem.
The current implementation used a combination of both 'cat' and 'sed'
to generate an unsorted list of kernel modules separated by while space.The proposed implementation uses 'sort' and 'sed' to generate a sort
list of kernel modules separated by while space.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Tested on:
Gentoo LinuxSigned-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
'udevinfo' no longer seems to be available across various
distros. 'udevadm' seems to be the currently valid way to look up the
'udev' version.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
'loadkeys -h' no longer prints the version number across all distros,
despite the claim to do so in the manpage, which I found to be the case
on a Debian Linux system.The proposed implementation utilises the output of 'loadkeys -V' to
acquire the version of both 'Kbd' and 'Console-tools'.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Neither 'libg++.so', nor 'libstdc++.so' were found where the current
implementation expects them to be found in the distros below.Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Which results in zero ouput generated.
The proposed implementation relies on 'ldconfig' to locate the libraries
in question. 'Sed' is used to do the text processing.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'head' + 'awk'.The '-v' flag either seems to have been deprecated in some distros, e.g. Gentoo, or is an alias for '--version' in others. The proposed implementation uses the latter flag only.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
The current implementation has been found not to work across all distros.
The proposed implementation relies on 'sed' to both output the string
'Linux C Library' as well as to open '/proc/self/maps' without having
to use output redirection.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Tested on:
Oracle LinuxSigned-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'awk'.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'sed' + 'awk'.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Proposed implementation also eliminates the necessity to invoke 'grep' + 'sed' + 'awk'.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than rely on numerical input to be found in a particular input field.
Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
The current implementation relies on 'fdformat' to output the version of
'util-linux'. This does not seem to be reliable any longer, as 'fdformat'
does not seem to come preinstalled in all ditros these days.The proposed implementation uses 'mount' to output both the version
of 'util-linux' and 'mount' proper, as 'mount' is also a part of the
'util-linux' package.Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Rely on regex to find the version number, rather than a field number.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Current implementation output on Gentoo Linux:
binutils 2.25.1
1.1
2.25.1Proposed implementation:
Binutils 2.25.1Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1Rely on regex to find the version number.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than a field number.
Reduce the number of 'awk' invocations from two to one.Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
Rely on regex to find the version number, rather than a field number.
Signed-off-by: Alexander Kapshuk
Signed-off-by: Greg Kroah-Hartman -
This change adds functionality to operate on reserved SRAM partitions
described in device tree file. Two partition properties are added,
"pool" and "export", the first one allows to share a specific partition
for usage by a kernel consumer in the same manner as it is done for
the whole SRAM device, and "export" property provides access to some
SRAM area from userspace over sysfs interface. Practically it is
possible to specify both properties for an SRAM partition, however
simultaneous access from a kernel consumer and from userspace is not
serialized, but still the combination may be useful for debugging
purpose.The change opens the following scenarios of SRAM usage:
* updates in a particular SRAM area specified by offset and size are
done by bootloader, then this information is utilized by the kernel,
* a particular SRAM area is rw accessed from userspace, the stored
data is persistent on soft reboots,
* a device driver secures SRAM area for its purposes,
* etc.Note, strictly speaking the added optional properties describe policy
of SRAM usage, rather than hardware, but here the policy mostly
resembles flash partitions in devicetree, which is undoubtedly
a very popular option but it does not describe hardware.Signed-off-by: Vladimir Zapolskiy
Signed-off-by: Greg Kroah-Hartman -
Add entry for MIC drivers to the MAINTAINERS file
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
Signed-off-by: Greg Kroah-Hartman -
We should be returning -ENOMEM here instead of success.
Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter
Reviewed-by: Sudeep Dutt
Signed-off-by: Greg Kroah-Hartman -
The caller expects that we take this lock again before returning
otherwise it you get double unlocks and races.Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter
Reviewed-by: Sudeep Dutt
Signed-off-by: Greg Kroah-Hartman -
Spotted by coccicheck:
drivers/misc/mei/amthif.c:479:5-26: WARNING: Comparison of bool to 0/1Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
s/send/receive/
The buffer in the receive function is
not used for sendingSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
KDoc function section start with double start: /** instead of /*
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
