Eric Lee / smarc-fsl-linux-kernel

09 Nov, 2013

4 commits

29 Nov, 2012

1 commit

20 Oct, 2012

1 commit

  • 1d46e232f   linux/coredump.h needs asm/siginfo.h ... Browse Code »

    Commit 5ab1c309b344 ("coredump: pass siginfo_t* to do_coredump() and
    below, not merely signr") added siginfo_t to linux/coredump.h but forgot
    to include asm/siginfo.h. This breaks the build for UML/i386. (And any
    other arch where asm/siginfo.h is not magically preincluded...)

    In file included from arch/x86/um/elfcore.c:2:0: include/linux/coredump.h:15:25: error: unknown type name 'siginfo_t'
    make[1]: *** [arch/x86/um/elfcore.o] Error 1

    Signed-off-by: Richard Weinberger
    Cc: Denys Vlasenko
    Cc: Oleg Nesterov
    Cc: Amerigo Wang
    Cc: "Jonathan M. Foote"
    Cc: Roland McGrath
    Cc: Pedro Alves
    Cc: Fengguang Wu
    Cc: Stephen Rothwell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Richard Weinberger
     

06 Oct, 2012

2 commits

  • 5ab1c309b   coredump: pass siginfo_t* to do_coredump() and below, not merely signr ... Browse Code »

    This is a preparatory patch for the introduction of NT_SIGINFO elf note.

    With this patch we pass "siginfo_t *siginfo" instead of "int signr" to
    do_coredump() and put it into coredump_params. It will be used by the
    next patch. Most changes are simple s/signr/siginfo->si_signo/.

    Signed-off-by: Denys Vlasenko
    Reviewed-by: Oleg Nesterov
    Cc: Amerigo Wang
    Cc: "Jonathan M. Foote"
    Cc: Roland McGrath
    Cc: Pedro Alves
    Cc: Fengguang Wu
    Cc: Stephen Rothwell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Denys Vlasenko
     
  • 179899fd5   coredump: update coredump-related headers ... Browse Code »

    Create a new header file, fs/coredump.h, which contains functions only
    used by the new coredump.c. It also moves do_coredump to the
    include/linux/coredump.h header file, for consistency.

    Signed-off-by: Alex Kelly
    Reviewed-by: Josh Triplett
    Acked-by: Serge Hallyn
    Acked-by: Kees Cook
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alex Kelly
     

15 Oct, 2010

2 commits

  • 3aa0ce825   Un-inline the core-dump helper functions ... Browse Code »

    Tony Luck reports that the addition of the access_ok() check in commit
    0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
    ia64 compile due to missing the necessary header file includes.

    Rather than add yet another include () to make everything
    happy, just uninline the silly core dump helper functions and move the
    bodies to fs/exec.c where they make a lot more sense.

    dump_seek() in particular was too big to be an inline function anyway,
    and none of them are in any way performance-critical. And we really
    don't need to mess up our include file headers more than they already
    are.

    Reported-and-tested-by: Tony Luck
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • 0eead9ab4   Don't dump task struct in a.out core-dumps ... Browse Code »

    akiphie points out that a.out core-dumps have that odd task struct
    dumping that was never used and was never really a good idea (it goes
    back into the mists of history, probably the original core-dumping
    code). Just remove it.

    Also do the access_ok() check on dump_write(). It probably doesn't
    matter (since normal filesystems all seem to do it anyway), but he
    points out that it's normally done by the VFS layer, so ...

    [ I suspect that we should possibly do "vfs_write()" instead of
    calling ->write directly. That also does the whole fsnotify and write
    statistics thing, which may or may not be a good idea. ]

    And just to be anal, do this all for the x86-64 32-bit a.out emulation
    code too, even though it's not enabled (and won't currently even
    compile)

    Reported-by: akiphie
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

13 Mar, 2010

1 commit

  • 6e3e37a5a   coredump: plug a memory leak situation on dump_seek() ... Browse Code »

    After having started writing the coredump, if filesystem reports an error
    anytime while writing part of the core file, we would leak a memory page
    when bailing out.

    Signed-off-by: André Goddard Rosa
    Acked-by: KOSAKI Motohiro
    Cc: Alexander Viro
    Cc: Roland McGrath
    Cc: WANG Cong
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    André Goddard Rosa
     

07 Mar, 2010

1 commit

  • 088e7af73   coredump: move dump_write() and dump_seek() into a header file ... Browse Code »

    My next patch will replace ELF_CORE_EXTRA_* macros by functions, putting
    them into other newly created *.c files. Then, each files will contain
    dump_write(), where each pair of binfmt_*.c and elfcore.c should be the
    same. So, this patch moves them into a header file with dump_seek().
    Also, the patch deletes confusing DUMP_WRITE macros in each files.

    Signed-off-by: Daisuke HATAYAMA
    Cc: "Luck, Tony"
    Cc: Jeff Dike
    Cc: David Howells
    Cc: Greg Ungerer
    Cc: Roland McGrath
    Cc: Oleg Nesterov
    Cc: Ingo Molnar
    Cc: Alexander Viro
    Cc: Andi Kleen
    Cc: Alan Cox
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Daisuke HATAYAMA