07 Feb, 2007

2 commits


05 Feb, 2007

2 commits


04 Feb, 2007

9 commits

  • That code doesn't do what its author apparently thought it would do...

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     
  • * master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6:
    [SCSI] sd: udev accessing an uninitialized scsi_disk field results in a crash
    [SCSI] st: A MTIOCTOP/MTWEOF within the early warning will cause the file number to be incorrect
    [SCSI] qla4xxx: bug fixes
    [SCSI] Fix scsi_add_device() for async scanning

    Linus Torvalds
     
  • x86-64 is missing these:

    Signed-off-by: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Garzik
     
  • The SN Altix platform does not conform to the IOSAPIC IRQ routing model.
    Add code in acpi_unregister_gsi() to check if (acpi_irq_model ==
    ACPI_IRQ_MODEL_PLATFORM) and return.

    Due to an oversight, this code was not added previously when
    similar code was added to acpi_register_gsi().

    http://marc.theaimsgroup.com/?l=linux-acpi&m=116680983430121&w=2

    Signed-off-by: John Keller
    Acked-by: Len Brown
    Cc: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    John Keller
     
  • Andrew Vasquez is reporting as-iosched oopses and a 65% throughput
    slowdown due to the recent special-casing of direct-io against
    blockdevs. We don't know why either of these things are occurring.

    The patch minimally reverts us back to the 2.6.19 code for a 2.6.20
    release.

    Cc: Andrew Vasquez
    Cc: Ken Chen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • We went and named them __NR_sys_foo instead of __NR_foo.

    It may be too late to change this, but we can at least add the proper names
    now.

    Signed-off-by: Mike Frysinger
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mike Frysinger
     
  • smc911x_phy_configure's error handling unconditionally unlocks the
    spinlock even if it wasn't locked. Patch fixes it.

    Signed-off-by: Peter Korsgaard
    Cc: Jeff Garzik
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Korsgaard
     
  • This patch fixes up ia64 kexec support for HP rx2620 hardware. It does
    this by skipping migration of already disabled irqs. This is most likely a
    problem on other ia64 platforms as well, but I've only been able to
    reproduce it on one machine so far.

    The full story is that handle_bad_irq() gets invoked before starting the
    new kernel without this patch. This seems to happen when fixup_irqs()
    calls generic_handle_irq() on already migrated (and disabled) irqs. So by
    avoiding migration of disabled irqs we stay away of handle_bad_irq().

    The code has been tested on three different ia64 machines, all with good
    results. It is possible to trigger the same bug by offlining a processor
    using echo 0 > /sys/devices/system/cpu/cpuX/online.

    More detailed information is available in the following mail thread:
    http://lists.osdl.org/pipermail/fastboot/2007-January/thread.html#5774

    Signed-off-by: Magnus Damm
    Acked-by: Simon Horman
    Acked-by: Zou, Nanhai
    Acked-by: Jay Lan
    Acked-by: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Magnus Damm
     
  • An AIO bug was reported that sleeping function is being called in softirq
    context:

    BUG: warning at kernel/mutex.c:132/__mutex_lock_common()
    Call Trace:
    [] __mutex_lock_slowpath+0x640/0x6c0
    [] mutex_lock+0x20/0x40
    [] flush_workqueue+0xb0/0x1a0
    [] __put_ioctx+0xc0/0x240
    [] aio_complete+0x2f0/0x420
    [] finished_one_bio+0x200/0x2a0
    [] dio_bio_complete+0x1c0/0x200
    [] dio_bio_end_aio+0x60/0x80
    [] bio_endio+0x110/0x1c0
    [] __end_that_request_first+0x180/0xba0
    [] end_that_request_chunk+0x30/0x60
    [] scsi_end_request+0x50/0x300 [scsi_mod]
    [] scsi_io_completion+0x200/0x8a0 [scsi_mod]
    [] sd_rw_intr+0x330/0x860 [sd_mod]
    [] scsi_finish_command+0x100/0x1c0 [scsi_mod]
    [] scsi_softirq_done+0x230/0x300 [scsi_mod]
    [] blk_done_softirq+0x160/0x1c0
    [] __do_softirq+0x200/0x240
    [] do_softirq+0x70/0xc0

    See report: http://marc.theaimsgroup.com/?l=linux-kernel&m=116599593200888&w=2

    flush_workqueue() is not allowed to be called in the softirq context.
    However, aio_complete() called from I/O interrupt can potentially call
    put_ioctx with last ref count on ioctx and triggers bug. It is simply
    incorrect to perform ioctx freeing from aio_complete.

    The bug is trigger-able from a race between io_destroy() and aio_complete().
    A possible scenario:

    cpu0 cpu1
    io_destroy aio_complete
    wait_for_all_aios { __aio_put_req
    ... ctx->reqs_active--;
    if (!ctx->reqs_active)
    return;
    }
    ...
    put_ioctx(ioctx)

    put_ioctx(ctx);
    __put_ioctx
    bam! Bug trigger!

    The real problem is that the condition check of ctx->reqs_active in
    wait_for_all_aios() is incorrect that access to reqs_active is not
    being properly protected by spin lock.

    This patch adds that protective spin lock, and at the same time removes
    all duplicate ref counting for each kiocb as reqs_active is already used
    as a ref count for each active ioctx. This also ensures that buggy call
    to flush_workqueue() in softirq context is eliminated.

    Signed-off-by: "Ken Chen"
    Cc: Zach Brown
    Cc: Suparna Bhattacharya
    Cc: Benjamin LaHaise
    Cc: Badari Pulavarty
    Cc:
    Acked-by: Jeff Moyer
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ken Chen
     

03 Feb, 2007

15 commits


02 Feb, 2007

12 commits

  • We forget to call spider_net_free_rx_chain_contents which does the
    actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache
    on each "ifconfig up" letting the cache grow infinitely.

    This patch fixes it.

    Signed-off-by: Jens Osterkamp
    Signed-off-by: Jeff Garzik

    Jens Osterkamp
     
  • e100: fix napi ifdefs removing needed code

    From: Auke Kok

    The e100 driver is NAPI mode only. We need to netif_poll_disable
    during suspend and shutdown. The non-NAPI driver code was removed
    and is only avaiable in the out-of-tree e100 kernel driver.

    Signed-off-by: Auke Kok
    Signed-off-by: Jeff Garzik

    Auke Kok
     
  • Jeff Garzik
     
  • 5709 A0 copper devices will not link up with some link partners
    without this workaround.

    Update driver to 1.5.5.

    Signed-off-by: Michael Chan
    Signed-off-by: David S. Miller

    Michael Chan
     
  • The x_tables patch broke target module autoloading in the ipt action
    by replacing the ipt_find_target call (which does autoloading) by
    xt_find_target (which doesn't do autoloading). Additionally xt_find_target
    may return ERR_PTR values in case of an error, which are not handled.

    Use xt_request_find_target, which does both autoloading and ERR_PTR
    handling properly. Also don't forget to drop the target module reference
    again when xt_check_target fails.

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • In some cases such as:
    iph->check = 0;
    iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
    GCC may optimize out the previous store.

    Observed as a failure of NFS over udp (bad checksums on ip fragments)
    when compiled with GCC 3.4.2.

    Signed-off-by: Bob Breuer
    Signed-off-by: David S. Miller

    Bob Breuer
     
  • avr32@atmel.com is a technical support address and is not really
    appropriate for sending patches. Lots of annoying automatics getting
    in the way.

    I'm still the maintainer of all the entries touched by this patch, so
    nothing changes with regard to the "Supported" status of the AVR32
    architecture or the macb driver.

    Signed-off-by: Haavard Skinnemoen
    Signed-off-by: Linus Torvalds

    Haavard Skinnemoen
     
  • Noticed by JosephChan@via.com.tw.

    Signed-off-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: Linus Torvalds

    Bartlomiej Zolnierkiewicz
     
  • Change SysRq showBlockedTasks from sysrq-X to sysrq-W and show that in the
    Help message.

    It was previously done via X, but X is already used for Xmon on ppc & powerpc
    platforms and this collision needs to be avoided.

    All callers of register_sysrq_key() are now marked in the sysrq op/key table.
    I didn't mark 'h' as Help because Help is just printed for any unknown key,
    such as '?'.

    Added some omitted sysrq key entries in the sysrq.txt file.

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • Listing /proc/PID/task were PID is not a TGID should not result in
    duplicated entries.

    [g ~]$ pidof thunderbird-bin
    2751
    [g ~]$ ls /proc/2751/task
    2751 2770 2771 2824 2826 2834 2835 2851 2853
    [g ~]$ ls /proc/2770/task
    2751 2770 2771 2824 2826 2834 2835 2851 2853
    2770 2771 2824 2826 2834 2835 2851 2853
    [g ~]$

    Signed-off-by: Guillaume Chazarain
    Acked-by: "Eric W. Biederman"
    Cc: Oleg Nesterov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Guillaume Chazarain
     
  • Intel hosts, without long mode, and with nx support disabled in the bios
    have an efer that is readable but not writable. This causes a lockup on
    switch to guest mode (even though it should exit with reason 34 according
    to the documentation).

    Signed-off-by: Avi Kivity
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Avi Kivity
     
  • Remove these recently-added warnings. They don't tell us anythng very
    interesting and Kumar says "On an embedded PPC reference system I see this
    message 6 times when I've got no cards in the PCI slots."

    Acked-by: Kumar Gala
    Acked-by: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton