21 Sep, 2011

1 commit

  • The dw_{read,write}[lw] macros produce sparse warnings everytime they
    are used. The "read" ones cause:

    warning: cast removes address space of expression
    warning: incorrect type in argument 1 (different address spaces)
    expected void const volatile [noderef] *addr
    got unsigned int *

    And the "write" ones:

    warning: cast removes address space of expression
    warning: incorrect type in argument 2 (different address spaces)
    expected void volatile [noderef] *addr
    got unsigned int *

    Fix this by removing struct dw_spi_reg and converting all the register
    offsets to #defines. Then convert the macros into inlined functions so
    that proper type checking can occur.

    While here, also fix the three sparse warnings in spi-dw-mid.c due to
    the return value of ioremap_nocache being stored in a u32 * not a
    void __iomem *.

    With these changes the spi-dw* files all build with no sparse warnings.

    Signed-off-by: H Hartley Sweeten
    Acked-by: Feng Tang
    Signed-off-by: Grant Likely

    H Hartley Sweeten
     

09 Jul, 2011

1 commit


06 Jun, 2011

1 commit

  • Sort the SPI makefile and enforce the naming convention spi_*.c for
    spi drivers.

    This change also rolls the contents of atmel_spi.h into the .c file
    since there is only one user of that particular include file.

    v2: - Use 'spi-' prefix instead of 'spi_' to match what seems to be
    be the predominant pattern for subsystem prefixes.
    - Clean up filenames in Kconfig and header comment blocks

    Signed-off-by: Grant Likely
    Acked-by: Wolfram Sang
    Acked-by: Linus Walleij

    Grant Likely