01 Dec, 2011

1 commit

  • Since commit a4a710c4a7490587 (pkt_sched: Change PSCHED_SHIFT from 10 to
    6) it seems RED/GRED are broken.

    red_calc_qavg_from_idle_time() computes a delay in us units, but this
    delay is now 16 times bigger than real delay, so the final qavg result
    smaller than expected.

    Use standard kernel time services since there is no need to obfuscate
    them.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

13 Jan, 2011

1 commit


04 Nov, 2009

1 commit

  • This cleanup patch puts struct/union/enum opening braces,
    in first line to ease grep games.

    struct something
    {

    becomes :

    struct something {

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

26 Apr, 2007

3 commits


05 Aug, 2006

1 commit

  • Overflow can occur very easily with 32 bits, e.g., with 1 second
    us_idle is approx. 2^20, which leaves only 11-Wlog bits for queue
    length. Since the EWMA exponent is typically around 9, queue
    lengths larger than 2^2 cause overflow. Whether the affected
    branch is taken when us_idle is as high as 1 second, depends on
    Scell_log, but with rather reasonable configuration Scell_log is
    large enough to cause p->Stab to have zero index, which always
    results zero shift (typically also few other small indices result
    in zero shift).

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     

26 Apr, 2006

1 commit


06 Nov, 2005

1 commit

  • Extracts the RED algorithm from sch_red.c and puts it into include/net/red.h
    for use by other RED based modules. The statistics are extended to be more
    fine grained in order to differ between probability/forced marks/drops.
    We now reset the average queue length when setting new parameters, leaving
    it might result in an unreasonable qavg for a while depending on the value of W.

    Signed-off-by: Thomas Graf
    Signed-off-by: Arnaldo Carvalho de Melo

    Thomas Graf