30 Aug, 2011
1 commit
-
Some variables were being set but never used, which was triggering
warnings in GCC >= 4.6.Signed-off-by: Lucas De Marchi
Signed-off-by: Arnaud Lacombe
20 Sep, 2010
1 commit
-
In 60f33b8 (kconfig: get rid of stray a.o, support ncursesw, 2006-01-15),
support to link menuconfig with ncursesw library was added. To compute
the linker command option -l, we check "libncursesw.{so,a,dylib}" to allow
ncursesw to be used as a replacement ncurses. However, when checking what
header file to include, we do not check /usr/include/ncursesw directory.Add /usr/include/ncursesw to the list of directories that are checked.
With this patch, on my Debian Lenny box with libncursesw5-dev package but
not libncurses5-dev package, I can say "make menuconfig".Signed-off-by: Junio C Hamano
Acked-by: Sam Ravnborg
Signed-off-by: Michal Marek
03 Jun, 2010
2 commits
-
Truncate list items to fit in a single line, otherwise those items
which have long prompts will cover some other items.This follows the behavior of menubox.
Signed-off-by: Li Zefan
Signed-off-by: Michal Marek -
Run:
make ARCH=arm menuconfigAnd then select "System Type" -> "ARM system type". The kconfig
"choice" menu at this point looks empty.It's because config ARCH_S3C2410 has a long prompt:
config ARCH_S3C2410
bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
...menuconfig centers the checklist according to this prompt without
considering the width of the list, and then things get wrong.Reported-by: Nobin Mathew
Signed-off-by: Li Zefan
Signed-off-by: Michal Marek
14 Apr, 2010
2 commits
-
Usage:
Press to show all config symbols which have prompts.Quote Tim Bird:
| I've been bitten by this numerous times. I most often
| use ftrace on ARM, but when I go back to x86, I almost
| always go through a sequence of searching for the
| function graph tracer in the menus, then realizing it's
| completely missing until I disable CC_OPTIMIZE_FOR_SIZE.
|
| Is there any way to have the menu item appear, but be
| unsettable unless the SIZE option is disabled? I'm
| not a Kconfig guru...I myself found this useful too. For example, I need to test
ftrace/tracing and want to be sure all the tracing features are
enabled, so I enter the "Tracers" menu, and press to
see if there is any config hidden.I also noticed gconfig and xconfig have a button "Show all options",
but that's a bit too much, and I think normally what we are not
interested in those configs which have no prompt thus can't be
changed by users.Exmaple:
--- Tracers
-*- Kernel Function Tracer
- - Kernel Function Graph Tracer
[*] Interrupts-off Latency Tracer
- - Preemption-off Latency Tracer
[*] Sysprof TracerHere you can see 2 tracers are not selectable, and then can find
out how to make them selectable.Signed-off-by: Li Zefan
Signed-off-by: Michal Marek -
- fix a typo in documentation
- fix a typo in a printk on error
- fix comments in dialog_inputbox()Signed-off-by: Li Zefan
Signed-off-by: Michal Marek
18 Jul, 2009
1 commit
-
Fix build on non GNU based platforms.
Cc: Roman Zippel
Signed-off-by: Sam Ravnborg
10 Jun, 2009
1 commit
-
Implement support for comment entries within choice groups. Comment entries
are displayed visually distinct from normal configs, and selecting them is
a no-op.Signed-off-by: Peter Korsgaard
Cc: Roman Zippel
Signed-off-by: Sam Ravnborg
04 Dec, 2008
1 commit
-
As noted by Bernhard - fix it up.
Cc: Bernhard Reutner-Fischer
Signed-off-by: Sam Ravnborg
02 May, 2008
1 commit
-
OS-X shell did not like 'echo -e' so implement
suggestion from Al Viro to use a more portable construct.Signed-off-by: Sam Ravnborg
Cc: Al Viro
Acked-By: Timur Tabi
29 Apr, 2008
1 commit
-
Fix reversal of dlg.border.atr and dlg.dialog.atr for draw_box()
Makes the inputbox look like expectedSigned-off-by: Roel Kluin
Signed-off-by: Sam Ravnborg
29 Jan, 2008
3 commits
-
Gettext support for lxdialog.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Kconfig is powerfull tool. So powerfull that more and more software
projects are using it for configuration. So instead of fixing some of
them one by one, lets fix it in kernel and wait for sync.This work was originaly done for PTXdist - GPL licensed build system for
userlands and cross-compilers, but it will not hurt kernel kconfig
either. PTXdist menuconfig now works on Windows linked with PDCurses and
compiled using MinGW - there is no termios and signals.* Do not include and (comes from times when
lxdialog was separate process)
* Do not mess with termios directly and let curses tell screen size.
Comment to commit c8dc68ad0fbd934e78e913b8a8d7b45945db4930 says
check for screen size could be removed later, but because it didn't
happen for more than year I left it here as well.
* Save cursor position added by SamSigned-off-by: Ladislav Michl
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
With this patch when ncurses-devel (or whatever it is named)
is missing trying to run menuconfig will result in this:$ make menuconfig
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/kxgettext.o
*** Unable to find the ncurses libraries or the
*** required header files.
*** 'make menuconfig' requires the ncurses libraries.
***
*** Install ncurses (ncurses-devel) and try again.
***
make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1
make: *** [menuconfig] Error 2Much better than before where we just listed some build errors.
The other *config targets will work indepenednt on ncurses
being present or not.Includes improvements suggested by: Frans Pop
Signed-off-by: Sam Ravnborg
Cc: Frans Pop
17 Jul, 2007
1 commit
-
The "==" operator is not in POSIX, so use -eq instead.
Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
19 May, 2007
1 commit
-
The check-lxdialog.sh script searches for "libFOO.so" which fails on OS X, due
to their special naming of libraries like "libfoo.dylib". This patch turns
the curses lib search into extensible loops and adds dylib as a valid
extension.Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
03 May, 2007
2 commits
-
When loading an alternate configuration use that file as
current configuration filename.
Make the filename visible in the dialog.
Default continue to be .config.Inspired by patch from: Cyrill Gorcunov
Signed-off-by: Sam Ravnborg
Cc: Cyrill Gorcunov -
The index() function is obsolete, use strchr() instead.
Signed-off-by: Mike Frysinger
Signed-off-by: Sam Ravnborg
26 Nov, 2006
1 commit
-
On Mon, 13 Nov 2006, Phil Oester wrote:
> In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> color scheme was changed to bluetitle. This breaks the highlighting
> of the selected item for me with TERM=vt100. The only way I can see
> which item is selected is via:
>
> make MENUCONFIG_COLOR=mono menuconfig
>
> Which restores the pre-2.6.19 white on black highlighting.Fix.
Cc: Phil Oester
Signed-off-by: Roman Zippel
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Oct, 2006
1 commit
-
scripts/kconfig/lxdialog/util.c fails to build because it uses
true/false without including stdbool.h:kronos:~/src/linux-2.6$ make O=../linux-build-git menuconfig
GEN /home/kronos/src/linux-build/Makefile
HOSTCC scripts/kconfig/lxdialog/util.o
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_classic_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: (Each undeclared identifier is reported only once
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: for each function it appears in.)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:70: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_blackbg_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:101: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:102: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_bluetitle_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:144: error: 'true' undeclared (first use in this function)
make[2]: *** [scripts/kconfig/lxdialog/util.o] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [menuconfig] Error 2Add to dialog.h to fix the breakage.
Signed-off-by: Luca Tettamanti
Cc: Sam Ravnborg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
30 Sep, 2006
7 commits
-
Menulines that were wider than the available
line width is now properly null terminated.While at it renamed the variable choice => line_y
so it better reflect the usage in do_print_item().Signed-off-by: Sam Ravnborg
-
In all dialogs now properly catch KEY_RESIZE and take proper action.
In mconf try to behave sensibly when a dialog routine returns
-ERRDISPLAYTOOSMALL.The original check for a screnn size of 80x19 is kept for now.
It may make sense to remove it later, but thats anyway what
much text is adjusted for.Signed-off-by: Sam Ravnborg
-
is used to step one back in the dialogs.
When lxdialog became built-in pressing once would cause one step back
and pressing would cause two steps back.
This patch - based on concept from Roman Zippel -
makes one a noop and pressing will cause one step backward.In addition the final yes/no dialog now has the option to go back to the
the kernel configuration. So if you get too far out you can now go back
to configuring the kernel without saving and starting all over again.Signed-off-by: Sam Ravnborg
-
lxdialog was previously called as an external program causing screen
to flicker when used. With this patch lxdialog is now built-in.
It is loosly based om previous work by: Petr BaudisFollowing is a list of changes:
o Moved build of dialog routings to kconfig Makefile
o menubox + checklist uses a new item list to hold all menu items
o in util.c implmented helper function to deal with item list
o menubox now uses parameters to save scroll state (avoids temp file)
o textbox now get text to be displayed as parameter and not a file
o make sure to properly delete subwin's before main windows
o killed unused files: lxdialog.c msgbox.c
o modified return value for ESC to match direct calling
o in a few places the code has been adjusted to 80 char wide
o in textbox a small refactoring was made to make code remotely readable
o in mconf removed all unused stuff (functions/variables)Following is a list of know short comings:
a) pressing ESC twice will be interpreted as two ESC presses
b) resize does not work. menuconfig needs to be restarted to be adjustedSigned-off-by: Sam Ravnborg
-
The bluetitle theme is a slightly modified version of the colorscheme
that -mm users has been used to. The bluetitle is more readable especially
on some LCD screens so it is now default.
Anyone that really wants the old color selection can get it by selecting
the classic color theme:
make MENUCONFIG_COLOR=classic menuconfigThe bluetitle theme was modified by Roman Zippel
to further improve readability on LCD screens.Signed-off-by: Sam Ravnborg
-
The blackbg theme was originally made by: Han Boetes
It was copied from a patch by "Randy.Dunlap"
which was also the inspiration source for the color theme support.Signed-off-by: Sam Ravnborg
-
Clean up and refactor color support. All color support are now
in util.c including color definitions.
In the process introduced a global variable named 'dlg' which is
used all over to set color - thats the reason why all files are changed.Signed-off-by: Sam Ravnborg
01 Jul, 2006
1 commit
-
Some fix that I forgot for good accessibility of lxdialog (the cursor
should always be left at the focus location):Have the checklist display the currently highlighted entry last, for having
the cursor left on it (rather than on the last line of the list).Signed-off-by: Samuel Thibault
Signed-off-by: Andrew Morton
Signed-off-by: Sam Ravnborg
15 Apr, 2006
1 commit
-
For easily getting fairly good accessibility, the TTY cursor should
always be left at the focus location. This patch fixes the checklist by
just having the list refreshed after the dialog box (hence the cursor
position remains in the list).Signed-off-by: Samuel Thibault
Signed-off-by: Linus Torvalds
11 Apr, 2006
1 commit
-
Move the menuconfig output more into the centre again, it's using a
fixed position depending on the window width using the fact that the
menu output has to work in a 80 chars terminal.Signed-off-by: Roman Zippel
Signed-off-by: Sam Ravnborg
06 Mar, 2006
1 commit
-
The kbuild system takes advantage of an incorrect behavior in GNU make.
Once this behavior is fixed, all files in the kernel rebuild every time,
even if nothing has changed. This patch ensures kbuild works with both
the incorrect and correct behaviors of GNU make.For more details on the incorrect behavior, see:
http://lists.gnu.org/archive/html/bug-make/2006-03/msg00003.html
Changes in this patch:
- Keep all targets that are to be marked .PHONY in a variable, PHONY.
- Add .PHONY: $(PHONY) to mark them properly.
- Remove any $(PHONY) files from the $? list when determining whether
targets are up-to-date or not.Signed-off-by: Paul Smith
Signed-off-by: Sam Ravnborg
21 Jan, 2006
1 commit
-
While running "make menuconfig" and "make mrproper"
some people experienced that /dev/null suddenly changed
permissions or suddenly became a regular file.
The main reason was that /dev/null was used as output
to gcc in the check-lxdialog.sh script and gcc did
some strange things with the output file; in this
case /dev/null when it errorred out.Following patch implements a suggestion
from Bryan O'Sullivan to
use gcc -print-file-name=libxxx.so.Also the Makefile is adjusted to not resolve value of
HOST_EXTRACFLAGS and HOST_LOADLIBES until they are actually used.
This prevents us from calling gcc when running make *clean/mrproperThanks to Eyal Lebedinsky and
Jean Delvare for the first error reports.Signed-off-by: Sam Ravnborg
---
15 Jan, 2006
1 commit
-
scripts/kconfig/lxdialog/check-lxdialog.sh uses gcc to check for
what libraries are present. Redirect output to /dev/null
so we do not generate an a.out.
Also included support for ncursesw - so if present prefer that
instead of ncurses.
The order is now (first is preferred):
1) ncursesw
2) ncurses
3) cursesThe latter is to support SunOS.
Signed-off-by: Sam Ravnborg
09 Jan, 2006
1 commit
-
Cleaning up the lxdialog Makefile by factoring out the
ncurses compatibility checks.
This made the checks much more obvious and easier to extend.Signed-off-by: Sam Ravnborg
03 Jan, 2006
1 commit
-
Signed-off-by: Sam Ravnborg
02 Jan, 2006
1 commit
-
Remove support for lxdialog --checklist
The checklist lxdialog functionality is not used by menuconfig
(only the radiolist variant is used) and supporting it would
significantly complicate the forthcoming liblxdialog API.Signed-off-by: Petr Baudis
Signed-off-by: Sam Ravnborg
17 Dec, 2005
1 commit
-
The only lxdialog user i kconfig - for menuconfig.
So move it to reflect this.Signed-off-by: Sam Ravnborg