25 May, 2018
1 commit
-
[ Upstream commit 7c73cf4cc2ac16465f5102437dc0a12d66671bd6 ]
The MODULE_ALIAS is required to enable the sun4i-ss driver to load
automatically when built at a module. Tested on a Cubietruck.Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Signed-off-by: Peter Robinson
Signed-off-by: Herbert Xu
Signed-off-by: Sasha Levin
Signed-off-by: Greg Kroah-Hartman
22 Feb, 2018
2 commits
-
commit 2e7d1d61ea6c0f1c4da5eb82cafac750d55637a7 upstream.
Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and
throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning.
Disabling softirqs to fix this.Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG")
Signed-off-by: Artem Savkov
Signed-off-by: Herbert Xu
Signed-off-by: Greg Kroah-Hartman -
commit dd78c832ffaf86eb6434e56de4bc3bc31f03f771 upstream.
According to crypto/rng.h generate function should return 0 on success
and < 0 on error.Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG")
Signed-off-by: Artem Savkov
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu
Signed-off-by: Greg Kroah-Hartman
18 Jul, 2017
1 commit
-
The Security System has a PRNG, this patch adds support for it via
crypto_rng.Signed-off-by: Corentin Labbe
Signed-off-by: Herbert Xu
19 Jun, 2017
11 commits
-
The run-time self-tests fail quite early, as soon as the input block
size is larger than 64 bytes:alg: hash: Test 4 failed for sha1-sun4i-ss
00000000: b9 c9 1e 52 c0 26 d8 39 81 ff f2 3c 99 b1 27 b2
00000010: 30 d6 c9 85One thing to notice is the value of the last word, which is the one
expected (it can sometime be the last two words). The datasheet isn't
very clear about when the digest is ready to retrieve and is seems the
bit SS_DATA_END is cleared when the digest was computed *but* that
doesn't mean the digest is ready to retrieve in the registers.A ndelay(1) is added before reading the computed digest to ensure it is
available in the SS_MD[] registers.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
The CRYPTO_ALG_KERN_DRIVER_ONLY flag is set for hardware accelerated
ciphers accessible through a kernel driver only. This is the case for
ciphers exposed by the sun4i-ss driver. This patch sets this flag.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Update the sun4i-ss driver to use the skcipher API instead of the old
ablkcipher one. It's a bit more tricky than s/ablkcipher/skcipher/, but
still nothing special and the driver's logic stays the same.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Use the GENMASK helper instead of custom calculations to generate masks,
It also helps the readability.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
A bit is appended at the end of the input buffer for sha1. Simplify the
code assigning it.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
When sending the last block of data to the engine, it should be padded
so that the total length of the request can be given to the engine as
the last 2 words of the last 64 bytes block.Simplify the calculation of this pad offset.
Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Parts of the bf buffer were dynamically set to 0. Change this to set the
whole buffer to 0 by default to avoid any mistake.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Do not use DMA is the request is 0 length.
Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Replace custom bit shifts and masks with lower/upper_32_bits helpers.
Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Cosmetic clean up if conditional checks on 0s values.
Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu -
Cosmetic change to avoid having a full screen a variable definitions. It
also helps to see which variables share the same type.Signed-off-by: Antoine Tenart
Tested-by: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Herbert Xu
22 Sep, 2016
1 commit
-
We get 1 warning when building kernel with W=1:
drivers/crypto/sunxi-ss/sun4i-ss-hash.c:168:5: warning: no previous prototype for 'sun4i_hash' [-Wmissing-prototypes]In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.Signed-off-by: Baoyou Xie
Signed-off-by: Herbert Xu
24 Aug, 2016
1 commit
-
Add the missing unlock before return from function sun4i_hash()
in the error handling case.Fixes: 477d9b2e591b ("crypto: sun4i-ss - unify update/final function")
Signed-off-by: Wei Yongjun
Acked-by: Corentin LABBE
Signed-off-by: Herbert Xu
16 Aug, 2016
6 commits
-
Two crypto alg are badly indented, this patch fix this style issue.
Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu -
The dev *ss is stored both in sun4i_tfm_ctx and sun4i_req_ctx.
Since this pointer will never be changed during tfm life, it is better
to remove it from sun4i_req_ctx.Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu -
Two words are badly spelled, this patch respell them.
Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu -
The ss variable is never used, remove it.
Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu -
The update and final functions have lots of common action.
This patch mix them in one function.
This will give some improvements:
- This will permit asynchronous support more easily
- This will permit to use finup/digest functions with some performance
improvementsSigned-off-by: LABBE Corentin
Signed-off-by: Herbert Xu -
The variable i is always checked against unsigned value and cannot be
negative.
This patch set it as unsigned.Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu
05 Apr, 2016
1 commit
-
The current sun4i-ss driver could generate data corruption when ciphering/deciphering.
It occurs randomly on end of handled data.
No root cause have been found and the only way to remove it is to replace
all spin_lock_bh by their irq counterparts.Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Signed-off-by: LABBE Corentin
Cc: stable
Signed-off-by: Herbert Xu
27 Jan, 2016
1 commit
-
gcc correctly warns that the printk output contains a variable that
it thinks is not initialized in some cases:drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll':
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76: warning: 'todo' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:144:15: note: 'todo' was declared hereA closer look at the function reveals that the variable is always
initialized at this point (ileft is guaranteed to be positive at the
start), but its contents are not well-defined:
Depending on some other variables, it might be either a count in
words or bytes, and it could refer to either input or output.The easiest solution apparently is to remove the confusing output
and let the reader figure out the state from the other variables.Signed-off-by: Arnd Bergmann
Signed-off-by: Herbert Xu
17 Nov, 2015
1 commit
-
sun4i-ss implementaton of md5/sha1 is via ahash algorithms.
Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero")
made impossible to load them without giving statesize. This patch
specifiy statesize for sha1 and md5.Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Cc: # v4.3+
Tested-by: Chen-Yu Tsai
Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu
10 Sep, 2015
1 commit
-
The sun4i_ss_opti_poll function cipher data until the output miter have
a length of 0.
If the crypto API client, give more SGs than necessary this could result
in an infinite loop.
Fix it by checking for remaining bytes, just like sun4i_ss_cipher_poll().Signed-off-by: LABBE Corentin
Signed-off-by: Herbert Xu
13 Aug, 2015
1 commit
-
On sun6i and later platforms, the reset control is split out of the
clock gates. Add support for an optional reset control.Signed-off-by: Chen-Yu Tsai
Signed-off-by: Herbert Xu
20 Jul, 2015
1 commit
-
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support:
- MD5 and SHA1 hash algorithms
- AES block cipher in CBC/ECB mode with 128/196/256bits keys.
- DES and 3DES block cipher in CBC/ECB modeSigned-off-by: LABBE Corentin
Signed-off-by: Herbert Xu