Eric Lee / smarc-fsl-linux-kernel

01 Nov, 2011

1 commit

13 Jul, 2011

1 commit

  • c84c14224   carminefb: Fix module parameters permissions ... Browse Code »
    1

    The third parameter of module_param is supposed to be an octal value.
    The missing leading "0" causes the following:

    $ ls -l /sys/module/carminefb/parameters/
    total 0
    -rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_displays
    -rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_mode
    -rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_mode_str

    After fixing the perm parameter, we get the expected:

    $ ls -l /sys/module/carminefb/parameters/
    total 0
    -r--r--r-- 1 root root 4096 Jul 8 08:56 fb_displays
    -r--r--r-- 1 root root 4096 Jul 8 08:56 fb_mode
    -r--r--r-- 1 root root 4096 Jul 8 08:56 fb_mode_str

    Signed-off-by: Jean Delvare
    Cc: Paul Mundt
    Cc: Sebastian Siewior
    Cc: stable@kernel.org
    Signed-off-by: Paul Mundt

    Jean Delvare
     

06 Jan, 2011

1 commit

  • e045da7d8   drivers/video/carminefb.c: improve error handling ... Browse Code »

    This code had an error handling goto to the wrong place, a misplaced
    release_mem_region, and a duplicated release_mem_region.

    The semantic match that finds the double release_mem_region is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r@
    expression e1,e2,e3;
    position p1,p2,p3;
    @@
    release_mem_region@p1(e1, e2)@p3;
    ... when != request_mem_region(e1,e2,e3)
    release_mem_region(e1, e2)@p2;

    @@
    expression e

    Signed-off-by: Julia Lawall
    Signed-off-by: Paul Mundt

    Julia Lawall
     

17 Jun, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

17 Jun, 2009

1 commit

07 Jan, 2009

1 commit

17 Oct, 2008

1 commit

  • 313cc59ea   framebuffer: fix carminefb section mismatch ... Browse Code »

    Make alloc_carmine_fb() __devinit.

    WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix

    The function alloc_carmine_fb() references the variable __devinitdata
    carminefb_fix. This is often because alloc_carmine_fb lacks a
    __devinitdata annotation or the annotation of carminefb_fix is wrong.

    Signed-off-by: Randy Dunlap
    Cc: Sebastian Siewior
    Cc: Geert Uytterhoeven
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

25 Jul, 2008

1 commit

  • 2ece5f43b   fbdev: add the carmine FB driver ... Browse Code »

    Basic FB driver for the carmine chip. The driver registers two FB devices for
    the two possible screens. The DRAM settings can be be switched via Kconfig
    (between eval board and custom).

    Signed-off-by: Sebastian Siewior
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sebastian Siewior