10 Jan, 2007
5 commits
-
inetdev_init out label moved after RCU assignment
(final suggestion by Herbert Xu)Signed-off-by: Jarek Poplawski
Acked-by: Herbert Xu
Signed-off-by: David S. Miller -
A quick patch to change the inet_sock->is_icsk assignment to better fit with
existing kernel coding style.Signed-off-by: Paul Moore
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
The subh->err_hdr should point to the error header, not the data.
Signed-off-by: Vlad Yasevich
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
When loading the NAT module, existing connection tracking entries don't
have room for NAT information allocated and packets are dropped, causing
hanging connections. They really should be entered into the NAT table
as NULL mappings, but the current allocation scheme doesn't allow this.For now simply accept those packets to avoid the hanging connections.
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
When IPv6 connection tracking splits up a defragmented packet into
its original fragments, the packets are taken from a list and are
passed to the network stack with skb->next still set. This causes
dev_hard_start_xmit to treat them as GSO fragments, resulting in
a use after free when connection tracking handles the next fragment.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
09 Jan, 2007
9 commits
-
This fixes the ftp stalls present in the current kernels.
All credit goes to Komuro for tracking
this down. The patch is untested but it looks *cough* obviously
correct.Signed-off-by: Craig Schlenter
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller -
->helper is uninitialized in the expectation registered by the netbios_ns
helper and it later copied to the expected connection, which causes invalid
memory dereferences when trying to call the helper.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
The current netlbl_cipsov4_add_common() function has two problems which are
fixed with this patch. The first is an off-by-one bug where it is possibile to
overflow the doi_def->tags[] array. The second is a bug where the same
doi_def->tags[] array was not always fully initialized, which caused sporadic
failures.Signed-off-by: Paul Moore
Signed-off-by: James Morris -
In the case the device registration for a new Bluetooth low-level
connection fails there is no need to unregister it when the temporary
data structure has been removed.Signed-off-by: Marcel Holtmann
-
When calling send() with a zero length parameter on a RFCOMM socket
it returns a positive value. In this rare case the variable err is
used uninitialized and unfortunately its value is returned.Signed-off-by: Marcel Holtmann
-
If the DLC device is no longer attached to the TTY device, then return
errors or default values for various callbacks of the TTY layer.Signed-off-by: Marcel Holtmann
-
With malformed packets it might be possible to overwrite internal
CMTP and CAPI data structures. This patch adds additional length
checks to prevent these kinds of remote attacks.Signed-off-by: Marcel Holtmann
-
Trivial. Newlines missing on the SOCK_DEBUG's for X.25 facility
negotiation.Signed-off-by: Andrew Hendry
Signed-off-by: David S. Miller -
The inet_create() and inet6_create() functions incorrectly set the
inet_sock->is_icsk field. Both functions assume that the is_icsk field is
large enough to hold at least a INET_PROTOSW_ICSK value when it is actually
only a single bit. This patch corrects the assignment by doing a boolean
comparison whose result will safely fit into a single bit field.Signed-off-by: Paul Moore
Signed-off-by: David S. Miller
05 Jan, 2007
6 commits
-
It is important that we only assign dev->ip{,6}_ptr
only after all portions of the inet{,6} are setup.Otherwise we can receive packets before the multicast
spinlocks et al. are initialized.Signed-off-by: David L Stevens
Signed-off-by: David S. Miller -
We cannot compute the gap until we know we have a 'struct ebt_entry' and
not 'struct ebt_entries'. Failure to check can cause crash.Tested-by: Santiago Garcia Mantinan
Acked-by: Al Viro
Signed-off-by: Chuck Ebbert
Signed-off-by: Andrew Morton
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Check the return value of nfct_nat() in device_cmp(), we might very well
have non NAT conntrack entries as well (Netfilter bugzilla #528).Signed-off-by: Martin Josefsson
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Packets generated by the REJECT target in the output chain have a local
destination address and a foreign source address. Make sure not to use
the foreign source address for the output route lookup.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Used by compat code offsets of entries should be 'unsigned int' as entries
array size has this dimension.Signed-off-by: Dmitry Mishin
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
04 Jan, 2007
5 commits
-
This patch adds a proper prototype for x25_init_timers() in
include/net/x25.hSigned-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
This patch removes redundant argument check for module_put().
Signed-off-by: Mariusz Kozlowski
Signed-off-by: David S. Miller -
All ->doit handlers want a struct rtattr **, so pass down the right
type.Signed-off-by: Christoph Hellwig
Signed-off-by: David S. Miller -
Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller -
Based upon a suggestion from Christoph Hellwig.
This fixes various races in module load/unload handling
too.Signed-off-by: David S. Miller
01 Jan, 2007
1 commit
-
Installing an IPsec SA using old algorithm names (.compat) does not work
if the algorithm is not already loaded. When not using the PF_KEY
interface, algorithms are not preloaded in xfrm_probe_algs() and
installing a IPsec SA fails.Signed-off-by: Martin Willi
Acked-by: Herbert Xu
Signed-off-by: David S. Miller
27 Dec, 2006
1 commit
-
…inville/wireless-2.6 into upstream-fixes
23 Dec, 2006
6 commits
-
When this code was converted to use sk_for_each() the
logic for the "best hash chain length" code was reversed,
breaking everything.The original code was of the form:
size = 0;
do {
if (++size >= best_size_so_far)
goto next;
} while ((sk = sk->next) != NULL);
best_size_so_far = size;
best = result;
next:;and this got converted into:
sk_for_each(sk2, node, head)
if (++size < best_size_so_far) {
best_size_so_far = size;
best = result;
}Which does something very very different from the original.
Signed-off-by: David S. Miller
-
This patch makes the following needlessly global functions static:
- ipv6.c: sctp_inet6addr_event()
- protocol.c: sctp_inetaddr_event()Signed-off-by: Adrian Bunk
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
Signed-off-by: Ivan Skytte Jorgensen
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
Back when the original NetLabel patches were being changed to use Netlink
attributes correctly some code was accidentially dropped which set all of the
undefined CIPSOv4 level and category mappings to a sentinel value. The result
is the mappings data in the kernel contains bogus mappings which always map to
zero. This patch restores the old/correct behavior by initializing the mapping
data to the correct sentinel value.Signed-off-by: Paul Moore
Signed-off-by: James Morris -
There are a couple of cases where the user input for a CIPSOv4 DOI add
operation was not being done soon enough; the result was unexpected behavior
which was resulting in oops/panics/lockups on some platforms. This patch moves
the existing input validation code earlier in the code path to protect against
bogus user input.Signed-off-by: Paul Moore
Signed-off-by: James Morris -
Return error and prevent from loading module when gss_mech_register()
failed.Cc: Andy Adamson
Cc: J. Bruce Fields
Acked-by: Trond Myklebust
Signed-off-by: Akinobu Mita
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Dec, 2006
2 commits
-
ieee80211softmac_wx_get_genie locks the associnfo mutex at
function exit. This patch fixes it. The patch is against Linus'
tree (commit af1713e0).Signed-off-by: Ulrich Kunitz
Signed-off-by: Michael Buesch
Acked-by: Johannes Berg
Signed-off-by: Larry Finger
Signed-off-by: Andrew Morton
Signed-off-by: John W. Linville -
The signature of work functions changed recently from a context
pointer to the work structure pointer. This caused a problem in
the ieee80211softmac code, because the ieee80211softmac_assox_work
function has been called directly with a parameter explicitly
casted to (void*). This compiled correctly but resulted in a
softlock, because mutex_lock was called with the wrong memory
address. The patch fixes the problem. Another issue was a wrong
call of the schedule_work function. Softmac works again and this
fixes the problem I mentioned earlier in the zd1211rw rx tasklet
patch. The patch is against Linus' tree (commit af1713e0).Signed-off-by: Ulrich Kunitz
Acked-by: Michael Buesch
Signed-off-by: Larry Finger
Signed-off-by: Andrew Morton
Signed-off-by: John W. Linville
18 Dec, 2006
5 commits
-
Fix the redirect packet of the router if the jiffies wraparound.
Signed-off-by: Li Yewang
Signed-off-by: David S. Miller -
The message logged in tcp_v4_inbound_md5_hash when the hash was expected
but not found was reversed.Signed-off-by: Leigh Brown
Signed-off-by: David S. Miller -
md5sig_info.alloced4 must be set to zero when freeing keys4, otherwise
it will not be alloc'd again when another key is added to the same
socket by tcp_v4_md5_do_add.Signed-off-by: Leigh Brown
Signed-off-by: David S. Miller -
Although the menu dependencies in net/ipv6/netfilter/Kconfig
guard the entries in that file from the Kconfig GUI, this does
not prevent them from being selected still via "make oldconfig"
when IPV6 etc. is disabled.So add explicit dependencies.
Signed-off-by: David S. Miller
-
rose_add_loopback_neigh uses kmalloc and the callers were ignoring the
error value. Rewrite to let the caller deal with the allocation. This
allows the use of static allocation of kmalloc use entirely.Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller
