29 Aug, 2010

16 commits


28 Aug, 2010

4 commits

  • The fsnotify main loop has 2 bools which indicated if we processed the
    inode or vfsmount mark in that particular pass through the loop. These
    bool can we replaced with the inode_group and vfsmount_group variables
    and actually make the code a little easier to understand.

    Signed-off-by: Eric Paris

    Eric Paris
     
  • Marks were stored on the inode and vfsmonut mark list in order from
    highest memory address to lowest memory address. The code to walk those
    lists thought they were in order from lowest to highest with
    unpredictable results when trying to match up marks from each. It was
    possible that extra events would be sent to userspace when inode
    marks ignoring events wouldn't get matched with the vfsmount marks.

    This problem only affected fanotify when using both vfsmount and inode
    marks simultaneously.

    Signed-off-by: Eric Paris

    Eric Paris
     
  • The appropriate error code when privileged operations are denied is
    EPERM, not EACCES.

    Signed-off-by: Andreas Gruenbacher
    Signed-off-by: Eric Paris

    Andreas Gruenbacher
     
  • resize pid and reorder the fanotify_event_metadata so it is naturally
    aligned and we can work towards dropping the packed attributed

    Signed-off-by: Tvrtko Ursulin
    Cc: Andreas Dilger
    Signed-off-by: Eric Paris

    Tvrtko Ursulin
     

27 Aug, 2010

20 commits

  • Fixes a regression caused by 21edad32205e97dc7ccb81a85234c77e760364c8

    When file name encryption was enabled, ecryptfs_lookup() failed to use
    the encrypted and encoded version of the upper, plaintext, file name
    when performing a lookup in the lower file system. This made it
    impossible to lookup existing encrypted file names and any newly created
    files would have plaintext file names in the lower file system.

    https://bugs.launchpad.net/ecryptfs/+bug/623087

    Signed-off-by: Tyler Hicks

    Tyler Hicks
     
  • Some ecryptfs init functions are not prefixed by __init and thus not
    freed after initialization. This patch saved about 1kB in ecryptfs
    module.

    Signed-off-by: Jerome Marchand
    Signed-off-by: Tyler Hicks

    Jerome Marchand
     
  • In this code, 0 is returned on memory allocation failure, even though other
    failures return -ENOMEM or other similar values.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression ret;
    expression x,e1,e2,e3;
    @@

    ret = 0
    ... when != ret = e1
    *x = \(kmalloc\|kcalloc\|kzalloc\)(...)
    ... when != ret = e2
    if (x == NULL) { ... when != ret = e3
    return ret;
    }
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Tyler Hicks

    Julia Lawall
     
  • Fix link failure without the vga arbitrator.

    Signed-off-by: Chris Wilson
    Cc: Dave Airlie
    Cc: Jesse Barnes
    Signed-off-by: Dave Airlie

    Chris Wilson
     
  • Signed-off-by: Alex Deucher
    Signed-off-by: Dave Airlie

    Alex Deucher
     
  • Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16651

    Signed-off-by: Adam Jackson
    Tested-by: Adam Serbinski
    Signed-off-by: Dave Airlie

    Adam Jackson
     
  • This locking path needs proper auditing but probably too late for changes at this point for 2.6.36, so lets go with the quick fix, which is to drop the lock around schedule.

    Reported-by: Andreas Schwab
    Signed-off-by: Dave Airlie

    Arnd Bergmann
     
  • I missed this one in the i2c unification patch. This
    is handled in the core radeon i2c code now.

    Signed-off-by: Alex Deucher
    Signed-off-by: Dave Airlie

    Alex Deucher
     
  • With the code cleanup in

    7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit
    commit 7a6b2896f261894dde287d3faefa4b432cddca53
    Author: Daniel Vetter
    Date: Fri Jul 2 15:02:15 2010 +0100

    drm_mm: extract check_free_mm_node

    I've botched up the range-restriction checks. The result is usually
    an X server dying with SIGBUS in libpixman (software fallback rendering).
    Change the code to adjust the start and end for range restricted
    allocations. IMHO this even makes the code a bit clearer.

    Fixes regression bug: https://bugs.freedesktop.org/show_bug.cgi?id=29738

    Reported-by-Tested-by: Till MAtthiesen
    Acked-by: Alex Deucher
    Signed-off-by: Daniel Vetter
    Signed-off-by: Dave Airlie

    Daniel Vetter
     
  • It's been in fix-mode-only for a while now.

    Signed-off-by: Rusty Russell

    Rusty Russell
     
  • These days the headers we use are in glibc. If those are too old, you can
    add the -I lines to get the kernel headers.

    In file included from ../../include/linux/if_tun.h:19,
    from lguest.c:33:
    ../../include/linux/types.h:13:2: warning: #warning "Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders"
    lguest.c: In function ‘setup_tun_net’:
    lguest.c:1456: warning: dereferencing pointer ‘sin’ does break strict-aliasing rules
    lguest.c:1457: warning: dereferencing pointer ‘sin’ does break strict-aliasing rules
    lguest.c:1450: note: initialized from here

    Signed-off-by: Rusty Russell

    Rusty Russell
     
  • * 'nouveau/for-airlied' of /ssd/git/drm-nouveau-next:
    drm/nouveau: drop drm_global_mutex before sleeping in submission path
    drm: export drm_global_mutex for drivers to use
    drm/nv20: Don't use pushbuf calls on the original nv20.
    drm/nouveau: Fix TMDS on some DCB1.5 boards.
    drm/nouveau: Fix backlight control on PPC machines with an internal TMDS panel.
    drm/nv30: Apply modesetting to the correct slave encoder
    drm/nouveau: Use a helper function to match PCI device/subsystem IDs.
    drm/nv50: add dcb type 14 to enum to prevent compiler complaint

    Dave Airlie
     
  • If we keep hold of the mutex here, the process which currently holds the
    buffer object will never be able to release it, causing a deadlock.

    Signed-off-by: Ben Skeggs

    Ben Skeggs
     
  • Nouveau needs to be able to drop the mutex before sleeping to prevent a
    deadlock from occuring.

    Signed-off-by: Ben Skeggs

    Ben Skeggs
     
  • Fix the pm_qos_add_request() kerneldoc comment that doesn't reflect
    the behavior of the function after the last PM QoS update.

    Signed-off-by: Saravana Kannan
    Acked-by: mark gross
    Signed-off-by: Rafael J. Wysocki

    Saravana Kannan
     
  • The commit ebabe9a9001af0af56c0c2780ca1576246e7a74b
    pass a struct path to vfs_statfs
    introduced the struct path initialization, and this seems to trigger
    an Oops on my machine.

    fh_dentry field may be NULL and set later in fh_verify(), thus the
    initialization of path must be after fh_verify().

    Signed-off-by: Takashi Iwai
    Reviewed-by: Christoph Hellwig
    Reviewed-by: Minchan Kim
    Signed-off-by: J. Bruce Fields

    Takashi Iwai
     
  • J. Bruce Fields
     
  • If we already had a RW open for a file, and get a readonly open, we were
    piggybacking on the existing RW open. That's inconsistent with the
    downgrade logic which blows away the RW open assuming you'll still have
    a readonly open.

    Also, make sure there is a readonly or writeonly open available for
    locking, again to prevent bad behavior in downgrade cases when any RW
    open may be lost.

    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     
  • Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     
  • It's OK for this function to return without setting filp--we do it in
    the special-stateid case.

    And there's a legitimate case where we can hit this, since we do permit
    reads on write-only stateid's.

    Signed-off-by: J. Bruce Fields

    J. Bruce Fields