Eric Lee / smarc-fsl-linux-kernel

01 Jun, 2011

1 commit

30 Apr, 2011

1 commit

  • 707394972   ethtool: cosmetic: Use ethtool ethtool_cmd_speed API ... Browse Code »

    This updates the network drivers so that they don't access the
    ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
    instead.

    For most of the drivers, these changes are purely cosmetic and don't
    fix any problem, such as for those 1GbE/10GbE drivers that indirectly
    call their own ethtool get_settings()/mii_ethtool_gset(). The changes
    are meant to enforce code consistency and provide robustness with
    future larger throughputs, at the expense of a few CPU cycles for each
    ethtool operation.

    All drivers compiled with make allyesconfig ion x86_64 have been
    updated.

    Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
    Signed-off-by: David Decotigny
    Signed-off-by: David S. Miller

    David Decotigny
     

19 Apr, 2011

1 commit

  • e5cb966c0   net: fix section mismatches ... Browse Code »

    Fix build warnings like the following:

    WARNING: drivers/net/built-in.o(.data+0x12434): Section mismatch in reference from the variable madgemc_driver to the variable .init.data:madgemc_adapter_ids

    And add some consts to EISA device ID tables along the way.

    Signed-off-by: Michał Mirosław
    Signed-off-by: David S. Miller

    Michał Mirosław
     

14 May, 2010

1 commit

  • a4b770972   drivers/net: Remove unnecessary returns from void function()s ... Browse Code »

    This patch removes from drivers/net/ all the unnecessary
    return; statements that precede the last closing brace of
    void functions.

    It does not remove the returns that are immediately
    preceded by a label as gcc doesn't like that.

    It also does not remove null void functions with return.

    Done via:
    $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
    xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

    with some cleanups by hand.

    Compile tested x86 allmodconfig only.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

10 May, 2010

1 commit

  • 1ae5dc342   net: trans_start cleanups ... Browse Code »

    Now that core network takes care of trans_start updates, dont do it
    in drivers themselves, if possible. Drivers can avoid one cache miss
    (on dev->trans_start) in their start_xmit() handler.

    Exceptions are NETIF_F_LLTX drivers

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

13 Feb, 2010

1 commit

04 Dec, 2009

1 commit

  • 8e95a2026   drivers/net: Move && and || to end of previous line ... Browse Code »

    Only files where David Miller is the primary git-signer.
    wireless, wimax, ixgbe, etc are not modified.

    Compile tested x86 allyesconfig only
    Not all files compiled (not x86 compatible)

    Added a few > 80 column lines, which I ignored.
    Existing checkpatch complaints ignored.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

19 Nov, 2009

1 commit

  • a0607fd3a   drivers/net: request_irq - Remove unnecessary leading & from second arg ... Browse Code »

    Not as fancy as coccinelle. Checkpatch errors ignored.
    Compile tested allyesconfig x86, not all files compiled.

    grep -rPl --include=*.[ch] "\brequest_irq\s*\([^,\)]+,\s*\&" drivers/net | while read file ; do \
    perl -i -e 'local $/; while (<>) { s@(\brequest_irq\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
    done

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

01 Sep, 2009

1 commit

06 Jul, 2009

1 commit

03 Jun, 2009

1 commit

01 Jun, 2009

1 commit

  • cf9f6e21c   3c509: Add missing EISA IDs ... Browse Code »

    Several EISA device IDs for 3c509 family network cards are missing from
    the driver, making the cards unusable in their EISA mode. Here's a fix to
    add them based on the EISA configuration files distributed by 3Com and our
    eisa.ids database.

    Signed-off-by: Maciej W. Rozycki
    Signed-off-by: David S. Miller

    Maciej W. Rozycki
     

27 May, 2009

1 commit

02 May, 2009

1 commit

  • 1aec5bdfe   net: remove driver_data direct access of struct device ... Browse Code »

    In the near future, the driver core is going to not allow direct access
    to the driver_data pointer in struct device. Instead, the functions
    dev_get_drvdata() and dev_set_drvdata() should be used. These functions
    have been around since the beginning, so are backwards compatible with
    all older kernel versions.

    Cc: netdev@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman
    Signed-off-by: David S. Miller

    Greg Kroah-Hartman
     

07 Feb, 2009

2 commits

  • 409f0a901   Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 ... Browse Code »

    Conflicts:
    drivers/net/wireless/iwlwifi/iwl-agn.c
    drivers/net/wireless/iwlwifi/iwl3945-base.c

    David S. Miller
     
  • 152abd139   3c509: Fix resume from hibernation for PnP mode. ... Browse Code »

    From: Ondrej Zary

    last year, I posted a patch which fixed hibernation on 3c509
    cards. That was back in 2.6.24. It worked fine in 2.6.25. But then I
    stopped using hibernation (as it did not work with my new IT8212 RAID
    controller).

    Now I fixed it and noticed that 3c509 does not wake up properly
    anymore (in 2.6.28) - neither in PnP nor in ISA modes. ifconfig
    down/up makes the card work again in PnP mode. However, in ISA mode,
    ifconfig up ends with "No such device" error.

    Comparing the 3c509 driver between 2.6.25 and 2.6.28, there's only
    some statistics-related change. So the cause of the problem must be
    somewhere else.

    This patch makes the resume work in PnP mode, but it's still not
    enough for ISA mode.

    Signed-off-by: David S. Miller

    Ondrej Zary
     

22 Jan, 2009

1 commit

07 Nov, 2008

1 commit

04 Nov, 2008

1 commit

02 Nov, 2008

1 commit

28 Oct, 2008

1 commit

  • e174961ca   net: convert print_mac to %pM ... Browse Code »

    This converts pretty much everything to print_mac. There were
    a few things that had conflicts which I have just dropped for
    now, no harm done.

    I've built an allyesconfig with this and looked at the files
    that weren't built very carefully, but it's a huge patch.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

17 Oct, 2008

1 commit

27 May, 2008

1 commit

  • c5e6fd28e   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 ... Browse Code »

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (52 commits)
    vlan: Use bitmask of feature flags instead of seperate feature bits
    fmvj18x_cs: add NextCom NC5310 rev B support
    xirc2ps_cs: re-initialize the multicast address in do_reset
    3C509: rx_bytes should not be increased when alloc_skb failed
    NETFRONT: Use __skb_queue_purge()
    VIRTIO: Use __skb_queue_purge()
    phylib: do EXPORT_SYMBOL on get_phy_id
    netlink: Fix nla_parse_nested_compat() to call nla_parse() directly
    WAN: protect HDLC proto list while insmod/rmmod
    drivers/net/fs_enet: remove null pointer dereference
    S2io: Version update for napi and MSI-X patches
    S2io: Added napi support when MSIX is enabled.
    S2io: Move all the transmit completions to a single msi-x (alarm) vector
    drivers/net/ehea - remove unnecessary memset after kzalloc
    au1000_eth: remove useless check
    Blackfin EMAC Driver: Removed duplicated include
    cpmac bugfixes and enhancements
    e1000e: use resource_size_t, not unsigned long, for phys addrs
    net/usb: add support for Apple USB Ethernet Adapter
    uli526x: add support for netpoll
    ...

    Linus Torvalds
     

23 May, 2008

1 commit

22 May, 2008

1 commit

29 Apr, 2008

1 commit

29 Mar, 2008

1 commit

  • ac4bed137   3c509: convert to isa_driver and pnp_driver ... Browse Code »

    Convert 3c509 driver to isa_driver and pnp_driver. The result is that
    autoloading using udev and hibernation works with ISA PnP cards. It also adds
    hibernation support for non-PnP ISA cards.

    xcvr module parameter was removed as its value was not used.

    Tested using 3 ISA cards in various combinations of PnP and non-PnP modes.
    EISA and MCA only compile-tested.

    Signed-off-by: Ondrej Zary
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Ondrej Zary
     

13 Jan, 2008

1 commit

  • 9ca20ebc2   3c509: PnP resource management fix ... Browse Code »

    In order to release PnP resources a card type must be set to EL3_PNP.
    Previously, it was never set hence the PnP resources were not
    released and device was left in incorrect state.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Jeff Garzik

    Krzysztof Helt
     

11 Oct, 2007

3 commits

09 May, 2007

1 commit

28 Apr, 2007

1 commit

26 Apr, 2007

1 commit

07 Oct, 2006

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

27 Sep, 2006

1 commit

  • 07563c711   [PATCH] EISA bus MODALIAS attributes support ... Browse Code »

    Add modalias attribute support for the almost forgotten now EISA bus and
    (at least some) EISA-aware modules.

    The modalias entry looks like (for an 3c509 NIC):

    eisa:sTCM5093

    and the in-module alias like:

    eisa:sTCM5093*

    The patch moves struct eisa_device_id declaration from include/linux/eisa.h
    to include/linux/mod_devicetable.h (so that the former now #includes the
    latter), adds proper MODULE_DEVICE_TABLE(eisa, ...) statements for all
    drivers with EISA IDs I found (some drivers already have that DEVICE_TABLE
    declared), and adds recognision of __mod_eisa_device_table to
    scripts/mod/file2alias.c so that proper modules.alias will be generated.

    There's no support for /lib/modules/$kver/modules.eisamap, as it's not used
    by any existing tools, and because with in-kernel modalias mechanism those
    maps are obsolete anyway.

    The rationale for this patch is:

    a) to make EISA bus to act as other busses with modalias
    support, to unify driver loading

    b) to foget about EISA finally - with this patch, kernel
    (who still supports EISA) will be the only one who knows
    how to choose the necessary drivers for this bus ;)

    [akpm@osdl.org: fix the kbuild bit]
    Signed-off-by: Michael Tokarev
    Cc: Rusty Russell
    Cc: Randy Dunlap
    Acked-the-net-bits-by: Jeff Garzik
    Acked-the-tulip-bit-by: Valerie Henson
    Cc: James Bottomley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Tokarev
     

19 Sep, 2006

1 commit

14 Sep, 2006

1 commit