08 Apr, 2011

1 commit

  • Since 1c48a5c93da6313 (dt: Eliminate of_platform_{,un}register_driver)
    mpc8xxx_wdt no longer builds as it tries to refer to a 'match' variable
    rather than ofdev->dev.of_match that it checks just before.

    Signed-off-by: Peter Korsgaard
    Acked-by: Grant Likely
    Signed-off-by: Wim Van Sebroeck

    Peter Korsgaard
     

31 Mar, 2011

1 commit


29 Mar, 2011

5 commits

  • This is needed for determining the reason for failure when a softdog
    timeout occurs.

    We use softdog to watch for critical application failures and at the
    minimum a snapshot of the system would help to determine the cause. In
    such a scenario the application could fail but there isn't a softlockup as
    such, hence the detect softlockup feature does not help.

    The patch adds a module parameter soft_panic which when set to 1 causes
    softdog to invoke panic instead of reboot when the softdog timer expires.
    By invoking panic we execute kdump if it is configured and the vmcore
    generated by kdump should provide atleast a minimal idea of the reason for
    failure.

    Based on an original patch by Ken Sugawara
    Signed-off-by: Anithra P J
    Reviewed-by: WANG Cong
    Acked-by: Alan Cox
    Signed-off-by: Wim Van Sebroeck
    Signed-off-by: Andrew Morton

    Anithra P Janakiraman
     
  • Fix section mismatch warning:
    Mark the called nv_tco_getdevice() as __devinit, just like its caller.

    WARNING: drivers/watchdog/nv_tco.o(.devinit.text+0x16): Section mismatch in reference from the function nv_tco_init() to the function .init.text:nv_tco_getdevice()
    The function __devinit nv_tco_init() references
    a function __init nv_tco_getdevice().
    If nv_tco_getdevice is only used by nv_tco_init then
    annotate nv_tco_getdevice with a matching annotation.

    Signed-off-by: Randy Dunlap
    Signed-off-by: Wim Van Sebroeck

    Randy Dunlap
     
  • Stefano found SP5100 TCO watchdog driver using wrong address.

    [ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
    [ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1

    and e820 said that range is RAM.

    We should check if we can use that reading out. BIOS could just program wrong address there.

    Reported-by: Stefano Stabellini
    Signed-off-by:Yinghai Lu
    Acked-by: Mike Waychison
    Tested-by: Konrad Rzeszutek Wilk
    Signed-off-by: Wim Van Sebroeck
    Cc: stable

    Yinghai Lu
     
  • Request_mem_region should be used with release_mem_region, not
    release_resource.

    In pnx4008_wdt.c, a missing clk_put is added as well.

    The semantic match that finds the first problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @@
    expression x,E;
    @@
    *x = request_mem_region(...)
    ... when != release_mem_region(x)
    when != x = E
    * release_resource(x);
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Wim Van Sebroeck
    Cc: stable

    Julia Lawall
     
  • Request_mem_region should be used with release_mem_region, not
    release_resource.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @@
    expression x,E;
    @@
    *x = request_mem_region(...)
    ... when != release_mem_region(x)
    when != x = E
    * release_resource(x);
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Wim Van Sebroeck
    Cc: stable

    Julia Lawall
     

23 Mar, 2011

1 commit


19 Mar, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (47 commits)
    doc: CONFIG_UNEVICTABLE_LRU doesn't exist anymore
    Update cpuset info & webiste for cgroups
    dcdbas: force SMI to happen when expected
    arch/arm/Kconfig: remove one to many l's in the word.
    asm-generic/user.h: Fix spelling in comment
    drm: fix printk typo 'sracth'
    Remove one to many n's in a word
    Documentation/filesystems/romfs.txt: fixing link to genromfs
    drivers:scsi Change printk typo initate -> initiate
    serial, pch uart: Remove duplicate inclusion of linux/pci.h header
    fs/eventpoll.c: fix spelling
    mm: Fix out-of-date comments which refers non-existent functions
    drm: Fix printk typo 'failled'
    coh901318.c: Change initate to initiate.
    mbox-db5500.c Change initate to initiate.
    edac: correct i82975x error-info reported
    edac: correct i82975x mci initialisation
    edac: correct commented info
    fs: update comments to point correct document
    target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c
    ...

    Trivial conflict in fs/eventpoll.c (spelling vs addition)

    Linus Torvalds
     

18 Mar, 2011

3 commits

  • * 'omap-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6: (258 commits)
    omap: zoom: host should not pull up wl1271's irq line
    arm: plat-omap: iommu: fix request_mem_region() error path
    OMAP2+: Common CPU DIE ID reading code reads wrong registers for OMAP4430
    omap4: mux: Remove duplicate mux modes
    omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
    omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set
    omap2+: mux: Fix compile when CONFIG_OMAP_MUX is not selected
    omap4: board-omap4panda: Initialise the serial pads
    omap3: board-3430sdp: Initialise the serial pads
    omap4: board-4430sdp: Initialise the serial pads
    omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init
    omap2+: mux: Remove the use of IDLE flag
    omap2+: Add separate list for dynamic pads to mux
    perf: add OMAP support for the new power events
    OMAP4: Add IVA OPP enteries.
    OMAP4: Update Voltage Rail Values for MPU, IVA and CORE
    OMAP4: Enable 800 MHz and 1 GHz MPU-OPP
    OMAP3+: OPP: Replace voltage values with Macros
    OMAP3: wdtimer: Fix CORE idle transition
    Watchdog: omap_wdt: add fine grain runtime-pm
    ...

    Fix up various conflicts in
    - arch/arm/mach-omap2/board-omap3evm.c
    - arch/arm/mach-omap2/clock3xxx_data.c
    - arch/arm/mach-omap2/usb-musb.c
    - arch/arm/plat-omap/include/plat/usb.h
    - drivers/usb/musb/musb_core.h

    Linus Torvalds
     
  • * 'defcfg' of master.kernel.org:/home/rmk/linux-2.6-arm:
    ARM: 6647/1: add Versatile Express defconfig
    ARM: 6644/1: mach-ux500: update the U8500 defconfig

    * 'drivers' of master.kernel.org:/home/rmk/linux-2.6-arm:
    ARM: 6764/1: pl011: factor out FIFO to TTY code
    ARM: 6763/1: pl011: add optional RX DMA to PL011 v2
    ARM: 6758/1: amba: support pm ops
    ARM: amba: make amba_driver id_table const
    ARM: amba: make internal ID table handling const
    ARM: amba: make probe() functions take const id tables
    ARM: 6662/1: amba: make amba_bustype non-static
    ARM: mmci: add dmaengine-based DMA support
    ARM: mmci: no need for separate host->data_xfered
    ARM: mmci: avoid unnecessary switch to data available PIO interrupts
    ARM: mmci: no need to call flush_dcache_page() with sg_miter API
    ARM: mmci: avoid reporting too many completed bytes on fifo overrun
    ALSA: AACI: make fifo variables more explanitory
    ALSA: AACI: no need to call snd_pcm_period_elapsed() for each period
    ALSA: AACI: use snd_pcm_lib_period_bytes()
    ALSA: AACI: clean up AACI announcement printk
    ALSA: AACI: fix channel mask selection
    ALSA: AACI: fix number of channels for record
    ALSA: AACI: fix multiple IRQ claiming

    * 'cyberpro-next' of master.kernel.org:/home/rmk/linux-2.6-arm:
    VIDEO: cyberpro: remove unused cyber2000fb_get_fb_var()
    VIDEO: cyberpro: remove useless function extreg pointers
    VIDEO: cyberpro: update handling of device structures
    VIDEO: cyberpro: add support for video capture I2C
    VIDEO: cyberpro: make 'reg_b0_lock' always present
    VIDEO: cyberpro: add I2C support
    VIDEO: cyberpro: select lowest multipler/divisor for PLL

    Linus Torvalds
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog:
    watchdog: booke_wdt: clean up status messages
    watchdog: cleanup spaces before tabs
    watchdog: convert to DEFINE_PCI_DEVICE_TABLE
    watchdog: Xen watchdog driver
    watchdog: Intel SCU Watchdog Timer Driver for Moorestown and Medfield platforms.
    watchdog: jz4740_wdt - fix magic character checking
    watchdog: add JZ4740 watchdog driver
    watchdog: it87_wdt: Add support for IT8721F watchdog
    watchdog: hpwdt: build hpwdt as module by default with NMI_DECODING enabled
    watchdog: hpwdt: Fix a couple of typos

    Linus Torvalds
     

17 Mar, 2011

2 commits

  • …linux-2.6 into sh-latest

    Paul Mundt
     
  • * 'devicetree/next' of git://git.secretlab.ca/git/linux-2.6: (21 commits)
    tty: serial: altera_jtaguart: Add device tree support
    tty: serial: altera_uart: Add devicetree support
    dt: eliminate of_platform_driver shim code
    dt: Eliminate of_platform_{,un}register_driver
    dt/serial: Eliminate users of of_platform_{,un}register_driver
    dt/usb: Eliminate users of of_platform_{,un}register_driver
    dt/video: Eliminate users of of_platform_{,un}register_driver
    dt/net: Eliminate users of of_platform_{,un}register_driver
    dt/sound: Eliminate users of of_platform_{,un}register_driver
    dt/spi: Eliminate users of of_platform_{,un}register_driver
    dt: uartlite: merge platform and of_platform driver bindings
    dt: xilinx_hwicap: merge platform and of_platform driver bindings
    ipmi: convert OF driver to platform driver
    leds/leds-gpio: merge platform_driver with of_platform_driver
    dt/sparc: Eliminate users of of_platform_{,un}register_driver
    dt/powerpc: Eliminate users of of_platform_{,un}register_driver
    dt/powerpc: move of_bus_type infrastructure to ibmebus
    drivercore/dt: add a match table pointer to struct device
    dt: Typo fix.
    altera_ps2: Add devicetree support
    ...

    Linus Torvalds
     

16 Mar, 2011

10 commits

  • Improve the status messages that are displayed during some operations of the
    PowerPC watchdog timer driver. When the watchdog is enabled, the timeout is
    displayed as a number of seconds, instead of an obscure "period". The "period"
    is the position of a bit in a 64-bit timer register. The higher the value,
    the quicker the watchdog timeout occurs. Some people chose a high "period"
    value for the timer and get confused as to why the board resets within a
    few seconds.

    Messages displayed during open and close are now debug messages, so that they
    don't clutter the console by default. Finally, printk() is replaced with the
    pr_xxx() equivalent.

    Signed-off-by: Timur Tabi
    Signed-off-by: Wim Van Sebroeck

    Timur Tabi
     
  • cleanup spaces before tabs in drivers/watchdog/

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE tables.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • While the hypervisor change adding SCHEDOP_watchdog support included a
    daemon to make use of the new functionality, having a kernel driver
    for /dev/watchdog so that user space code doesn't need to distinguish
    non-Xen and Xen seems to be preferable.

    Signed-off-by: Jan Beulich
    Cc: Jeremy Fitzhardinge
    Signed-off-by: Wim Van Sebroeck

    Jan Beulich
     
  • This submission includes:
    - Fix to intel_scu_write() to start watchdog timer the on the
    first write, and refresh on subsequent writes.
    This enables Open, write, write, ... usage model.
    - Moves boot parameter checks from intel_scu_open() to
    intel_scu_watchdog_init(), so driver init will fail if these
    parameters are out of bounds.
    - Adds check for whether process waiting in wait_event_interruptible()
    received a signal while it was waiting.
    - Other small error handling changes.

    Removed the read() method for now as that wass a non-standard behaviour.

    Signed-off-by: Donald Johnson
    Signed-off-by: Shuduo Sang
    Signed-off-by: Alan Cox
    Signed-off-by: Wim Van Sebroeck

    Donald Johnson
     
  • When writing to /dev/watchdog all characters should be checked
    for the magic character 'V'.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • Adds support for the hardware watchdog found in Ingenic's jz4740
    System-on-Chip.

    Signed-off-by: Paul Cercueil
    Signed-off-by: Wim Van Sebroeck

    Paul Cercueil
     
  • This patch adds support for a watchdog in IT8721F Super IO
    chip to it87_wdt driver.
    This new chips differ from the older IT87xxxF chips
    in the following ways:

    * WDT_GAMEPORT is not in IT8721F.
    * WDT_PWROK is not in IT8721F.

    Signed-off-by: Haruo Tomita
    Signed-off-by: Wim Van Sebroeck

    Huaro Tomita
     
  • Builds the hpwdt driver as a module by default.
    If the hardware is present, the module will be loaded.
    Also, if hpwdt is loaded, it will decode NMIs by default.

    This has been made possible by he patches to hpwdt made by Dann Frazier
    as well as related patches submitted by Don Zickus.

    hpwdt only loads on hp ProLiant x86 32-bit and 64-bit platforms.

    Signed-off-by: Tony Camuso
    Signed-off-by: Wim Van Sebroeck

    Tony Camuso
     
  • Fix some typos.

    Signed-off-by: Naga Chumbalkar
    Signed-off-by: Wim Van Sebroeck

    Naga Chumbalkar
     

14 Mar, 2011

5 commits

  • hpwdt_init_nmi_decoding() is called in hpwdt_init_one error handling,
    thus remove the __devexit annotation of hpwdt_exit_nmi_decoding().

    This patch fixes below warning:

    WARNING: drivers/watchdog/hpwdt.o(.devinit.text+0x36f): Section mismatch in reference from the function hpwdt_init_one() to the function .devexit.text:hpwdt_exit_nmi_decoding()
    The function __devinit hpwdt_init_one() references
    a function __devexit hpwdt_exit_nmi_decoding().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    hpwdt_exit_nmi_decoding() so it may be used outside an exit section.

    Signed-off-by: Axel Lin
    Acked-by: Thomas Mingarelli
    Signed-off-by: Wim Van Sebroeck

    Axel Lin
     
  • outb_p(c || 0x01, WDT_EFDR); -> || should be |

    Reported-By: Toralf Förster
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • "==" has higher precedence than "&". Since
    if (sch311x_sio_inb(sio_config_port, 0x30) & (0x01 == 0)) is always
    false the message is never printed.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Wim Van Sebroeck

    Dan Carpenter
     
  • if (sch311x_sio_inb(sio_config_port, 0x30) && 0x01 == 0) -> && should be &

    Reported-By: Toralf Förster
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • cppcheck-1.47 reports:
    [drivers/watchdog/cpwd.c:650]: (error) Buffer access out-of-bounds: p.devs

    The source code is
    for (i = 0; i < 4; i++) {
    misc_deregister(&p->devs[i].misc);

    where devs is defined as WD_NUMDEVS big and WD_NUMDEVS is equal to 3.
    So the 4 should be a 3 or WD_NUMDEVS.

    Reported-By: David Binderman
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

11 Mar, 2011

1 commit

  • The omap_wdt should only be in full active state when the
    registers are being accessed. Otherwise the device can be
    on lower power mode.

    This patch is based on a patch created by Kalle Jokiniemi:
    https://patchwork.kernel.org/patch/618231/
    which is itself based on a patch created by Atal
    Shargorodsky: http://lkml.org/lkml/2009/3/10/266.

    Signed-off-by: Paul Walmsley
    Signed-off-by: Kalle Jokiniemi
    Tested-by: Kalle Jokiniemi
    Cc: Wim Van Sebroeck
    Acked-by: Wim Van Sebroeck
    Acked-by: Kevin Hilman

    Paul Walmsley
     

10 Mar, 2011

1 commit

  • Some systems don't provide DMI_BOARD_NAME in their DMI tables. Avoid
    crash in such situations in fitpc2_wdt_init.

    The fix is to check if the dmi_get_system_info return value is NULL.

    The oops:
    BUG: unable to handle kernel NULL pointer dereference at (null)
    IP: [] strstr+0x26/0xa0
    PGD 3966e067 PUD 39605067 PMD 0
    Oops: 0000 [#1] SMP
    last sysfs file: /sys/devices/system/cpu/cpu1/cache/index2/shared_cpu_map
    CPU 1
    Modules linked in: ...
    Pid: 1748, comm: modprobe Not tainted 2.6.37-22-default #1 /Bochs
    RIP: 0010:[] [] strstr+0x26/0xa0
    RSP: 0018:ffff88003ad73f18 EFLAGS: 00010206
    RAX: 0000000000000000 RBX: 00000000ffffffed RCX: 00000000ffffffff
    RDX: ffffffffa003f4cc RSI: ffffffffa003f4c2 RDI: 0000000000000000
    ...
    CR2: 0000000000000000 CR3: 000000003b7ac000 CR4: 00000000000006e0
    ...
    Process modprobe (pid: 1748, threadinfo ffff88003ad72000, task ffff88002e6365c0)
    Stack: ...
    Call Trace:
    [] fitpc2_wdt_init+0x1f/0x13c [sbc_fitpc2_wdt]
    [] do_one_initcall+0x3a/0x170
    ...
    Code: f3 c3 0f 1f 00 80 3e 00 53 48 89 f8 74 1b 48 89 f2 0f 1f 40 00 48 83 c2 01 80 3a 00 75 f7 49 89 d0 48 89 f8 49 29 f0 75 02 5b c3 3f 00 74 0e 0f 1f 44 00 00 48 83 c0 01 80 38 00 75 f7 49 89

    Signed-off-by: Jiri Slaby
    Signed-off-by: Wim Van Sebroeck

    Jiri Slaby
     

01 Mar, 2011

2 commits


24 Feb, 2011

1 commit


08 Feb, 2011

2 commits


26 Jan, 2011

1 commit


12 Jan, 2011

3 commits