11 May, 2007

4 commits


10 May, 2007

1 commit


09 May, 2007

2 commits


08 May, 2007

1 commit


06 May, 2007

1 commit


05 May, 2007

5 commits


04 May, 2007

1 commit

  • 1) struct ip6_flowlabel : moves 'users' field to avoid two 32bits
    holes for 64bit arches. Shrinks by 8 bytes sizeof(struct
    ip6_flowlabel)

    2) ipv6_addr_cmp() and ipv6_addr_copy() dont need (void *) casts :
    Compiler might take into account natural alignement of in6_addr
    structs to emit better code for memcpy()/memcmp() Casts to (void *)
    force byte accesses.

    3) ipv6_addr_prefix() optimization :

    Better to clear whole struct, as compiler can emit better code for
    memset(addr, 0, 16) (2 stores on x86_64), and avoid some conditional
    branches.

    # size vmlinux.after vmlinux.before
    text data bss dec hex filename
    5262262 647612 557432 6467306 62aeea vmlinux.after
    5262550 647612 557432 6467594 62b00a vmlinux.before

    thats 288 bytes saved.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

03 May, 2007

2 commits

  • TCP has a transitional state when SACK is not in use during
    which this invariant is temporarily broken. Without SACK,
    tcp_clean_rtx_queue does not decrement sacked_out. Therefore
    calls to tcp_sync_left_out before sacked_out is again
    corrected by tcp_fastretrans_alert can trigger this trap as
    sacked_out still has couple of segments that are already out
    of window.

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     
  • __HAVE_ARCH_ADDR_SET seems unused these days, just get rid of it.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

30 Apr, 2007

4 commits

  • * master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6: (21 commits)
    [IPV4] SNMP: Support OutMcastPkts and OutBcastPkts
    [IPV4] SNMP: Support InMcastPkts and InBcastPkts
    [IPV4] SNMP: Support InTruncatedPkts
    [IPV4] SNMP: Support InNoRoutes
    [SNMP]: Add definitions for {In,Out}BcastPkts
    [TCP] FRTO: RFC4138 allows Nagle override when new data must be sent
    [TCP] FRTO: Delay skb available check until it's mandatory
    [XFRM]: Restrict upper layer information by bundle.
    [TCP]: Catch skb with S+L bugs earlier
    [PATCH] INET : IPV4 UDP lookups converted to a 2 pass algo
    [L2TP]: Add the ability to autoload a pppox protocol module.
    [SKB]: Introduce skb_queue_walk_safe()
    [AF_IUCV/IUCV]: smp_call_function deadlock
    [IPV6]: Fix slab corruption running ip6sic
    [TCP]: Update references in two old comments
    [XFRM]: Export SPD info
    [IPV6]: Track device renames in snmp6.
    [SCTP]: Fix sctp_getsockopt_local_addrs_old() to use local storage.
    [NET]: Remove NETIF_F_INTERNAL_STATS, default to internal stats.
    [NETPOLL]: Remove CONFIG_NETPOLL_RX
    ...

    Linus Torvalds
     
  • This is a corner case where less than MSS sized new data thingie
    is awaiting in the send queue. For F-RTO to work correctly, a
    new data segment must be sent at certain point or F-RTO cannot
    be used at all. RFC4138 allows overriding of Nagle at that
    point.

    Implementation uses frto_counter states 2 and 3 to distinguish
    when Nagle override is needed.

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     
  • On MIPv6 usage, XFRM sub policy is enabled.
    When main (IPsec) and sub (MIPv6) policy selectors have the same
    address set but different upper layer information (i.e. protocol
    number and its ports or type/code), multiple bundle should be created.
    However, currently we have issue to use the same bundle created for
    the first time with all flows covered by the case.

    It is useful for the bundle to have the upper layer information
    to be restructured correctly if it does not match with the flow.

    1. Bundle was created by two policies
    Selector from another policy is added to xfrm_dst.
    If the flow does not match the selector, it goes to slow path to
    restructure new bundle by single policy.

    2. Bundle was created by one policy
    Flow cache is added to xfrm_dst as originated one. If the flow does
    not match the cache, it goes to slow path to try searching another
    policy.

    Signed-off-by: Masahide NAKAMURA
    Signed-off-by: David S. Miller

    Masahide NAKAMURA
     
  • SACKED_ACKED and LOST are mutually exclusive with SACK, thus
    having their sum larger than packets_out is bug with SACK.
    Eventually these bugs trigger traps in the tcp_clean_rtx_queue
    with SACK but it's much more informative to do this here.

    Non-SACK TCP, however, could get more than packets_out duplicate
    ACKs which each increment sacked_out, so it makes sense to do
    this kind of limitting for non-SACK TCP but not for SACK enabled
    one. Perhaps the author had the opposite in mind but did the
    logic accidently wrong way around? Anyway, the sacked_out
    incrementer code for non-SACK already deals this issue before
    calling sync_left_out so this trapping can be done
    unconditionally.

    Signed-off-by: Ilpo Järvinen
    Signed-off-by: David S. Miller

    Ilpo Järvinen
     

29 Apr, 2007

2 commits

  • Calling smp_call_function can lead to a deadlock if it is called
    from tasklet context.
    Fixing this deadlock requires to move the smp_call_function from the
    tasklet context to a work queue. To do that queue the path pending
    interrupts to a separate list and move the path cleanup out of
    iucv_path_sever to iucv_path_connect and iucv_path_pending.
    This creates a new requirement for iucv_path_connect: it may not be
    called from tasklet context anymore.
    Also fixed compile problem for CONFIG_HOTPLUG_CPU=n and
    another one when walking the cpu_online mask. When doing this,
    we must disable cpu hotplug.

    Signed-off-by: Frank Pavlic
    Signed-off-by: Martin Schwidefsky
    Signed-off-by: David S. Miller

    Martin Schwidefsky
     
  • With this patch you can use iproute2 in user space to efficiently see
    how many policies exist in different directions.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     

28 Apr, 2007

5 commits


27 Apr, 2007

3 commits

  • This patch cleans up the call paths from the core code into wext.

    Signed-off-by: Johannes Berg
    Signed-off-by: John W. Linville
    Signed-off-by: David S. Miller

    Johannes Berg
     
  • Add an interface to the AF_RXRPC module so that the AFS filesystem module can
    more easily make use of the services available. AFS still opens a socket but
    then uses the action functions in lieu of sendmsg() and registers an intercept
    functions to grab messages before they're queued on the socket Rx queue.

    This permits AFS (or whatever) to:

    (1) Avoid the overhead of using the recvmsg() call.

    (2) Use different keys directly on individual client calls on one socket
    rather than having to open a whole slew of sockets, one for each key it
    might want to use.

    (3) Avoid calling request_key() at the point of issue of a call or opening of
    a socket. This is done instead by AFS at the point of open(), unlink() or
    other VFS operation and the key handed through.

    (4) Request the use of something other than GFP_KERNEL to allocate memory.

    Furthermore:

    (*) The socket buffer markings used by RxRPC are made available for AFS so
    that it can interpret the cooked RxRPC messages itself.

    (*) rxgen (un)marshalling abort codes are made available.

    The following documentation for the kernel interface is added to
    Documentation/networking/rxrpc.txt:

    =========================
    AF_RXRPC KERNEL INTERFACE
    =========================

    The AF_RXRPC module also provides an interface for use by in-kernel utilities
    such as the AFS filesystem. This permits such a utility to:

    (1) Use different keys directly on individual client calls on one socket
    rather than having to open a whole slew of sockets, one for each key it
    might want to use.

    (2) Avoid having RxRPC call request_key() at the point of issue of a call or
    opening of a socket. Instead the utility is responsible for requesting a
    key at the appropriate point. AFS, for instance, would do this during VFS
    operations such as open() or unlink(). The key is then handed through
    when the call is initiated.

    (3) Request the use of something other than GFP_KERNEL to allocate memory.

    (4) Avoid the overhead of using the recvmsg() call. RxRPC messages can be
    intercepted before they get put into the socket Rx queue and the socket
    buffers manipulated directly.

    To use the RxRPC facility, a kernel utility must still open an AF_RXRPC socket,
    bind an addess as appropriate and listen if it's to be a server socket, but
    then it passes this to the kernel interface functions.

    The kernel interface functions are as follows:

    (*) Begin a new client call.

    struct rxrpc_call *
    rxrpc_kernel_begin_call(struct socket *sock,
    struct sockaddr_rxrpc *srx,
    struct key *key,
    unsigned long user_call_ID,
    gfp_t gfp);

    This allocates the infrastructure to make a new RxRPC call and assigns
    call and connection numbers. The call will be made on the UDP port that
    the socket is bound to. The call will go to the destination address of a
    connected client socket unless an alternative is supplied (srx is
    non-NULL).

    If a key is supplied then this will be used to secure the call instead of
    the key bound to the socket with the RXRPC_SECURITY_KEY sockopt. Calls
    secured in this way will still share connections if at all possible.

    The user_call_ID is equivalent to that supplied to sendmsg() in the
    control data buffer. It is entirely feasible to use this to point to a
    kernel data structure.

    If this function is successful, an opaque reference to the RxRPC call is
    returned. The caller now holds a reference on this and it must be
    properly ended.

    (*) End a client call.

    void rxrpc_kernel_end_call(struct rxrpc_call *call);

    This is used to end a previously begun call. The user_call_ID is expunged
    from AF_RXRPC's knowledge and will not be seen again in association with
    the specified call.

    (*) Send data through a call.

    int rxrpc_kernel_send_data(struct rxrpc_call *call, struct msghdr *msg,
    size_t len);

    This is used to supply either the request part of a client call or the
    reply part of a server call. msg.msg_iovlen and msg.msg_iov specify the
    data buffers to be used. msg_iov may not be NULL and must point
    exclusively to in-kernel virtual addresses. msg.msg_flags may be given
    MSG_MORE if there will be subsequent data sends for this call.

    The msg must not specify a destination address, control data or any flags
    other than MSG_MORE. len is the total amount of data to transmit.

    (*) Abort a call.

    void rxrpc_kernel_abort_call(struct rxrpc_call *call, u32 abort_code);

    This is used to abort a call if it's still in an abortable state. The
    abort code specified will be placed in the ABORT message sent.

    (*) Intercept received RxRPC messages.

    typedef void (*rxrpc_interceptor_t)(struct sock *sk,
    unsigned long user_call_ID,
    struct sk_buff *skb);

    void
    rxrpc_kernel_intercept_rx_messages(struct socket *sock,
    rxrpc_interceptor_t interceptor);

    This installs an interceptor function on the specified AF_RXRPC socket.
    All messages that would otherwise wind up in the socket's Rx queue are
    then diverted to this function. Note that care must be taken to process
    the messages in the right order to maintain DATA message sequentiality.

    The interceptor function itself is provided with the address of the socket
    and handling the incoming message, the ID assigned by the kernel utility
    to the call and the socket buffer containing the message.

    The skb->mark field indicates the type of message:

    MARK MEANING
    =============================== =======================================
    RXRPC_SKB_MARK_DATA Data message
    RXRPC_SKB_MARK_FINAL_ACK Final ACK received for an incoming call
    RXRPC_SKB_MARK_BUSY Client call rejected as server busy
    RXRPC_SKB_MARK_REMOTE_ABORT Call aborted by peer
    RXRPC_SKB_MARK_NET_ERROR Network error detected
    RXRPC_SKB_MARK_LOCAL_ERROR Local error encountered
    RXRPC_SKB_MARK_NEW_CALL New incoming call awaiting acceptance

    The remote abort message can be probed with rxrpc_kernel_get_abort_code().
    The two error messages can be probed with rxrpc_kernel_get_error_number().
    A new call can be accepted with rxrpc_kernel_accept_call().

    Data messages can have their contents extracted with the usual bunch of
    socket buffer manipulation functions. A data message can be determined to
    be the last one in a sequence with rxrpc_kernel_is_data_last(). When a
    data message has been used up, rxrpc_kernel_data_delivered() should be
    called on it..

    Non-data messages should be handled to rxrpc_kernel_free_skb() to dispose
    of. It is possible to get extra refs on all types of message for later
    freeing, but this may pin the state of a call until the message is finally
    freed.

    (*) Accept an incoming call.

    struct rxrpc_call *
    rxrpc_kernel_accept_call(struct socket *sock,
    unsigned long user_call_ID);

    This is used to accept an incoming call and to assign it a call ID. This
    function is similar to rxrpc_kernel_begin_call() and calls accepted must
    be ended in the same way.

    If this function is successful, an opaque reference to the RxRPC call is
    returned. The caller now holds a reference on this and it must be
    properly ended.

    (*) Reject an incoming call.

    int rxrpc_kernel_reject_call(struct socket *sock);

    This is used to reject the first incoming call on the socket's queue with
    a BUSY message. -ENODATA is returned if there were no incoming calls.
    Other errors may be returned if the call had been aborted (-ECONNABORTED)
    or had timed out (-ETIME).

    (*) Record the delivery of a data message and free it.

    void rxrpc_kernel_data_delivered(struct sk_buff *skb);

    This is used to record a data message as having been delivered and to
    update the ACK state for the call. The socket buffer will be freed.

    (*) Free a message.

    void rxrpc_kernel_free_skb(struct sk_buff *skb);

    This is used to free a non-DATA socket buffer intercepted from an AF_RXRPC
    socket.

    (*) Determine if a data message is the last one on a call.

    bool rxrpc_kernel_is_data_last(struct sk_buff *skb);

    This is used to determine if a socket buffer holds the last data message
    to be received for a call (true will be returned if it does, false
    if not).

    The data message will be part of the reply on a client call and the
    request on an incoming call. In the latter case there will be more
    messages, but in the former case there will not.

    (*) Get the abort code from an abort message.

    u32 rxrpc_kernel_get_abort_code(struct sk_buff *skb);

    This is used to extract the abort code from a remote abort message.

    (*) Get the error number from a local or network error message.

    int rxrpc_kernel_get_error_number(struct sk_buff *skb);

    This is used to extract the error number from a message indicating either
    a local error occurred or a network error occurred.

    Signed-off-by: David Howells
    Signed-off-by: David S. Miller

    David Howells
     
  • Provide AF_RXRPC sockets that can be used to talk to AFS servers, or serve
    answers to AFS clients. KerberosIV security is fully supported. The patches
    and some example test programs can be found in:

    http://people.redhat.com/~dhowells/rxrpc/

    This will eventually replace the old implementation of kernel-only RxRPC
    currently resident in net/rxrpc/.

    Signed-off-by: David Howells
    Signed-off-by: David S. Miller

    David Howells
     

26 Apr, 2007

9 commits

  • - make the following needlessly global variables static:
    - core/rtnetlink.c: struct rtnl_msg_handlers[]
    - netfilter/nf_conntrack_proto.c: struct nf_ct_protos[]
    - make the following needlessly global functions static:
    - core/rtnetlink.c: rtnl_dump_all()
    - netlink/af_netlink.c: netlink_queue_skip()

    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Adrian Bunk
     
  • On a system with a lot of SAs, counting SAD entries chews useful
    CPU time since you need to dump the whole SAD to user space;
    i.e something like ip xfrm state ls | grep -i src | wc -l
    I have seen taking literally minutes on a 40K SAs when the system
    is swapping.
    With this patch, some of the SAD info (that was already being tracked)
    is exposed to user space. i.e you do:
    ip xfrm state count
    And you get the count; you can also pass -s to the command line and
    get the hash info.

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     
  • This patch moves the non-proc SNMP code into addrconf.c and reuses
    IPv4 SNMP code where applicable.

    As a result we can skip proc.o if /proc is disabled.

    Note that I've made a number of functions static since they're only
    used by addrconf.c for now. If they ever get used elsewhere we can
    always remove the static.

    Signed-off-by: Herbert Xu
    Acked-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    Herbert Xu
     
  • This patch moves the SNMP code shared between IPv4/IPv6 from proc.c
    into net/ipv4/af_inet.c. This makes sense because these functions
    aren't specific to /proc.

    As a result we can again skip proc.o if /proc is disabled.

    Signed-off-by: Herbert Xu
    Acked-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    Herbert Xu
     
  • This patch adds a comment that was part of my rtnl locking patch for
    cfg80211 but which I forgot for the merge.

    Signed-off-by: Johannes Berg
    Signed-off-by: John W. Linville
    Signed-off-by: David S. Miller

    Johannes Berg
     
  • Do some simple changes to make congestion control API faster/cleaner.
    * use ktime_t rather than timeval
    * merge rtt sampling into existing ack callback
    this means one indirect call versus two per ack.
    * use flags bits to store options/settings

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     
  • As scheduled, this patch removes the pointless wext over netlink code.

    Signed-off-by: Johannes Berg
    Signed-off-by: John W. Linville
    Signed-off-by: David S. Miller

    Johannes Berg
     
  • This patch creates the core cfg80211 code along with some sysfs bits.
    This is a stripped down version to allow mac80211 to function, but
    doesn't include any configuration yet except for creating and removing
    virtual interfaces.

    This patch includes the nl80211 header file but it only contains the
    interface types which the cfg80211 interface for creating virtual
    interfaces relies on.

    Signed-off-by: Johannes Berg
    Signed-off-by: John W. Linville
    Signed-off-by: David S. Miller

    Johannes Berg
     
  • Hint from David Miller .

    Signed-off-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    YOSHIFUJI Hideaki