Eric Lee / smarc-fsl-linux-kernel

26 Apr, 2007

2 commits

11 Feb, 2007

1 commit

19 Oct, 2006

1 commit

04 Oct, 2006

1 commit

  • 617dbeaa3   [TIPC]: fix printk warning ... Browse Code »

    gcc spits out this warning:

    net/tipc/link.c: In function ‘link_retransmit_failure’:
    net/tipc/link.c:1669: warning: cast from pointer to integer of different
    size

    More than a little bit ugly, storing integers in void*, but at least the
    code is correct, unlike some of the more crufty Linux kernel code found
    elsewhere.

    Rather than having two casts to massage the value into u32, it's easier
    just to have a single cast and use "%lu", since it's just a printk.

    Signed-off-by: Jeff Garzik
    Signed-off-by: David S. Miller

    Jeff Garzik
     

22 Jul, 2006

1 commit

04 Jul, 2006

1 commit

  • 863fae666   [TIPC] Fixed sk_buff panic caused by tipc_link_bundle_buf (REVISED) ... Browse Code »

    The recent change to direct inspection of bundle buffer tailroom did not
    account for the possiblity of unrequested tailroom added by skb_alloc(),
    thereby allowing a bundle to be created that exceeds the current link MTU.
    An additional check now ensures that bundling works correctly no matter
    if the bundle buffer is smaller, larger, or equal to the link MTU.

    Signed-off-by: Allan Stephens
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Allan Stephens
     

30 Jun, 2006

1 commit

  • e49060c7c   [TIPC]: Fixed skb_under_panic caused by tipc_link_bundle_buf ... Browse Code »

    Now determines tailroom of bundle buffer by directly inspection of buffer.
    Previously, buffer was assumed to have a max capacity equal to the link MTU,
    but the addition of link MTU negotiation means that the link MTU can increase
    after the bundle buffer is allocated.

    Signed-off-by: Allan Stephens
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Allan Stephens
     

26 Jun, 2006

6 commits

24 Mar, 2006

1 commit

21 Mar, 2006

3 commits

  • 7c501a596   [TIPC]: Remove unused functions ... Browse Code »

    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Per Liden
     
  • 05790c645   [TIPC]: Remove inlines from *.c ... Browse Code »

    With reference to latest discussions on linux-kernel with respect to
    inline here is a patch for tipc to remove all inlines as used in
    the .c files. See also chapter 14 in Documentation/CodingStyle.

    Before:
    text data bss dec hex filename
    102990 5292 1752 110034 1add2 tipc.o

    Now:
    text data bss dec hex filename
    101190 5292 1752 108234 1a6ca tipc.o

    This is a nice text size reduction which will improve icache usage.
    In some cases bigger (> 4 lines) functions where declared inline
    and used in many places, they are most probarly no longer inlined by gcc
    resulting in the size reduction.
    There are several one liners that no longer are declared inline, but gcc
    should inline these just fine without the inline hint.

    With this patch applied one warning is added about an unused static
    function - that was hidded by utilising inline before.
    The function in question were kept so this patch is solely a
    inline removal patch.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Sam Ravnborg
     
  • 1fc54d8f4   [TIPC]: Fix simple sparse warnings ... Browse Code »

    Tried to run the new tipc stack through sparse.
    Following patch fixes all cases where 0 was used
    as replacement of NULL.
    Use NULL to document this is a pointer and to silence sparse.

    This brough sparse warning count down with 127 to 24 warnings.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Sam Ravnborg
     

18 Jan, 2006

2 commits

13 Jan, 2006

4 commits