20 Jul, 2007
1 commit
-
Nonlinear mappings are (AFAIKS) simply a virtual memory concept that encodes
the virtual address -> file offset differently from linear mappings.->populate is a layering violation because the filesystem/pagecache code
should need to know anything about the virtual memory mapping. The hitch here
is that the ->nopage handler didn't pass down enough information (ie. pgoff).
But it is more logical to pass pgoff rather than have the ->nopage function
calculate it itself anyway (because that's a similar layering violation).Having the populate handler install the pte itself is likewise a nasty thing
to be doing.This patch introduces a new fault handler that replaces ->nopage and
->populate and (later) ->nopfn. Most of the old mechanism is still in place
so there is a lot of duplication and nice cleanups that can be removed if
everyone switches over.The rationale for doing this in the first place is that nonlinear mappings are
subject to the pagefault vs invalidate/truncate race too, and it seemed stupid
to duplicate the synchronisation logic rather than just consolidate the two.After this patch, MAP_NONBLOCK no longer sets up ptes for pages present in
pagecache. Seems like a fringe functionality anyway.NOPAGE_REFAULT is removed. This should be implemented with ->fault, and no
users have hit mainline yet.[akpm@linux-foundation.org: cleanup]
[randy.dunlap@oracle.com: doc. fixes for readahead]
[akpm@linux-foundation.org: build fix]
Signed-off-by: Nick Piggin
Signed-off-by: Randy Dunlap
Cc: Mark Fasheh
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Jul, 2007
9 commits
-
Signed-off-by: Eric Sandeen
Signed-off-by: Mark Fasheh -
This can now be trivially supported with re-use of our existing extend code.
ocfs2_allocate_unwritten_extents() takes a start offset and a byte length
and iterates over the inode, adding extents (marked as unwritten) until len
is reached. Existing extents are skipped over.Signed-off-by: Mark Fasheh
-
Update the write code to detect when the user is asking to write to an
unwritten extent. Like writing to a hole, we must zero the region between
the write and the cluster boundaries. Most of the existing cluster zeroing
logic can be re-used with some additional checks for the unwritten flag on
extent records.Signed-off-by: Mark Fasheh
-
We can easily seperate out the write descriptor setup and manipulation
into helper functions.Signed-off-by: Mark Fasheh
-
Signed-off-by: Mark Fasheh
-
We don't want to submit buffer_new blocks for read i/o. This actually won't
happen right now because those requests during an allocating write are all nicely
aligned. It's probably a good idea to provide an explicit check though.Signed-off-by: Mark Fasheh
-
Implement cluster consistent shared writeable mappings using the
->page_mkwrite() callback.Signed-off-by: Mark Fasheh
-
ocfs2_mkwrite() will want this so that it can add some mmap specific checks
before asking for a write.Signed-off-by: Mark Fasheh
-
Use some ideas from the new-aops patch series and turn
ocfs2_buffered_write_cluster() into a 2 stage operation with the caller
copying data in between. The code now understands multiple cluster writes as
a result of having to deal with a full page write for greater than 4k pages.This sets us up to easily call into the write path during ->page_mkwrite().
Signed-off-by: Mark Fasheh
07 Jun, 2007
1 commit
-
The write path code intends to bug if a math error (or unhandled case)
results in a write outside of the current cluster boundaries. The actual
BUG_ON() statements however are incorrect, leading to a crash on kernels
with 64k page size. Fix those by checking against the right variables.Also, move the assertions higher up within the functions so that they trip
*before* the code starts to mark buffers.Signed-off-by: Mark Fasheh
26 May, 2007
2 commits
-
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller
Signed-off-by: Andrew Morton
Signed-off-by: Mark Fasheh -
Similarly to the page lock / cluster lock inversion in ocfs2_readpage, we
can deadlock on ip_alloc_sem. We can down_read_trylock() instead and just
return AOP_TRUNCATED_PAGE if the operation fails.Signed-off-by: Mark Fasheh
03 May, 2007
3 commits
-
We can otherwise recurse into the file system.
Signed-off-by: Mark Fasheh
-
None of these are actually harmful, but the noise makes looking for real
problems difficult.Signed-off-by: Mark Fasheh
-
This patch makes the following needlessly global functions static:
- aops.c: ocfs2_write_data_page()
- dlmglue.c: ocfs2_dump_meta_lvb_info()
- file.c: ocfs2_set_inode_size()Signed-off-by: Adrian Bunk
Signed-off-by: Andrew Morton
Signed-off-by: Mark Fasheh
27 Apr, 2007
10 commits
-
Cluster locking might have been redone because a direct write won't
complete, so this needs to be reflected in the iocb.Signed-off-by: Mark Fasheh
-
Older file systems which didn't support holes did a dumb calculation of
i_blocks based on i_size. This is no longer accurate, so fix things up to
take actual allocation into account.Signed-off-by: Mark Fasheh
-
Initially, we had wired things to return a size '1' of holes. Cook up a
small amount of code to find the next extent and calculate the number of
clusters between the virtual offset and the next allocated extent.Signed-off-by: Mark Fasheh
-
Return an optional extent flags field from our lookup functions and wire up
callers to treat unwritten regions as holes for the purpose of returning
zeros to the user.Signed-off-by: Mark Fasheh
-
We need to fill holes during a splice write. Provide our own splice write
actor which can call ocfs2_file_buffered_write() with a splice-specific
callback.Signed-off-by: Mark Fasheh
-
Since we don't zero on extend anymore, truncate needs to be fixed up to zero
the part of a file between i_size and and end of it's cluster. Otherwise a
subsequent extend could expose bad data.This introduced a new helper, which can be used in ocfs2_write().
Signed-off-by: Mark Fasheh
-
ocfs2_get_block() didn't understand sparse files, fix that. Also remove some
code that isn't really useful anymore. We can fix up
ocfs2_direct_IO_get_blocks() at the same time.Signed-off-by: Mark Fasheh
-
These are no longer used, and can't handle file systems with sparse file
allocation.Signed-off-by: Mark Fasheh
-
Unfortunately, ocfs2 can no longer make use of generic_file_aio_write_nlock()
because allocating writes will require zeroing of pages adjacent to the I/O
for cluster sizes greater than page size.Implement a custom file write here, which can order page locks for zeroing.
This also has the advantage that cluster locks can easily be ordered outside
of the page locks.Signed-off-by: Mark Fasheh
-
The code in extent_map.c is not prepared to deal with a subtree being
rotated between lookups. This can happen when filling holes in sparse files.
Instead of a lengthy patch to update the code (which would likely lose the
benefit of caching subtree roots), we remove most of the algorithms and
implement a simple path based lookup. A less ambitious extent caching scheme
will be added in a later patch.Signed-off-by: Mark Fasheh
15 Mar, 2007
1 commit
-
Under load, OCFS2 would crash in invalidate_inode_pages2_range() because
invalidate_complete_page2() was unable to invalidate a page. It would
appear that JBD is holding on to the page. ext3 has a specific
->releasepage() handler to cover this case.Steal ext3's ->releasepage(), ->invalidatepage(), and ->migratepage(), as
they appear completely appropriate for OCFS2.Signed-off-by: Joel Becker
Signed-off-by: Mark Fasheh
29 Dec, 2006
1 commit
-
ocfs2_direct_IO_get_blocks() was incorrectly returning -EIO for a direct I/O
read whose start block was past the end of the file allocation tree. Fix
things so that we return a hole instead. do_direct_IO() will then notice
that the range start is past eof and return a short read.While there, remove the unused vbo_max variable.
Signed-off-by: Mark Fasheh
09 Dec, 2006
1 commit
-
Signed-off-by: Josef Sipek
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
02 Dec, 2006
4 commits
-
This is mostly a search and replace as ocfs2_journal_handle is now no more
than a container for a handle_t pointer.ocfs2_commit_trans() becomes very straight forward, and we remove some out
of date comments / code.Signed-off-by: Mark Fasheh
-
All callers either pass in NULL directly, or a local variable that is
already set to NULL.The internals of ocfs2_start_trans() get a nice cleanup as a result.
Signed-off-by: Mark Fasheh
-
This sets us up to remove handle->journal.
Signed-off-by: Mark Fasheh
-
Now that this is unused and all callers pass NULL, we can safely remove it.
Signed-off-by: Mark Fasheh
21 Sep, 2006
1 commit
-
We weren't always updating i_mtime on writes, so fix ocfs2_commit_write() to
handle this.Signed-off-by: Mark Fasheh
Acked-by: Zach Brown
30 Jun, 2006
1 commit
-
Signed-off-by: Florin Malita
Signed-off-by: Mark Fasheh
29 Jun, 2006
1 commit
-
Same as with already do with the file operations: keep them in .rodata and
prevents people from doing runtime patching.Signed-off-by: Christoph Hellwig
Cc: Steven French
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 May, 2006
1 commit
-
We need to take a data lock around extends to protect the pages that
ocfs2_zero_extend is going to be pulling into the page cache. Otherwise an
extend on one node might populate the page cache with data pages that have
no lock coverage.Signed-off-by: Mark Fasheh
27 Mar, 2006
1 commit
-
Now that get_block() can handle mapping multiple disk blocks, no need to have
->get_blocks(). This patch removes fs specific ->get_blocks() added for DIO
and makes it users use get_block() instead.Signed-off-by: Badari Pulavarty
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
25 Mar, 2006
1 commit
-
Signed-off-by: Mark Fasheh
04 Jan, 2006
1 commit
-
The OCFS2 file system module.
Signed-off-by: Mark Fasheh
Signed-off-by: Kurt Hackel