06 Aug, 2009
1 commit
-
String literals are constant, and usually, we can also tag the array
of pointers const too, moving it to the .rodata section.Signed-off-by: Jan Engelhardt
Signed-off-by: David S. Miller
05 Aug, 2009
2 commits
-
Same as how Randy Dunlap fixed the ipv4 side of things.
Signed-off-by: David S. Miller
-
Fix build errors when SYSCTLs are not enabled:
(.init.text+0x5154): undefined reference to `net_ipv4_ctl_path'
(.init.text+0x5176): undefined reference to `register_net_sysctl_table'
xfrm4_policy.c:(.exit.text+0x573): undefined reference to `unregister_net_sysctl_tableSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller
03 Aug, 2009
8 commits
-
Current neigh_periodic_timer() function is fired by timer IRQ, and
scans one hash bucket each round (very litle work in fact)As we are supposed to scan whole hash table in 15 seconds, this means
neigh_periodic_timer() can be fired very often. (depending on the number
of concurrent hash entries we stored in this table)Converting this to a workqueue permits scanning whole table, minimizing
icache pollution, and firing this work every 15 seconds, independantly
of hash table size.This 15 seconds delay is not a hard number, as work is a deferrable one.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Since pr_err and friends are used instead of printk there is no point
in keeping IP_VS_ERR and friends. Furthermore make use of '__func__'
instead of hard coded function names.Signed-off-by: Hannes Eder
Acked-by: Simon Horman
Signed-off-by: David S. Miller -
The eeprom read & write commands currently check the E2P_CMD_LOADED_ bit is
set before allowing any operations. This prevents any reading or writing
unless a correctly programmed EEPROM is installed.This patch removes the check, so it is possible to program blank EEPROMS
via ethtool.Signed-off-by: Steve Glendinning
Signed-off-by: David S. Miller -
This renames away a variable clash:
* ipv6_table[] is declared as a static global table;
* ipv6_sysctl_net_init() uses ipv6_table to refer/destroy dynamic memory;
* ipv6_sysctl_net_exit() also uses ipv6_table for the same purpose;
* both the two last functions call kfree() on ipv6_table.Signed-off-by: Gerrit Renker
Signed-off-by: David S. Miller -
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@haskernel@
@@#include
@depends on haskernel@
expression x,__divisor;
@@- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller -
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@haskernel@
@@#include
@depends on haskernel@
expression x,__divisor;
@@- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller -
Modify control register settings to accommodate the bridge's max read
requset size.Signed-off-by: Divy Le Ray
Signed-off-by: David S. Miller -
Fix a cut'n paste error in the AEL2020 twinax EDC file name
Signed-off-by: Divy Le Ray
Signed-off-by: David S. Miller
02 Aug, 2009
14 commits
-
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for vxge.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for s2io.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for qlge.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for ixgb.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for igbvf.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for bnx2x.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for bnx2.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for atl1e.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for atl1c.Signed-off-by: Dean Nelson
Signed-off-by: David S. Miller -
When the driver loads the POST stage of the card is expected to be
POST_STAGE_ARMFW_RDY.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
be_mbox_db_ring() has been changed to be_mbox_notify() (to be consistent with
be_mcc_notify()) and struct be_mcc_cq_entry changed to be_mcc_compl
to be consistent with rx/tx_compl.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
And get rid of some unnecessary printks.
Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
pci function is available as PCI_FUNC(pdev->devfn); no need for a
separate field.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller -
Currently only the be_ctrl_info struct ptr (instead of adapter) is
passed to all the routines in be_cmds.c. Instead pass be_adapter
ptr to allow access to all its fields. Merge the contents of struct be_ctrl_info
into be_adapter. The resulting code is simpler.Signed-off-by: Sathya Perla
Signed-off-by: David S. Miller
31 Jul, 2009
15 commits
-
Conflicts:
drivers/net/wireless/iwlwifi/iwl-3945.h
drivers/net/wireless/iwlwifi/iwl-tx.c
drivers/net/wireless/iwlwifi/iwl3945-base.c -
When a user disables interrupt throttling with ethtool on 82599 devices,
the interrupt timer may not be re-enabled if hardware RSC is running. The
RSC completions in hardware don't complete before the next ITR event tries
to fire, so the ITR timer never gets re-armed. This patch increases the
amount of time between interrupts when throttling is disabled (rx-usecs =
0) when the hardware RSC deature is enabled.Signed-off-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
A second set of feature flag bits was added, and the hardware RSC engine
flags were moved there. However, the code itself didn't make the move
completely to use the new bitmap.Signed-off-by: Peter P Waskiewicz Jr
Acked-by: Mallikarjuna R Chilakala
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Our ndo_poll_controller callback is broken for anything but non-multiqueue
setups. This fixes that issue.Signed-off-by: Peter P Waskiewicz Jr
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Choose saner defaults for xfrm[4|6] gc_thresh values on init
Currently, the xfrm[4|6] code has hard-coded initial gc_thresh values
(set to 1024). Given that the ipv4 and ipv6 routing caches are sized
dynamically at boot time, the static selections can be non-sensical.
This patch dynamically selects an appropriate gc threshold based on
the corresponding main routing table size, using the assumption that
we should in the worst case be able to handle as many connections as
the routing table can.For ipv4, the maximum route cache size is 16 * the number of hash
buckets in the route cache. Given that xfrm4 starts garbage
collection at the gc_thresh and prevents new allocations at 2 *
gc_thresh, we set gc_thresh to half the maximum route cache size.For ipv6, its a bit trickier. there is no maximum route cache size,
but the ipv6 dst_ops gc_thresh is statically set to 1024. It seems
sane to select a simmilar gc_thresh for the xfrm6 code that is half
the number of hash buckets in the v6 route cache times 16 (like the v4
code does).Signed-off-by: Neil Horman
Signed-off-by: David S. Miller -
While being at it cleanup whitespace.
Signed-off-by: Hannes Eder
Signed-off-by: David S. Miller -
Parameter order for using mk_ic_value(count, time) was reversed,
the patch fixes this.Signed-off-by: Jiajun Wu
Signed-off-by: Li Yang
Signed-off-by: David S. Miller -
If a socket is hashed in last slot of pppoe hash table (PPPOE_HASH_SIZE-1)
we report it many times (up to filling seq buffer)
(Only the last socket of last slot)Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
start_code is 69 words, but the code always writes a multiple of 16 words,
so the last 11 words written are outside the array.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
If arp_format_neigh_entry() can be called with n->dev->addr_len == 0, then a
write to hbuffer[-1] occurs.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
if dev_alloc_skb() fails on the first iteration, a write to
cp->rx_ring[-1] occurs.Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller -
There is no reason for the arbitrary restriction that device must be
up to create a vlan. This patch was added to Vyatta kernel to resolve startup
ordering issues where vlan's are created but real device was disabled.Note: the vlan already correctly inherits the operstate from real device; so
if vlan is created and real device is marked down, the vlan is marked
down.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use the %pI4 format string instead of %d.%d.%d.%d and NIPQUAD.
Signed-off-by: Tobias Klauser
Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Signed-off-by: Eilon Greenstein
Signed-off-by: David S. Miller
