31 Mar, 2009
3 commits
-
The pin for in6 and temp3 is shared on the W83667HG, so only one of
these features can be supported on any given system. Let the driver
select which one depending on the temp3 disabled bit.Signed-off-by: Gong Jun
Signed-off-by: Jean Delvare -
Add initial support for the Nuvoton W83667HG chip to the w83627ehf
driver. It has been tested on ASUS P5QL PRO by Gong Jun.At the moment there is still a usability issue which is that only in6
or temp3 can be present on the W83667HG, so the driver shouldn't
expose both. This will be addressed later.Signed-off-by: Gong Jun
Acked-by: David Hubbard
Signed-off-by: Jean Delvare -
Use positive logic for fan pin variables (variable is set if pin is
used for fan), instead of negative logic which is error prone.Signed-off-by: Jean Delvare
Cc: Gong Jun
18 Feb, 2009
1 commit
-
This patch fixes a number of cases where things were not properly
cleaned up when acpi_check_resource_conflict() returned an error,
causing oopses such as the one reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=483208Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
07 Jan, 2009
2 commits
-
Signed-off-by: Jean Delvare
Acked-by: Hans de Goede
Acked-by: David Hubbard -
Check for ACPI resource conflicts in hwmon drivers. I've included
all Super-I/O and PCI drivers.I've voluntarily left out:
* Vendor-specific drivers: if they conflicted on any system, this would
pretty much mean that they conflict on all systems, and we would know
by now.
* Legacy ISA drivers (lm78 and w83781d): they only support chips found
on old designs were ACPI either wasn't supported or didn't deal with
thermal management.
* Drivers accessing the I/O resources indirectly (e.g. through SMBus):
the checks are already done where they belong, i.e. in the bus drivers.Signed-off-by: Jean Delvare
Acked-by: David Hubbard
08 Feb, 2008
2 commits
-
While the W83627EHF/EHG has only 6 VID pins, the W83627DHG has 8 VID
pins, to support VRD 11.0. Add support for this.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
While it is possible to force SMBus-based hardware monitoring chip
drivers to drive a not officially supported device, we do not have this
possibility for Super-I/O-based drivers. That's unfortunate because
sometimes newer chips are fully compatible and just forcing the driver
to load would work. Instead of that we have to tell the users to
recompile the kernel driver, which isn't an easy task for everyone.So, I propose that we add a module parameter to all Super-I/O based
hardware monitoring drivers, letting advanced users force the driver
to load on their machine. The user has to provide the device ID of a
supposedly compatible device. This requires looking at the source code or
a datasheet, so I am confident that users can't randomly force a driver
without knowing what they are doing. Thus this should be relatively safe.As you can see from the code, the implementation is pretty simple and
unintrusive.Signed-off-by: Jean Delvare
Acked-by: Hans de Goede
Signed-off-by: Mark M. Hoffman
03 Jan, 2008
1 commit
-
The VID input level change has been reported to cause trouble. Be more
careful in this respect:
* Only change the level on the W83627EHF/EHG. The W83627DHG is more
complex in this respect.
* Don't change the level if the VID pins are in output mode.
* Only set the level to TTL if VRM 9.x is used.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
10 Oct, 2007
2 commits
-
Convert from class_device to device for hwmon_device_register/unregister
Signed-off-by: Tony Jones
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Kay Sievers
Signed-off-by: Mark M. Hoffman -
- replace differing temperature variable types by long
- use strtol() instead of strtoul() for conversionSigned-off-by: Christian Hohnstaedt
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
13 Aug, 2007
2 commits
-
Don't assume that the default bank is 0. For one thing, we don't even
set it to 0 when the driver is loaded, so the initial state might be
different. For another, something (say, the BIOS) might access the chip
and leave with the bank set to something different, so assuming that
the bank value is 0 is not safe.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch forces the driver to read the fan divider values during early init.
Otherwise, a call to store_fan_min() could access uninitialized variables.Signed-off-by: Mark M. Hoffman
Signed-off-by: Jean Delvare
20 Jul, 2007
9 commits
-
This fixes bug #8593:
http://bugzilla.kernel.org/show_bug.cgi?id=8593Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
We don't need to initialize fan_min in this driver, as the fan_div
attributes are read-only.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Add support for the w83627ehf thermal sensor types. I made them read-only,
as the BIOS is supposed to set them up properly. This information makes it
easier to find out which temperature channel corresponds to the CPU.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
If VBAT monitoring is disabled, enable it. Original patch from
an anonymous contributor on the lm-sensors trac system:
http://lm-sensors.org/ticket/2218Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
The W83627EHF and similar chips have 6 VID input pins, add support
for them. The driver changes the input voltage level automatically
if the current setting is not correct for the detected CPU model.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
* I have experimental evidence that the W83627EHG needs more than 1
second to refresh all the measured values. Increase the caching time to
1.5 second.
* When changing a fan clock divider, the corresponding fan speed
measurement register is no longer valid, until the next time the chip
will refresh it. One way to fix this is to pretend that the cache is
still valid for one more period (1.5 second.)Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
If the Super-I/O device is disabled, it is likely the BIOS has a good
reason for leaving it disabled, so give a warning when enabling it --
it's not likely to be wired correctly or be able to give good data.Also, if the Super-I/O device is configured with an address of 0, the
driver refuses to initialize it.Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Remove i2c-isa from the w83627ehf driver, and use a platform driver
instead.Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
The w83627ehf driver changes the fan clock divider automatically when
a new min fan speed is set. It is supposed to preserve the fan speed
reading while doing so, bug doesn't really. Fix it.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
24 Apr, 2007
1 commit
-
On ia64, kernel headers define REGION_OFFSET so we can't use that.
Reported by Andrew Morton.Signed-off-by: Jean Delvare
Acked-by: David Hubbard
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Apr, 2007
1 commit
-
Users have been complaining about the w83627ehf driver flooding their logs
with debug messages like:w83627ehf 9191-0a10: Increasing fan 4 clock divider from 64 to 128
or:
w83627ehf 9191-0290: Increasing fan 4 clock divider from 4 to 8
The reason is that we failed to actually write the LSB of the encoded clock
divider value for that fan, causing the next read to report the same old value
again and again.Additionally, the fan number was improperly reported, making the bug harder to
find.Signed-off-by: Jean Delvare
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
15 Feb, 2007
1 commit
-
Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
13 Dec, 2006
1 commit
-
The Silicon Hill club is not what it used to be.
Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
19 Oct, 2006
1 commit
-
Fix the detection of fan5 and preserve the bit between the
register writes, because the bit is write only.Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
29 Sep, 2006
3 commits
-
hwmon: Remove Yuan Mu's address
Yuan Mu no longer works at Winbond.
I wish to publicly thank Yuan for his help with Winbond hardware
monitoring chips support during the past 10 months.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
w83627ehf: Fix unchecked return status
Fix: check return value from device_create_file()
Fix: call device_remove_file() on error and module unload
Fix: call hwmon_device_register() after device_create_file() to eliminate raceSigned-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
This patch adds long-awaited support for automatic fan modes. Based on
the work of Yuan Mu from Winbond, I finished the support with the great
help of David Hubbard.Signed-off-by: Yuan Mu
Signed-off-by: Rudolf Marek
Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
27 Sep, 2006
1 commit
-
i2c-isa: Restore driver owner
Commit 2b48716d1d2f2edb1e7cbc5ecf1cb2cb39373e33 back in January
2006 was a bit overzealous. It removed .owner from all i2c drivers,
including i2c-isa ones, while they still need it.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
23 Jun, 2006
2 commits
-
Add alarms support for the W83627EHF/EHG hardware monitoring chip.
This is based on an earlier patch from Rudolf Marek.
Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
Add the voltage measuring support to W83627EHF. The code is based
on the patch provided by Yuan Mu from Winbond.Signed-off-by: Yuan Mu
Signed-off-by: Rudolf Marek
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
24 Mar, 2006
2 commits
-
Use dynamic sysfs callbacks and array of attributes to reduce the
w83627ehf driver size.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
convert drivers/hwmon/*.c semaphore use to mutexes.
the conversion was generated via scripts, and the result was validated
automatically via a script as well.all affected hwmon drivers were build-tested.
Signed-off-by: Ingo Molnar
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
06 Jan, 2006
2 commits
-
Now that i2c_add_driver() doesn't need the module owner to be set by
hand, we can delete it from the drivers. This patch catches all of the
drivers that I found in the current tree (if a driver sets the .owner by
hand, it's not a problem, just not needed.)Signed-off-by: Greg Kroah-Hartman
Cc: Jean Delvare -
We should use the i2c_driver.driver's .name and .owner fields
instead of the i2c_driver's ones.This patch updates the hwmon drivers.
Signed-off-by: Laurent Riffard
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
29 Oct, 2005
2 commits
-
Use kzalloc instead of kmalloc+memset in all hardware monitoring
drivers.Signed-off-by: Deepak Saxena
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman -
This patch changes w83627hf and w83627ehf drivers to reserve only ports
0x295-0x296, instead of full 0x290-0x297 range. While some other
sensors chips respond to all addresses in 0x290-0x297 range, Winbond
chips respond to 0x295-0x296 only (this behavior is implied by
documentation, and matches behavior observed on real systems). This is
not problem alone, as no BIOS was found to put something at these unused
addresses, and sensors chip itself provides nothing there as well.But in addition to only respond to these two addresses, also BIOS
vendors report in their ACPI-PnP structures that there is some resource
at I/O address 0x295 of length 2. And when later this hwmon driver
attempts to request region with base 0x290/length 8, it fails as one
request_region cannot span more than one device.Due to this we have to ask only for region this hardware really
occupies, otherwise driver cannot be loaded on systems with ACPI-PnP
enabled.Signed-off-by: Petr Vandrovec
Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
06 Sep, 2005
1 commit
-
We could refactor the error message 34 different i2c drivers print if
i2c_detach_client() fails in this function itself. Saves quite a few
lines of code. Documentation is updated to reflect that change.Note that this patch should be applied after Rudolf Marek's w83792d
patches.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman