07 Jan, 2009

1 commit

• 2e5ba26a4   dynamic_printk: reduce one level of indentation ... Browse Code »

  Cleanup pr_debug_write() to reduce one level of indentation.

  Cc: Marcel Holtmann
  Acked-by: Jason Baron
  Signed-off-by: Wu Fengguang
  Signed-off-by: Greg Kroah-Hartman

  Wu Fengguang

  2009-01-07 02:44:32 +0800  

18 Dec, 2008

2 commits

• aa6f3c640   driver core: add newlines to debugging enabled/disabled messages ... Browse Code »

  Both messages are missing the newline and thus dmesg output gets
  scrambled.

  Signed-off-by: Marcel Holtmann
  Signed-off-by: Greg Kroah-Hartman

  Marcel Holtmann

  2008-12-18 03:23:07 +0800  
• 1c93ca098   driver core: fix using 'ret' variable in unregister_dynamic_debug_module ... Browse Code »

  The 'ret' variable is assigned, but not used in the return statement. Fix this.

  Signed-off-by: Johann Felix Soden
  Acked-by: Jason Baron
  Signed-off-by: Greg Kroah-Hartman

  Johann Felix Soden

  2008-12-18 03:23:06 +0800  

30 Oct, 2008

1 commit

• 113328306   Driver core: fix 'dynamic_debug' cmd line parameter ... Browse Code »

  In testing 2.6.28-rc1, I found that passing 'dynamic_printk' on the command
  line didn't activate the debug code. The problem is that dynamic_printk_setup()
  (which activates the debugging) is being called before dynamic_printk_init() is
  called (which initializes infrastructure). Fix this by setting setting the
  state to 'DYNAMIC_ENABLED_ALL' in dynamic_printk_setup(), which will also
  cause all subsequent modules to have debugging automatically started, which is
  probably the behavior we want.

  Signed-off-by: Jason Baron
  Signed-off-by: Greg Kroah-Hartman

  Jason Baron

  2008-10-30 06:03:50 +0800  

17 Oct, 2008

1 commit

• 346e15beb   driver core: basic infrastructure for per-module dynamic debug messages ... Browse Code »

  Base infrastructure to enable per-module debug messages.

  I've introduced CONFIG_DYNAMIC_PRINTK_DEBUG, which when enabled centralizes
  control of debugging statements on a per-module basis in one /proc file,
  currently, /dynamic_printk/modules. When, CONFIG_DYNAMIC_PRINTK_DEBUG,
  is not set, debugging statements can still be enabled as before, often by
  defining 'DEBUG' for the proper compilation unit. Thus, this patch set has no
  affect when CONFIG_DYNAMIC_PRINTK_DEBUG is not set.

  The infrastructure currently ties into all pr_debug() and dev_dbg() calls. That
  is, if CONFIG_DYNAMIC_PRINTK_DEBUG is set, all pr_debug() and dev_dbg() calls
  can be dynamically enabled/disabled on a per-module basis.

  Future plans include extending this functionality to subsystems, that define
  their own debug levels and flags.

  Usage:

  Dynamic debugging is controlled by the debugfs file,
  /dynamic_printk/modules. This file contains a list of the modules that
  can be enabled. The format of the file is as follows:

  
  .
  .
  .

  : Name of the module in which the debug call resides
  : whether the messages are enabled or not

  For example:

  snd_hda_intel enabled=0
  fixup enabled=1
  driver enabled=0

  Enable a module:

  $echo "set enabled=1 " > dynamic_printk/modules

  Disable a module:

  $echo "set enabled=0 " > dynamic_printk/modules

  Enable all modules:

  $echo "set enabled=1 all" > dynamic_printk/modules

  Disable all modules:

  $echo "set enabled=0 all" > dynamic_printk/modules

  Finally, passing "dynamic_printk" at the command line enables
  debugging for all modules. This mode can be turned off via the above
  disable command.

  [gkh: minor cleanups and tweaks to make the build work quietly]

  Signed-off-by: Jason Baron
  Signed-off-by: Greg Kroah-Hartman

  Jason Baron

  2008-10-17 00:24:47 +0800