15 May, 2009
6 commits
-
Now after all users of pc->buf have been converted, remove the 64B buffer
embedded in each packet command.There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
Pass the buffer into ide_floppy_create_format_unit_cmd instead of using
pc->buf.There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
This is in preparation of removing ide_atapi_pc. Expose the buffer as an
argument to ide_queue_pc_tail with later replacing it with local buffer
or even kmalloc'ed one if needed due to stack usage constraints.Also, add the possibility of passing a NULL-ptr buffer for cmds which
don't transfer data besides the cdb. While at it, switch to local buffer
in idetape_get_mode_sense_results().There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
-
This is in preparation for removing ide_atapi_pc.
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov
01 Apr, 2009
1 commit
-
struct ide_atapi_pc is often allocated on the stack and size of ->pc_buf
size is 256 bytes. However since only ide_floppy_create_read_capacity_cmd()
and idetape_create_inquiry_cmd() require such size allocate buffers for
these pc-s explicitely and decrease ->pc_buf size to 64 bytes.Cc: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz
02 Jan, 2009
1 commit
-
This makes the top-level function just allocate a single pc entry, and then
pass it down as a pointer to all the helper functions that also need one
of those "struct ide_atapi_pc" things. As far as I can tell, the use of
these things never overlaps each other, BUT I DID NOT CHECK VERY CLOSELY!So I'm not guaranteeing this is correct, and I don't have the hardware. It
would be good for somebody who knows the code more, and has the hardware,
could please test this?With this, ide-floppy still has fairly big stack usage, but instead of
idefloppy_ioctl [vmlinux]: 1208
ide_floppy_get_capacity [vmlinux]: 872
idefloppy_release [vmlinux]: 408
idefloppy_open [vmlinux]: 408where those two first ones are at the very top of the list of stack users
for me, it's nowide_floppy_get_capacity [vmlinux]: 404
ide_floppy_ioctl [vmlinux]: 364ie they are still high, but they are no longer at the top.
Borislav: Since ide_floppy_get_capacity is passed as a function pointer to other
parts of the kernel (e.g., block layer) we need that ide_atapi_pc to be created
on stack. Also, redid stack users numbers above. The two functions missing from
Linus' original 'make stackusage' output are due to ide being
rewritten/reorganized atm.Signed-off-by: Linus Torvalds
Signed-off-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz
21 Oct, 2008
4 commits
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
-
Signed-off-by: Al Viro
18 Oct, 2008
3 commits
-
There should be no functional changes caused by this patch.
Acked-by: Borislav Petkov
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
* Add struct ide_disk_ops containing protocol specific methods.
* Add 'struct ide_disk_ops *' to ide_drive_t.
* Convert ide-{disk,floppy} drivers to use struct ide_disk_ops.
* Merge ide-{disk,floppy} drivers into generic ide-gd driver.
While at it:
- ide_disk_init_capacity() -> ide_disk_get_capacity()Acked-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There should be no functional changes caused by this patch.
Acked-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz
14 Oct, 2008
2 commits
-
While at it:
- idefloppy_ioctl() -> ide_floppy_ioctl()v2:
Fix for idefloppy_ioctl name change from Stephen Rothwell.Cc: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
* Add ide_create_request_sense_cmd() and ide_retry_pc() helpers
and convert ide-{atapi,floppy,tape}.c to use them.* Remove no longer used ide*_create_request_sense_cmd(),
ide*_retry_pc() and 'retry_pc' argument from ide_pc_intr().* Make ide_queue_pc_head() static.
There should be no functional changes caused by this patch.
Cc: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz
11 Oct, 2008
1 commit
-
While at it:
- idefloppy_create_read_capacity_cmd() -> ide_floppy_create_read_capacity_cmd()
- idefloppy_create_mode_sense_cmd() -> ide_floppy_create_mode_sense_cmd()
- idefloppy_create_request_sense_cmd() -> ide_floppy_create_request_sense_cmd()
- idefloppy_create_format_unit_cmd() -> ide_floppy_create_format_unit_cmd()
- idefloppy_get_sfrp_bit() -> ide_floppy_get_sfrp_bit()Acked-by: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz