02 Nov, 2021
1 commit
-
There might be chance that after we calculate timing based on the ipg_clk,
but ipg_clk was changed by busfreq which cause fuse prog and shadow
reload not work stable. So let request high bus to let the ipg clk fixed
during the stage programming and reloading.Reviewed-by: Jacky Bai
Signed-off-by: Peng Fan
27 Nov, 2020
1 commit
-
When offset is not 4 bytes aligned, directly shift righty by 2 bits
will cause reading out wrong data. Since imx ocotp only supports
4 bytes reading once, we need handle offset is not 4 bytes aligned
and enlarge the bytes to 4 bytes aligned. After reading finished,
copy the needed data from buffer to caller and free buffer.Signed-off-by: Peng Fan
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20201127102837.19366-6-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
15 May, 2020
1 commit
-
Several logic improvements to save many code lines:
- no need to use goto;
- no need to assign return value;
- combine different conditions of return value into one line.Signed-off-by: Anson Huang
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200511145042.31223-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
19 Mar, 2020
2 commits
-
Drop unnecessary initialization of variable 'clk_rate' and 'timing'.
Signed-off-by: Anson Huang
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200310132257.23358-11-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman -
i.MX8MP has 96 banks with each bank 4 words. And it has different
ctrl register layout, so add new macros for that.Signed-off-by: Peng Fan
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200310132257.23358-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
10 Jan, 2020
1 commit
-
Introduce ocotp_ctrl_reg to include the low 16bits mask of CTRL
register.i.MX chips will have different layout of the low 16bits of CTRL
register, so use ocotp_ctrl_reg will make it clean to add new
chip support.Signed-off-by: Peng Fan
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20200109104017.6249-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
06 Nov, 2019
1 commit
-
If software running before the OCOTP driver is loaded left the
controller with the error status pending, the driver will never
be able to complete the read timing setup. Reset the error status
on probe to make sure the controller is in usable state.Signed-off-by: Lucas Stach
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20191029114240.14905-6-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
18 Aug, 2019
1 commit
-
i.MX8MN is a new SoC of i.MX8M series, it is similar to i.MX8MM
in terms of addressing and clock setup, add support for its fuse
read/write.Signed-off-by: Anson Huang
Signed-off-by: Srinivas Kandagatla
Link: https://lore.kernel.org/r/20190818093345.29647-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman
26 Jun, 2019
5 commits
-
According to NXP Reference Manuals and uboot/atf sources the OCOTP block
on imx8m behaves more like imx6 than imx7.- Fuses can be read/written 32bits at a time (no imx7-like banking)
- The OCOTP_HW_OCOTP_TIMING register is like imx6 not imx7Since nvmem doesn't support uboot-style "sense" and "override" this
issue only affected "write" which is very rarely used.Fixes: 163c0dbd0cb1 ("nvmem: imx-ocotp: add support for imx8mq")
Signed-off-by: Leonard Crestez
Reviewed-by: Peng Fan
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
This patch adds support to burn the fuses on the i.MX8MM.
https://www.nxp.com/webapp/Download?colCode=IMX8MMRMThe i.MX8MM is similar to i.MX6 processors in terms of addressing and clock
setup.The documentation specifies 60 discreet OTP registers but, the fusemap
address space encompasses up to 256 registers. We map the entire putative
256 OTP registers.Signed-off-by: Bryan O'Donoghue
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
The RELAX field of the OCOTP block is turning out as a zero on i.MX8MM.
This messes up the subsequent re-load of the fuse shadow registers.After some discussion with people @ NXP its clear we have missed a trick
here in Linux.The OCOTP fuse programming time has a physical minimum 'burn time' that is
not related to the ipg_clk.We need to define the RELAX, STROBE_READ and STROBE_PROG fields in terms of
desired timings to allow for the burn-in to safely complete. Right now only
the RELAX field is calculated in terms of an absolute time and we are
ending up with a value of zero.This patch inherits the u-boot timings for the OCOTP_TIMING calculation on
the i.MX6 and i.MX8. Those timings are known to work and critically specify
values such as STROBE_PROG as a minimum timing.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Suggested-by: Leonard Crestez
Reviewed-by: Leonard Crestez
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
The i.MX6 and i.MX8 both have a bit-field spanning bits 27:22 called the
WAIT field.The WAIT field according to the documentation for both parts "specifies
time interval between auto read and write access in one time program. It is
given in number of ipg_clk periods."This patch ensures that the relevant field is read and written back to the
timing register.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Reviewed-by: Leonard Crestez
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
i.MX6 defines OCOTP_CTRLn:ADDR as seven bit address-field with a one bit
RSVD0 field, i.MX7 defines OCOTP_CTRLn:ADDR as a four bit address-field
with a four bit RSVD0 field.i.MX8 defines the OCOTP_CTRLn:ADDR bit-field as a full range eight bits.
i.MX6 and i.MX7 should return zero for their respective RSVD0 bits and
ignore a write-back of zero where i.MX8 will make use of the full range.This patch expands the bit-field definition for all users to eight bits,
which is safe due to RSVD0 being a no-op for the i.MX6 and i.MX7.Signed-off-by: Bryan O'Donoghue
Reviewed-by: Leonard Crestez
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
19 Jun, 2019
1 commit
-
Based on 1 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundation http www opensource org
licenses gpl license html http www gnu org copyleft gpl htmlextracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 3 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Enrico Weigelt
Reviewed-by: Allison Randal
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081201.897982733@linutronix.de
Signed-off-by: Greg Kroah-Hartman
26 Apr, 2019
2 commits
-
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.Signed-off-by: Anson Huang
Reviewed-by: Mukesh Ojha
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
The i.MX8MQ uses the same OCOTP block as the i.MX7D, but with
fourfold increase in fuse banks.Signed-off-by: Lucas Stach
Reviewed-by: Abel Vesa
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
31 Jan, 2019
2 commits
-
In comparision to the i.MX6UL the lower cost variants i.MX6ULL/ULZ only
supports 8 OTP banks a 8 words.Signed-off-by: Stefan Wahren
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
i.MX7ULP is a new SoC of i.MX family which has 8 kbit eFuse OTP,
enable ocotp driver support for this SoC.Signed-off-by: Anson Huang
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
15 Jul, 2018
1 commit
-
i.MX6SLL is a new SoC of i.MX6 family, enable ocotp
driver support for this SoC.Signed-off-by: Anson Huang
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
15 Mar, 2018
2 commits
-
remove unused dead code
Cc: Srinivas Kandagatla
Cc: Shawn Guo
Signed-off-by: Dong Aisheng
Acked-by: Shawn Guo
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Drop all of the code related to .remove hook and make use of
devm_nvmem_register() instead.Cc: Srinivas Kandagatla
Cc: Heiko Stuebner
Cc: Masahiro Yamada
Cc: Carlo Caione
Cc: Kevin Hilman
Cc: Matthias Brugger
Cc: cphealy@gmail.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Andrey Smirnov
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
08 Nov, 2017
8 commits
-
This imx-ocotp driver encapsulates support for a subset of both i.MX6 and
i.MX7 processors. Update the module description to reflect.Fixes: 711d45477931 ("nvmem: octop: Add i.MX7D support")
Signed-off-by: Bryan O'Donoghue
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
After applying patches for both banked access and write timings we can
re-enable the OTP write interface on i.MX7D processors.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
This patch adds logic to correctly setup the write timing parameters
when blowing an OTP fuse for the i.MX7S/D.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
The i.MX7S/D has a different set of timing requirements, as a pre-cursor to
adding the i.MX7 timing parameters, move the i.MX6 stuff to a dedicated
function.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Reviewed-by: Philipp Zabel
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
The i.MX7S/D takes the bank address in the CTRLn.ADDR field and the data
value in one of the DATAx {0, 1, 2, 3} register fields. The current write
routine is based on writing the CTRLn.ADDR field and writing a single DATA
register only.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Reviewed-by: Philipp Zabel
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
It will be useful in later patches to know the register access mode and
bit-shift to apply to a given input offset.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Reviewed-by: Philipp Zabel
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
i.MX7S/D have a different scheme for addressing the OTP registers inside
the OCOTP block. Currently it's possible to address the wrong OTP registers
given the disparity between IMX6 and IMX7 OTP addressing.Since OTP programming is one-time destructive its important we restrict
this interface ASAP.Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue
Acked-by: Philipp Zabel
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
All nvmem drivers are supposed to set the owner field of struct
nvmem_config, but this matches nvmem->dev->driver->owner.As far as I see in drivers/nvmem/ directory, all the drivers are
the case. So, make nvmem_register() set the nvmem's owner to the
associated driver's owner unless nvmem_config sets otherwise.Remove .owner settings in the drivers that are now redundant.
Signed-off-by: Masahiro Yamada
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
08 Apr, 2017
4 commits
-
Implement write routine for OCOTP controller found in i.MX6 SoC's.
Furthermore add locking to the read function to prevent race conditions.
The write routine code is based on the fsl_otp driver from Freescale.Signed-off-by: Richard Leitner
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
When reading a "read locked" value from the OCOTP controller on i.MX6
SoC's an error bit is set. This bit has to be cleared by software before
any new write, read or reload access can be issued.Therefore clear it after we detect such an "locked read".
Signed-off-by: Richard Leitner
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Add i.MX7D support.
There is 16 banks, each bank 4 words.Signed-off-by: Peng Fan
Cc: Srinivas Kandagatla
Cc: Maxime Ripard
Cc: Shawn Guo
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman -
Assign the correct dev pointer to struct ocotp_priv during probe. This
is needed to display dev_* messages correctly. Furthermore harmonize
the usage of dev (instead of &pdev->dev) in the probe function.Signed-off-by: Richard Leitner
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
25 Jan, 2017
1 commit
-
i.MX6UL is an new SOC of i.MX6 family. Enable ocotp
driver support for this SOC.Signed-off-by: Bai Ping
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
05 Jan, 2017
1 commit
-
All i.MX6 SoCs have an OCOTP Controller with 4kbit fuses. The i.MX6SL is
an exception and has only 2kbit fuses.In the TRM for the i.MX6DQ (IMX6QDRM - Rev 2, 06/2014) the fuses size is
described in chapter 46.1.1 with:
"32-bit word restricted program and read to 4Kbits of eFuse OTP(512x8)."In the TRM for the i.MX6SL (IMX6SLRM - Rev 2, 06/2015) the fuses size is
described in chapter 34.1.1 with:
"32-bit word restricted program and read to 2 kbit of eFuse OTP(128x8)."Since the Freescale Linux kernel OCOTP driver works with a fuses size of
2 kbit for the i.MX6SL, it looks like the TRM is wrong and the formula
to calculate the correct fuses size has to be 256x8.Signed-off-by: Daniel Schultz
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
25 Jun, 2016
2 commits
-
This patch fixes below error if the driver is compiled with 64 bit
machine configuration."drivers/nvmem/imx-ocotp.c:102:14: warning: assignment makes integer
from pointer without a cast"Signed-off-by: Srinivas Kandagatla
Acked-by: Philipp Zabel
Signed-off-by: Greg Kroah-Hartman -
Before access ocotp nvmem area, the clock should be enabled.
Or, `hexdump nvmem` will hang the system. So, use such flow:
"
1. clock_enable_prepare
2. read nvmem ocotp area
3. clock_disable_unprepare
"Signed-off-by: Peng Fan
Cc: Srinivas Kandagatla
Cc: Maxime Ripard
Cc: Shawn Guo
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
02 May, 2016
1 commit
-
This patch moves to nvmem support in the driver to use callback
instead of regmap.Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
06 Mar, 2016
1 commit
-
imx_ocotp_read() should return 0 on success.
Signed-off-by: Axel Lin
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
04 Oct, 2015
1 commit
-
This driver handles the i.MX On-Chip OTP Controller found in
i.MX6Q/D, i.MX6S/DL, i.MX6SL, and i.MX6SX SoCs. Currently it
just returns the values stored in the shadow registers.Signed-off-by: Philipp Zabel
Acked-by: Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla
Signed-off-by: Greg Kroah-Hartman
