Eric Lee / smarc-fsl-linux-kernel

21 Jul, 2021

1 commit

  • fc7a6209d   bus: Make remove callback return void ... Browse Code »

    The driver core ignores the return value of this callback because there
    is only little it can do when a device disappears.

    This is the final bit of a long lasting cleanup quest where several
    buses were converted to also return void from their remove callback.
    Additionally some resource leaks were fixed that were caused by drivers
    returning an error code in the expectation that the driver won't go
    away.

    With struct bus_type::remove returning void it's prevented that newly
    implemented buses return an ignored error code and so don't anticipate
    wrong expectations for driver authors.

    Reviewed-by: Tom Rix (For fpga)
    Reviewed-by: Mathieu Poirier
    Reviewed-by: Cornelia Huck (For drivers/s390 and drivers/vfio)
    Acked-by: Russell King (Oracle) (For ARM, Amba and related parts)
    Acked-by: Mark Brown
    Acked-by: Chen-Yu Tsai (for sunxi-rsb)
    Acked-by: Pali Rohár
    Acked-by: Mauro Carvalho Chehab (for media)
    Acked-by: Hans de Goede (For drivers/platform)
    Acked-by: Alexandre Belloni
    Acked-By: Vinod Koul
    Acked-by: Juergen Gross (For xen)
    Acked-by: Lee Jones (For mfd)
    Acked-by: Johannes Thumshirn (For mcb)
    Acked-by: Johan Hovold
    Acked-by: Srinivas Kandagatla (For slimbus)
    Acked-by: Kirti Wankhede (For vfio)
    Acked-by: Maximilian Luz
    Acked-by: Heikki Krogerus (For ulpi and typec)
    Acked-by: Samuel Iglesias Gonsálvez (For ipack)
    Acked-by: Geoff Levand (For ps3)
    Acked-by: Yehezkel Bernat (For thunderbolt)
    Acked-by: Alexander Shishkin (For intel_th)
    Acked-by: Dominik Brodowski (For pcmcia)
    Acked-by: Rafael J. Wysocki (For ACPI)
    Acked-by: Bjorn Andersson (rpmsg and apr)
    Acked-by: Srinivas Pandruvada (For intel-ish-hid)
    Acked-by: Dan Williams (For CXL, DAX, and NVDIMM)
    Acked-by: William Breathitt Gray (For isa)
    Acked-by: Stefan Richter (For firewire)
    Acked-by: Benjamin Tissoires (For hid)
    Acked-by: Thorsten Scherer (For siox)
    Acked-by: Sven Van Asbroeck (For anybuss)
    Acked-by: Ulf Hansson (For MMC)
    Acked-by: Wolfram Sang # for I2C
    Acked-by: Sudeep Holla
    Acked-by: Geert Uytterhoeven
    Acked-by: Dmitry Torokhov
    Acked-by: Finn Thain
    Signed-off-by: Uwe Kleine-König
    Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

25 May, 2021

1 commit

  • a38e93302   ALSA: ac97: fix PM reference leak in ac97_bus_remove() ... Browse Code »

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Reported-by: Hulk Robot
    Signed-off-by: Yufen Yu
    Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com
    Signed-off-by: Takashi Iwai

    Yufen Yu
     

31 Jan, 2021

1 commit

  • fa2e5a647   ALSA: ac97: Constify static struct attribute_group ... Browse Code »

    The only usage of ac97_adapter_attr_group is to put its address in an
    array of pointers to const attribute_group structs. Make it const to
    allow the compiler to put it in read-only memory.

    Signed-off-by: Rikard Falkeborn
    Link: https://lore.kernel.org/r/20210131001241.2278-2-rikard.falkeborn@gmail.com
    Signed-off-by: Takashi Iwai

    Rikard Falkeborn
     

03 Sep, 2020

1 commit

  • 2d7a5c6c6   ALSA: ac97: (cosmetic) align argument names ... Browse Code »

    Fix cppcheck warning:

    sound/ac97/bus.c:133:60: style:inconclusive: Function
    'snd_ac97_bus_scan_one' argument 1 names different: declaration 'ac97'
    definition 'adrv'. [funcArgNamesDifferent]

    Signed-off-by: Pierre-Louis Bossart
    Link: https://lore.kernel.org/r/20200902212133.30964-14-pierre-louis.bossart@linux.intel.com
    Signed-off-by: Takashi Iwai

    Pierre-Louis Bossart
     

03 Jan, 2020

1 commit

  • 33c83aaf2   ALSA: ac97: Constify snd_ac97_bus_ops definitions ... Browse Code »

    Now snd_ac97_bus() takes the const ops pointer, so we can define the
    snd_ac97_bus_ops locally as const as well for further optimization.

    There should be no functional changes by this patch.

    Link: https://lore.kernel.org/r/20200103081714.9560-24-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

23 Jul, 2019

1 commit

19 Jun, 2019

1 commit

  • d2912cb15   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 ... Browse Code »

    Based on 2 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation #

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 4122 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit

20 Feb, 2019

1 commit

  • 31d2350d6   ALSA: ac97: Fix of-node refcount unbalance ... Browse Code »

    ac97_of_get_child_device() take the refcount of the node explicitly
    via of_node_get(), but this leads to an unbalance. The
    for_each_child_of_node() loop itself takes the refcount for each
    iteration node, hence you don't need to take the extra refcount
    again.

    Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
    Reviewed-by: Robert Jarzmik
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

20 Aug, 2018

3 commits

25 Jun, 2018

1 commit

  • 2225a3e6a   ALSA: ac97: add codecs devicetree binding ... Browse Code »

    Add a devicetree binding for codecs. This is especially useful if the
    AC97 bitclk clock is provided by the codec, as it has to be described in
    the devicetree description for the ac97 bus code to aquire it.

    Signed-off-by: Robert Jarzmik
    Signed-off-by: Takashi Iwai

    Robert Jarzmik
     

12 Feb, 2018

1 commit

  • 1f8ade92a   ALSA: ac97: kconfig: Remove select of undefined symbol AC97 ... Browse Code »

    The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol
    AC97.

    Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the
    select was put in by mistake and can be safely removed, with no other
    changes required. Remove it.

    Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
    Signed-off-by: Ulf Magnusson
    Signed-off-by: Takashi Iwai

    Ulf Magnusson
     

05 Sep, 2017

1 commit

  • 74426fbff   ALSA: ac97: add an ac97 bus ... Browse Code »

    AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one
    controller to 0 to 4 AC97 codecs.

    The goal of this new implementation is to implement a device/driver
    model for AC97, with an automatic scan of the bus and automatic
    discovery of AC97 codec devices.

    Signed-off-by: Robert Jarzmik
    Reviewed-by: Takashi Iwai
    Signed-off-by: Mark Brown

    Robert Jarzmik