25 Dec, 2016
1 commit
-
This was entirely automated, using the script by Al:
PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*'
sed -i -e "s!$PATT!#include !" \
$(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)to do the replacement at the end of the merge window.
Requested-by: Al Viro
Signed-off-by: Linus Torvalds
18 Dec, 2016
1 commit
-
Pull MTD updates from Brian Norris:
"Nothing enormous here, though notably we have some of the first work
of a few new maintainers. I think for now I'll still be sending pull
requests, but that's open to change in the future. Summary:Core:
- dynamic BDI object allocation (resolves some problems when built as
a module)
- cleanups in the ooblayout handlingNAND:
- new tango NAND controller driver
- new ox820 NAND controller driver
- addition of a new full-ID entry in the nand_ids table
- rework of the s3c240 driver to support DT
- extension of the nand_sdr_timings to expose tCCS, tPROG and tR
- addition of a new flag to ask the core to wait for tCCS when
sending a RNDIN/RNDOUT command
- addition of a new flag to ask the core to let the controller driver
send the READ/PROGPAGE commandMinor fixes/cleanup/cosmetic changes:
- properly support 512 ECC step size in the sunxi driver
- improve the error messages in the PXA probe path
- fix module autoload in the omap2 driver
- cleanup of several nand drivers to return nand_scan{_tail}() error
code instead of returning -EIO
- various cleanups in the denali driver
- fix an error check in nandsimSPI NOR:
- new flash IDs
- wait for Spansion flash to be ready after quad-enable
- error handling fixes for Candence QSPI
- constify some structures in Freescale QSPI driver"* tag 'for-linus-20161216' of git://git.infradead.org/linux-mtd: (71 commits)
mtd: Allocate bdi objects dynamically
mtd: nand: tango: Add standard legalese header
mtd: maps: add missing iounmap() in error path
mtd: spi-nor: constify fsl_qspi_devtype_data
mtd: spi-nor: Add support for mr25h40
mtd: spi-nor: Add support for N25Q016A
mtd: spi-nor: Add at25df321 spi-nor flash support
mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
mtd: spi-nor: Off by one in cqspi_setup_flash()
mtd: spi-nor: add support for s25fl208k
mtd: spi-nor: fix flags for s25fl128s
mtd: spi-nor: fix spansion quad enable
mtd: spi-nor: add Macronix mx25u25635f to list of known devices.
mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"
mtd: bcm47xxpart: fix parsing first block after aligned TRX
mtd: nand: tango: Use nand_to_mtd() instead of directly accessing chip->mtd
mtd: remove unneeded initializer in mtd_ooblayout_count_bytes()
mtd: use min_t() to refactor mtd_ooblayout_{get, set}_bytes()
mtd: remove unneeded initializer in mtd_ooblayout_{get, set}_bytes()
mtd: nand: nandsim: fix error check
...
02 Dec, 2016
2 commits
-
The MTD backing dev info objects mtd_bdi was statically allocated.
So when MTD is built as a loadable module, this object fall in the
vmalloc address space.The problem with that, is that the BDI APIs use wake_up_bit(), which calls
virt_to_page() to retrieve the memory zone of the page containing the
wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
highmem addresses.Fix this by allocating the BDI objects dynamically with kmalloc. The
objects now fall in the logical address space so that BDI APIs will
work in all cases (mtd builtin or module).Signed-off-by: Steve Longerbeam
Signed-off-by: Jim Baxter
Signed-off-by: Sandeep Jain
Reviewed-by: Richard Weinberger
Reviewed-by: Marek Vasut
Signed-off-by: Brian Norris -
Provide proper copyright notice and license information.
Signed-off-by: Marc Gonzalez
Signed-off-by: Brian Norris
01 Dec, 2016
1 commit
-
This patch was triggered by the following Coccinelle error:
./drivers/mtd/maps/sc520cdp.c:246:3-9: \
ERROR: missing iounmap; ioremap on line 242 \
and execution via conditional on line 244Since do_map_probe() is also invoked in this loop, it is also necessary to
map_destroy() any initialised struct mtd_info.Signed-off-by: Luis Henriques
Reviewed-by: Marek Vasut
Signed-off-by: Brian Norris
30 Nov, 2016
2 commits
-
From Cyrille Pitchen:
"""
This pull request contains the following notable changes:
- add support to new memory parts.
- fix of spansion_quad_enable().
- fix of the Candence QSPI driver.
- constify some structure instances of the Freescale QSPI driver.
""" -
From Boris Brezillon:
"""
This pull request contains the following notable changes:
- new tango NAND controller driver
- new ox820 NAND controller driver
- addition of a new full-ID entry in the nand_ids table
- rework of the s3c240 driver to support DT
- extension of the nand_sdr_timings to expose tCCS, tPROG and tR
- addition of a new flag to ask the core to wait for tCCS when sending
a RNDIN/RNDOUT command
- addition of a new flag to ask the core to let the controller driver
send the READ/PROGPAGE commandThis pull request also contains minor fixes/cleanup/cosmetic changes:
- properly support 512 ECC step size in the sunxi driver
- improve the error messages in the pxa probe path
- fix module autoload in the omap2 driver
- cleanup of several nand drivers to return nand_scan{_tail}() error
code instead of returning -EIO
- various cleanups in the denali driver
- cleanups in the ooblayout handling (MTD core)
- fix an error check in nandsim
"""
27 Nov, 2016
4 commits
-
All fsl_qspi_devtype_data structures are never modified.
This patch constify them.Signed-off-by: LABBE Corentin
Acked-by: Han Xu
Signed-off-by: Cyrille Pitchen -
Add Everspin mr25h40 512KB MRAM to the list of supported chips.
Signed-off-by: Masahiko Iwamoto
Reviewed-by: Jagan Teki
Acked-by: Marek Vasut
Signed-off-by: Cyrille Pitchen -
This commit adds support in the spi-nor driver for the
N25Q016A, a 16Mbit SPI NOR flash from Micron.Cc: David Woodhouse
Cc: Brian Norris
Cc: Jagan TekiSigned-off-by: Moritz Fischer
Reviewed-by: Jagan Teki
Signed-off-by: Cyrille Pitchen -
Add Atmel at25df321 spi-nor flash to the list of spi_nor_ids.
Cc: Brian Norris
Cc: Wenyou Yang
Signed-off-by: Jagan Teki
Acked-by: Wenyou Yang
Signed-off-by: Cyrille Pitchen
26 Nov, 2016
4 commits
-
We return success or possibly uninitialized values on these error paths
instead of proper error codes.Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
Signed-off-by: Dan Carpenter
Reviewed-by: Marek Vasut
Reviewed-by: Moritz Fischer
Signed-off-by: Cyrille Pitchen -
There are CQSPI_MAX_CHIPSELECT elements in the ->f_pdata array so the >
should be >=.Fixes: 140623410536 ('mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller')
Signed-off-by: Dan Carpenter
Reviewed-by: Marek Vasut
Signed-off-by: Cyrille Pitchen -
Signed-off-by: Sean Nyekjaer
Reviewed-by: Jagan Teki
Acked-by: Marek Vasut
Signed-off-by: Cyrille Pitchen -
The Spansion S25FL128S also supports dual read mode.
In addition remove flag SECT_4K. 4K erases are supported,
but not uniformly.Signed-off-by: Heiner Kallweit
Reviewed-by: Jagan Teki
Acked-by: Marek Vasut
Signed-off-by: Cyrille Pitchen
23 Nov, 2016
4 commits
-
With the S25FL127S nor flash part, each writing to the configuration
register takes hundreds of ms. During that time, no more accesses to
the flash should be done (even reads).This commit adds a wait loop after the register writing until the flash
finishes its work.This issue could make rootfs mounting fail when the latter was done too
much closely to this quad enable bit setting step. And in this case, a
driver as UBIFS may try to recover the filesystem and may broke it
completely.Signed-off-by: Joël Esponde
Signed-off-by: Cyrille Pitchen -
Signed-off-by: Ash Benz
Signed-off-by: Cyrille Pitchen -
Trivial fix to spelling mistake in dev_err message
Signed-off-by: Colin Ian King
[Brian: add EOL newline]
Signed-off-by: Brian Norris -
After parsing TRX we should skip to the first block placed behind it.
Our code was working only with TRX with length not aligned to the
blocksize. In other cases (length aligned) it was missing the block
places right after TRX.This fixes calculation and simplifies the comment.
Signed-off-by: Rafał Miłecki
Signed-off-by: Brian Norris
21 Nov, 2016
1 commit
-
The nand_to_mtd() helper is here to hide internal mtd_info nand_chip
association and ease future refactors.Make use of this helper instead of directly accessing chip->mtd.
Signed-off-by: Boris Brezillon
Acked-by: Marc Gonzalez
20 Nov, 2016
3 commits
-
There is no need to initialize oobregion since it will be filled by
the iterator.This function is called with mtd_ooblayout_free or mtd_ooblayout_ecc
for the iterator; both of them calls memset() to clear the oobregion.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
I hope this will make the code a little more readable.
Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
There is no need to initialize oobregion and section since they will
be filled by mtd_ooblayout_find_region().Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon
19 Nov, 2016
15 commits
-
debugfs_create_dir() and debugfs_create_file() returns NULL on error or
a pointer on success. They do not return the error value with ERR_PTR.
So we should not check the return with IS_ERR_OR_NULL, instead we
should just check for NULL.Signed-off-by: Sudip Mukherjee
Signed-off-by: Boris Brezillon -
Drop raw_write return value (no longer used).
Drop raw_read return value (for symmetry).Signed-off-by: Marc Gonzalez
Signed-off-by: Boris Brezillon -
Enable NAND_ECC_CUSTOM_PAGE_ACCESS in the tango NFC driver.
Fixup the "raw" page accessors to send the proper NAND commands.Signed-off-by: Marc Gonzalez
Signed-off-by: Boris Brezillon -
If your controller already sends the required NAND commands when
reading or writing a page, then the framework is not supposed to
send READ0 and SEQIN/PAGEPROG respectively.Signed-off-by: Marc Gonzalez
Signed-off-by: Boris Brezillon -
Such debug lines might be useful when debugging the driver first,
but should be deleted from the upstream code.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
Remove parentheses surrounding the whole right side of an assignment.
Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The nand_scan_ident/tail() returns an appropriate error value when
it fails. Use it instead of the fixed -ENXIO.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The devm_request_irq() returns an appropriate error value when it
fails. Use it instead of the fixed -ENODEV.While we are here, reword the comment to make it fit in a single
line, fixing the misspelling of "initialization".Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
Use the managed variant instead of request_irq() and free_irq().
Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The denali->blksperchip is set, but not referenced any more. The
denali->totalblks is used only for calculating denali->blksperchip.
Both of them are unneeded.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
As far as I understood from the Kconfig menu deleted by commit
be7f39c5ecf5 ("Staging: delete spectra driver"), the "Spectra" is
specific to Intel Moorestown Platform.The Denali NAND controller IP is used for various SoCs such as
Altera SOCFPGA, Socionext UniPhier, etc. The platform specific
strings are not preferred in this driver.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The denali->fwblks is set by detect_partition_feature(), but it is
not referenced from anywhere. That means the struct member fwblks
and the whole of detect_partition_feature() are unneeded.The comment block implies this function is only for Intel platforms.
I found drivers/staging/spectra used to exist, but it was deleted by
commit be7f39c5ecf5 ("Staging: delete spectra driver") 5 years ago.So, I guess nobody would need this function any more.
Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The interrupt handler is setup in denali_init(), not in
denali_drv_init(). This comment is false.Such a comment adds no value, so just delete it instead of move.
Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The struct member "idx" was used as an index for debug_array long
ago, but the DEBUG_DENALI feature was removed by commit 7cfffac06ca0
("nand/denali: use dev_xx debug function to replace nand_dbg_print
and some printk"). Since then, this has been only initialized, but
never referenced.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon -
The driver calls devm_kzalloc()/devm_kfree() to allocate/free memory.
They are declared in , not in .Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon
08 Nov, 2016
1 commit
-
BCM53573 is a new series of Broadcom's SoCs. It's based on ARM and uses
this old ChipCommon-based flash access. Early tests resulted in flash
corruptions that were tracked down to using cached MMIO for flash read
access. Switch to ioremap_nocache conditionally to support BCM53573 and
don't break performance on old MIPS devices.Signed-off-by: Rafał Miłecki
Reviewed-by: Boris Brezillon
Signed-off-by: Brian Norris
07 Nov, 2016
1 commit
-
For this driver, there is nothing between nand_scan_ident() and
nand_scan_tail(). They can be merged into nand_scan().Also, nand_scan() returns an appropriate error value when it fails.
Use it instead of the fixed error code -ENXIO.Signed-off-by: Masahiro Yamada
Reviewed-by: Marek Vasut
Signed-off-by: Boris Brezillon