21 Oct, 2005
4 commits
-
It is legitimate to call tcp_fragment with len == skb->len since
that is done for FIN packets and the FIN flag counts as one byte.
So we should only check for the len > skb->len case.Signed-off-by: Herbert Xu
Signed-off-by: Arnaldo Carvalho de Melo -
Turns out the problem has nothing to do with use-after-free or double-free.
It's just that we're not clearing the CB area and DCCP unlike TCP uses a CB
format that's incompatible with IP.Signed-off-by: Herbert Xu
Signed-off-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
icmp_send doesn't use skb->sk at all so even if skb->sk has already
been freed it can't cause crash there (it would've crashed somewhere
else first, e.g., ip_queue_xmit).I found a double-free on an skb that could explain this though.
dccp_sendmsg and dccp_write_xmit are a little confused as to what
should free the packet when something goes wrong. Sometimes they
both go for the ball and end up in each other's way.This patch makes dccp_write_xmit always free the packet no matter
what. This makes sense since dccp_transmit_skb which in turn comes
from the fact that ip_queue_xmit always frees the packet.Signed-off-by: Herbert Xu
Signed-off-by: Arnaldo Carvalho de Melo -
David S. Miller wrote:
> One thing you can probably do for this bug is to mark data packets
> explicitly somehow, perhaps in the SKB control block DCCP already
> uses for other data. Put some boolean in there, set it true for
> data packets. Then change the test in dccp_transmit_skb() as
> appropriate to test the boolean flag instead of "skb_cloned(skb)".I agree. In fact we already have that flag, it's called skb->sk.
So here is patch to test that instead of skb_cloned().Signed-off-by: Herbert Xu
Acked-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo
16 Oct, 2005
1 commit
-
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
14 Oct, 2005
3 commits
-
Better safe than sorry.
Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Opterons with frequency scaling have fully unsynchronized TSCs
running at different frequencies, so using TSCs there is not a good idea.
Also some other x86 boxes have this problem. gettimeofday should be good
enough, so just disable it.Signed-off-by: Andi Kleen
Signed-off-by: David S. Miller -
Original patch by Harald Welte, with feedback from Herbert Xu
and testing by Sébastien Bernard.EBTABLES, ARP tables, and IP/IP6 tables all assume that cpus
are numbered linearly. That is not necessarily true.This patch fixes that up by calculating the largest possible
cpu number, and allocating enough per-cpu structure space given
that.Signed-off-by: David S. Miller
13 Oct, 2005
2 commits
-
This is the second report of this bug. Unfortunately the first
reporter hasn't been able to reproduce it since to provide more
debugging info.So let's apply this patch for 2.6.14 to
1) Make this non-fatal.
2) Provide the info we need to track it down.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
This fixes the RCU race on bridge delete interface. Basically,
the network device has to be detached from the bridge in the first
step (pre-RCU), rather than later. At that point, no more bridge traffic
will come in, and the other code will not think that network device
is part of a bridge.This should also fix the XEN test problems.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
11 Oct, 2005
14 commits
-
This is required to avoid unloading a module that has active timewait
sockets, such as DCCP.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Noticed by Andrea Bittau, that provided a patch that was modified to
not transition from RESPOND to OPEN when receiving DATA packets.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
For consistency with ccid_exit and to fix a bug when
IP_DCCP_UNLOAD_HACK is enabled as the control sock is not associated
to any CCID.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This patch add support to change the state of the private protocol
information via conntrack_netlink.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
This patch adds the ability of changing the state a TCP connection. I know
that this must be used with care but it's required to provide a complete
conntrack creation via conntrack_netlink. So I'll document this aspect on
the upcoming docs.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
Initially we used 64bit counters for conntrack-based accounting, since we
had no event mechanism to tell userspace that our counters are about to
overflow. With nfnetlink_conntrack, we now have such a event mechanism and
thus can save 16bytes per connection.Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
This patch fixes the following bugs in ESP:
* Fix transport mode MTU overestimate. This means that the inner MTU
is smaller than it needs be. Worse yet, given an input MTU which
is a multiple of 4 it will always produce an estimate which is not
a multiple of 4.For example, given a standard ESP/3DES/MD5 transform and an MTU of
1500, the resulting MTU for transport mode is 1462 when it should
be 1464.The reason for this is because IP header lengths are always a multiple
of 4 for IPv4 and 8 for IPv6.* Ensure that the block size is at least 4. This is required by RFC2406
and corresponds to what the esp_output function does. At the moment
this only affects crypto_null as its block size is 1.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
This patch uses the macro ALIGN in all the applicable spots for ESP.
Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
To keep consistency, the TCP private protocol information is nested
attributes under CTA_PROTOINFO_TCP. This way the sequence of attributes to
access the TCP state information looks like here below:CTA_PROTOINFO
CTA_PROTOINFO_TCP
CTA_PROTOINFO_TCP_STATEinstead of:
CTA_PROTOINFO
CTA_PROTOINFO_TCP_STATESigned-off-by: Pablo Neira Ayuso
Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
The ID is only required by ICMP type 8 (echo), so it's not
mandatory for all sort of ICMP connections. This patch makes
mandatory only the type and the code for ICMP netlink messages.Signed-off-by: Pablo Neira Ayuso
Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
When we send "status" from userspace, we forget to convert the endianness.
This patch adds the reqired conversion. Thanks to Pablo Neira for
discovering this.Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
As Henrik Nordstrom pointed out, all our efforts with "split endian" (i.e.
host byte order tags, net byte order values) are useless, unless a parser
can determine whether an attribute is nested or not.This patch steals the highest bit of nfattr.nfa_type to indicate whether
the data payload contains a nested nfattr (1) or not (0).This will break userspace compatibility, but luckily no kernel with
nfnetlink was released so far.Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
Similar to nfnetlink_queue and ip_queue, we mark ipt_ULOG as obsolete.
This should have been part of the original nfnetlink_log merge, but
I somehow missed it.Signed-off-by: Harald Welte
Signed-off-by: David S. Miller -
PPTP should not be selectable without conntrack enabled
Signed-off-by: Harald Welte
Signed-off-by: David S. Miller
09 Oct, 2005
1 commit
-
- added typedef unsigned int __nocast gfp_t;
- replaced __nocast uses for gfp flags with gfp_t - it gives exactly
the same warnings as far as sparse is concerned, doesn't change
generated code (from gcc point of view we replaced unsigned int with
typedef) and documents what's going on far better.Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
08 Oct, 2005
1 commit
-
From: "Jean-Denis Boyer"
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller
07 Oct, 2005
2 commits
-
From: Eric Kinzie
Signed-off-by: Chas Williams
Signed-off-by: David S. Miller -
The old socket options are marked with a _OLD suffix so that the
existing 32-bit apps on 32-bit kernels do not break.Signed-off-by: Ivan Skytte Jørgensen
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller
06 Oct, 2005
5 commits
-
Since changeset 98a82febb6340466824c3a453738d4fbd05db81a AX.25 is passing
received IP and ARP packets to the stack through netif_rx() but we don't
set the skb->mac.raw to right value which may result in a crash with
applications that use a packet socket.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Here is a patch that adds a helper called xfrm_policy_id2dir to
document the fact that the policy direction can be and is derived
from the index.This is based on a patch by YOSHIFUJI Hideaki and 210313105@suda.edu.cn.
Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
Timer set up by pneigh_enqueue() ended up calling ndisc_rcv()
via pndisc_redo(), which clears LOCALLY_ENQUEUED flag in
NEIGH_CB(skb) and NS was queued again.
Let's call ndisc_recv_ns() directly to avoid the loop.Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller -
Missing parenthesis in causes BIC to be slow in increasing congestion
window.Spotted by Injong Rhee.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Signed-Off-By: Yan Zheng
Acked-by: YOSHIFUJI Hideaki
Acked-by: David L Stevens
Signed-off-by: David S. Miller
05 Oct, 2005
7 commits
-
Fix implicit nocast warnings in xfrm code:
net/xfrm/xfrm_policy.c:232:47: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix nocast sparse warnings:
net/rxrpc/call.c:2013:25: warning: implicit cast to nocast type
net/rxrpc/connection.c:538:46: warning: implicit cast to nocast type
net/sunrpc/sched.c:730:36: warning: implicit cast to nocast type
net/sunrpc/sched.c:734:56: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix implicit nocast warnings in net/key code:
net/key/af_key.c:195:27: warning: implicit cast to nocast type
net/key/af_key.c:1439:28: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix implicit nocast warnings in nfnetlink code:
net/netfilter/nfnetlink.c:204:43: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
From: Randy Dunlap
Fix implicit nocast warnings in ip_vs code:
net/ipv4/ipvs/ip_vs_app.c:631:54: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix implicit nocast warnings in decnet code:
net/decnet/af_decnet.c:458:40: warning: implicit cast to nocast type
net/decnet/dn_nsp_out.c:125:35: warning: implicit cast to nocast type
net/decnet/dn_nsp_out.c:219:29: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix implicit nocast warnings in atm code:
net/atm/atm_misc.c:35:44: warning: implicit cast to nocast type
drivers/atm/fore200e.c:183:33: warning: implicit cast to nocast typeAlso use kzalloc() instead of kmalloc().
Signed-off-by: Randy Dunlap
Signed-off-by: David S. Miller
