18 Apr, 2008
14 commits
-
Fixes bugzilla #8895
If a super-tree leaf has 'rt' assigned to it and we
get an error from fib6_add_rt2node(), we'll leave
a reference to 'rt' in pn->leaf and then do an
unconditional dst_free().We should prune such references.
Based upon a report by Vincent Perrier.
Signed-off-by: David S. Miller
-
dev_get_by_index() may return NULL if nothing is found. In
net/netlabel/netlabel_unlabeled.c::netlbl_unlabel_staticlist_gen() the
function is called, but the return value is never checked. If it returns
NULL then we'll deref a NULL pointer on the very next line.
I checked the callers, and I don't think this can actually happen today,
but code changes over time and in the future it might happen and it does
no harm to be defensive and check for the failure, so that if/when it
happens we'll fail gracefully instead of crashing.Signed-off-by: Jesper Juhl
Acked-by: Paul Moore
Signed-off-by: David S. Miller -
datalen is unsigned so it can never be less than zero,
but that's ok because the attribute passed to nla_len()
has been validated and therefore a negative return
value is impossible.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
This deblats ~200 bytes when ipv6 and dccp are 'y'.
Besides, this will ease compilation issues for patches
I'm working on to make inet hash tables more scalable
wrt net namespaces.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
As I can see from the code, two places (tcp_v6_syn_recv_sock and
dccp_v6_request_recv_sock) that call this one already run with
BHs disabled, so it's safe to call __inet_inherit_port there.Besides (in case I missed smth with code review) the calltrace
tcp_v6_syn_recv_sock
`- tcp_v4_syn_recv_sock
`- __inet_inherit_port
and the similar for DCCP are valid, but assumes BHs to be disabled.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
According to RFC4960 7.2.2,
When all of the data transmitted by the sender has
been acknowledged by the recerver, partial_bytes_acked is initialized to 0.This patch conforms to rfc requirement.
Without this fix, cwnd might be error incremented.Signed-off-by: Gui Jianfeng
Acked-by: Vlad Yasevich
Signed-off-by: David S. Miller -
* remove changelog from source; its kept in git repository
* consolidate descriptor version tests using nv_optimized()
* consolidate NIC DMA start, stop and drain into
nv_start_txrx(), nv_stop_txrx(), nv_drain_txrx()Signed-off-by: Jeff Garzik
-
We were already doing what amounts to a get_phy_id from within
get_phy_device, and rather than duplicate this for the TBIPA
probing, we might as well just factor it out and make it available
instead.Signed-off-by: Paul Gortmaker
Acked-by: Andy Fleming
Signed-off-by: Jeff Garzik -
The BCM5464 can be used with the current broadcom PHY driver
by just adding the appropriate chip ID and using the existing
support within.Signed-off-by: Paul Gortmaker
Signed-off-by: Jeff Garzik -
Fix the warning:
drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
‘sysfs_create_group’, declared with attribute warn_unused_resultNow the return value is checked; if sysfs_create_group() returns failure,
a warning is printed using dev_dbg, and the code continues as before. Use
of dev_dbg ensures printk is not needlessly included unless desired for
debugging.Signed-off-by: Dan Noe
Signed-off-by: Jeff Garzik -
On Sat, 12 Apr 2008 05:00:49 -0400, Jeff Garzik wrote:
> applied 1-6Thanks.
Could you apply this too, or hopufully fold into Andy Fleming's "phy:
Change mii_bus id field to a string" patch (commit c69fedae) ?------------------------------------------------------
Subject: [PATCH] tc35815: build fixFix build failure caused by Andy Fleming's "phy: Change mii_bus id
field to a string" patch.Signed-off-by: Atsushi Nemoto
Signed-off-by: Jeff Garzik -
The driver stores the PCI resource address into 'unsigned long' variable before
calling ioremap() on it. This warrants a kernel oops when the registers are
accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped
beyond 4 GB.The arch/ppc/ kernel has a fixup in ioremap() that creates an illusion of the
PCI memory resources are mapped below 4 GB, but arch/powerpc/ code got rid of
this trick, having instead CONFIG_RESOURCES_64BIT enabled.Signed-off-by: Sergei Shtylyov
Signed-off-by: Jeff Garzik
17 Apr, 2008
26 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6:
it821x: do not describe noraid parameter with its value
Pb1200/DBAu1200: fix bad IDE resource size
Au1200: IDE driver build fix
Au1200: kill IDE driver function prototypes
avr32 mustn't select HAVE_IDE -
This patch is a largely cosmetic cleanup of the TIPC reference
table code.
- The object reference field in each table entry is now single
32-bit integer instead of a union of two 32-bit integers.
- Variable naming has been made more consistent.
- Error message output has been made more consistent.
- Useless #includes have been eliminated.Signed-off-by: Allan Stephens
Signed-off-by: David S. Miller -
This patch modifies TIPC's reference table code to delay initializing
table entries until they are actually needed by applications.Signed-off-by: Allan Stephens
Signed-off-by: David S. Miller -
This patch converts the TIPC reference table locking routines
into non-inlined routines, since they are mainly called from
non-performance critical areas of TIPC and the added code
footprint incurred through inlining can no longer be justified.Signed-off-by: Allan Stephens
Signed-off-by: David S. Miller -
Conglomerate from 4 separate patches from Joe.
Signed-off-by: Joe Perches
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
Conglomerate of 4 separate patches by Joe.
Signed-off-by: Joe Perches
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
This patch replaces automatic constant arrays a-la
const unsigned char Command0[6] = {0x80, 0x16, 0x00, 0x00, 0x00, 0x00};
with static ones. Size difference for 32bit x86:
text data bss dec hex filename
5418 129 0 5547 15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.o
5396 129 0 5525 1595 linux-2.6.followup-ALLYES/drivers/net/sb1000.oSigned-off-by: Denys Vlasenko
Signed-off-by: Jeff Garzik -
drivers/net/sb1000.c has lots of inlined static functions.
Mst of them are used at initialization, wait for some
hardware register to change (wait using yield, sleep etc),
or do slow port-based I/O. Inlining thse "for speed" makes no sense.This patch removes "inline" from biggest static function
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).Size difference for 32bit x86:
text data bss dec hex filename
6299 129 0 6428 191c linux-2.6-ALLYES/drivers/net/sb1000.o
5418 129 0 5547 15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.oSigned-off-by: Denys Vlasenko
Signed-off-by: Jeff Garzik -
This patch #if 0's the no longer used netxen_nic_link_ok().
Signed-off-by: Adrian Bunk
Signed-off-by: Jeff Garzik -
netxen_workq can now become static.
Signed-off-by: Adrian Bunk
Signed-off-by: Jeff Garzik -
Problem: If setting of an ip-address fails with LAN_OFFLINE,
qeth does not save the ip-address in its internal
list of set ip-addresses. qeth recovers after a
following STARTLAN event, but cannot set the unsaved
ip-address.
Solution: save the ip-address in the qeth-maintained list of
ip-addresses after a LAN_OFFLINE failure for SETIP.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
Allocate headroom for TR_HLEN but using only ETH_HLEN causes rx
performance degradation. Allocate ETH_HLEN for ethernet and
TR_HLEN for token ring (layer 3 mode).Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
Improving debug message handling, moving ipa into messages from kernel
to dbf, some cleanups and typo fixes.Signed-off-by: Peter Tiedemann
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
hw does not allow to change the mac address.
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
Symptom: slow CCL response time
Problem: non-ETH_P_802_2 packets are not delivered to NDH for
CCL. But CCL detects missing sequence numbers, which
cause a serious performance problem with CCL.
Solution: assign sequence numbers only to 802.2 packets.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
Problem: A STARTLAN command from the adapter may arrive while a
qeth recovery is currently running with a failed qeth
STARTLAN. Usually qeth schedules a recovery when
receiving a STARTLAN command from the adapter. But
another recovery scheduled while a recovery is already
running never starts. Thus the qeth-administered
lan_online flag remains zero in this scenario, even
though the adapter-STARTLAN has happened.
Solution: Set lan_online flag for a received STARTLAN from the
adapter in case scheduled recovery does not start.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
OSA-adapters do not have an address limitation for the qdio queue
structures except the MAX storage level of the current processor.
And due to a recent z/VM APAR there is no longer a restriction to
allocate qdio structures below 2 GB.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
1. ip_list handling after deregister failure of multicast address:
If error code "MC Address not found" is returned do not re-add
multicast address to ip_list.
For other error codes readd multicast address at the end of
function qeth_delete_all_mc.
2. ip_list handling after deregister failure or normal ip address:
If error code "IP Address not found" is returned do not re-add
multicast address to ip list.
This is especially important in IP address takeover scenarios,
to enable re-takeover of a taken over IP address.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: Jeff Garzik -
The register tests should be run with all the proper flags enabled
to maximize the test coverage code and make sure we are as close
as we can get to testing regular traffic.Reformat the code for readability. Minor cleanups in the descriptor
ring setup.Signed-off-by: Bruce Allan
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
Several minor cosmetic function renames.
Signed-off-by: Jeff Kirsher
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
With multiple queues coming into the code these base control
registers need to be made into arrays.Signed-off-by: Jeff Kirsher
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
Signed-off-by: Jeff Kirsher
Signed-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Any negative return value from start_xmit is interpreted as NETDEV_TX_LOCK
which is not what this driver wants. It should return 0 (NETDEV_TX_OK)
when it consumes a packet.Also, use skb_padto() as the generic way to pad small frames.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
