Eric Lee / smarc-fsl-linux-kernel

29 Sep, 2006

1 commit

23 Sep, 2006

2 commits

01 Jul, 2006

1 commit

06 Jun, 2006

1 commit

24 Feb, 2006

1 commit

  • f8d0e3f11   [NET] ethernet: Fix first packet goes out with MAC 00:00:00:00:00:00 ... Browse Code »

    When you turn off ARP on a netdevice then the first packet always goes
    out with a dstMAC of all zeroes. This is because the first packet is
    used to resolve ARP entries. Even though the ARP entry may be resolved
    (I tried by setting a static ARP entry for a host i was pinging from),
    it gets overwritten by virtue of having the netdevice disabling ARP.

    Subsequent packets go out fine with correct dstMAC address (which may
    be why people have ignored reporting this issue).

    To cut the story short:

    the culprit code is in net/ethernet/eth.c::eth_header()

    ----
    /*
    * Anyway, the loopback-device should never use this
    function...
    */

    if (dev->flags & (IFF_LOOPBACK|IFF_NOARP))
    {
    memset(eth->h_dest, 0, dev->addr_len);
    return ETH_HLEN;
    }

    if(daddr)
    {
    memcpy(eth->h_dest,daddr,dev->addr_len);
    return ETH_HLEN;
    }

    ----

    Note how the h_dest is being reset when device has IFF_NOARP.

    As a note:
    All devices including loopback pass a daddr. loopback in fact passes
    a 0 all the time ;->
    This means i can delete the check totaly or i can remove the IFF_NOARP

    Alexey says:
    --------------------
    I think, it was me who did this crap. It was so long ago I do not remember
    why it was made.

    I remember some troubles with dummy device. It tried to resolve
    addresses, apparently, without success and generated errors instead of
    blackholing. I think the problem was eventually solved at neighbour
    level.

    After some thinking I suspect the deletion of this chunk could change
    behaviour of some parts which do not use neighbour cache f.e. packet
    socket.

    I think safer approach would be to move this chunk after if (daddr).
    And the possibility to remove this completely could be analyzed later.
    --------------------

    Patch updated with Alexey's safer suggestions.

    Signed-off-by: Jamal Hadi Salim
    Acked-by: Alexey Kuznetsov
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     

07 Jan, 2006

1 commit

06 Jan, 2006

1 commit

09 Nov, 2005

1 commit

  • a51482bde   [NET]: kfree cleanup ... Browse Code »

    From: Jesper Juhl

    This is the net/ part of the big kfree cleanup patch.

    Remove pointless checks for NULL prior to calling kfree() in net/.

    Signed-off-by: Jesper Juhl
    Cc: "David S. Miller"
    Cc: Arnaldo Carvalho de Melo
    Acked-by: Marcel Holtmann
    Acked-by: YOSHIFUJI Hideaki
    Signed-off-by: Andrew Morton

    Jesper Juhl
     

29 Oct, 2005

1 commit

  • 360ac8e2f   [ETH]: ether address compare ... Browse Code »

    Expose faster ether compare for use by protocols and other
    driver. And change name to be more consistent with other ether
    address manipulation routines in same file

    Signed-off-by: Stephen Hemminger
    Signed-off-by: Arnaldo Carvalho de Melo

    Stephen Hemminger
     

29 Sep, 2005

1 commit

28 Sep, 2005

1 commit

30 Aug, 2005

2 commits

13 Jul, 2005

1 commit

29 Jun, 2005

1 commit

06 May, 2005

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds