14 Oct, 2011
1 commit
-
Wrong PCI device may be selected by cy82c693_set_pio_mode() if modular
IDE host drivers are used and there are additional IDE PCI devices
installed in the system. Fix it.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller
04 Aug, 2011
1 commit
-
Pci_get_slot calls pci_dev_get, so pci_dev_put is needed before leaving the
function in the case where pci_get_slot is locally used.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)//
@@
local idexpression x;
expression e;
@@*x = pci_get_slot(...)
... when != true x == NULL
when != pci_dev_put(x)
when != e = x
when != if (x != NULL) {}
*return ...;
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
19 Jan, 2010
4 commits
-
Change ->set_dma_mode method parameters to match ->set_dmamode method
used in struct ata_port_operations.Signed-off-by: Bartlomiej Zolnierkiewicz
-
Change ->set_pio_mode method parameters to match ->set_piomode method
used in struct ata_port_operations.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller -
Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller -
Just use the standard ide_timing_compute() helper to calculate
PIO timings. This fixes many issues with the open-coded version
like using 16-bit timings when 8-bit ones should be used or not
accounting for the enhanced cycle time specified by the device.Based on libata pata_cypress host driver.
Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller
04 Dec, 2009
1 commit
-
Signed-off-by: Bartlomiej Zolnierkiewicz
07 Jan, 2009
1 commit
-
Signed-off-by: Bartlomiej Zolnierkiewicz
30 Dec, 2008
1 commit
-
Since CY82C693 doesn't require serialization we may as well
use the default ide_pci chipset type.Signed-off-by: Bartlomiej Zolnierkiewicz
22 Oct, 2008
1 commit
-
Suggested-by: Ralf Baechle
Signed-off-by: Bartlomiej Zolnierkiewicz