20 Oct, 2011
1 commit
-
Don't rely on the PageError flag to tell us if one of the partial reads of
the page failed. Instead, replace that with a dedicated flag in the
struct nfs_page.Then clean out redundant uses of the PageError flag: the VM no longer
checks it for reads.Signed-off-by: Trond Myklebust
15 Jul, 2011
4 commits
-
...and ensure that we recoalese to take into account differences in
differences in block sizes when falling back to write through the MDS.Signed-off-by: Trond Myklebust
-
...and ensure that we recoalese to take into account differences in
block sizes when falling back to read through the MDS.Signed-off-by: Trond Myklebust
-
If an attempt to do pNFS fails, and we have to fall back to writing through
the MDS, then we may want to re-coalesce the requests that we already have
since the block size for the MDS read/writes may be different to that of
the DS read/writes.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
13 Jul, 2011
2 commits
-
Ensure that we always get a layout before setting up the i/o request.
Signed-off-by: Trond Myklebust
-
We need to ensure that the layouts are set up before we can decide to
coalesce requests. To do so, we want to further split up the struct
nfs_pageio_descriptor operations into an initialisation callback, a
coalescing test callback, and a 'do i/o' callback.This patch cleans up the existing callback methods before adding the
'initialisation' callback.Signed-off-by: Trond Myklebust
21 Jun, 2011
1 commit
-
Otherwise we end up overflowing the rpc buffer size on the receive end.
Signed-off-by: Benny Halevy
Signed-off-by: Trond Myklebust
30 May, 2011
1 commit
-
Signed-off-by: Benny Halevy
27 Mar, 2011
1 commit
-
Now that the inode scalability patches have been merged, it is no longer
safe to call igrab() under the inode->i_lock.
Now that we no longer call nfs_clear_request() until the nfs_page is
being freed, we know that we are always holding a reference to the
nfs_open_context, which again holds a reference to the path, and so
the inode cannot be freed until the last nfs_page has been removed
from the radix tree and freed.We can therefore skip the igrab()/iput() altogether.
Signed-off-by: Trond Myklebust
24 Mar, 2011
1 commit
-
We create three major hooks for the pnfs code.
pnfs_mark_request_commit() is called during writeback_done from
nfs_mark_request_commit, which gives the driver an opportunity to
claim it wants control over commiting a particular req.pnfs_choose_commit_list() is called from nfs_scan_list
to choose which list a given req should be added to, based on
where we intend to send it for COMMIT. It is up to the driver
to have preallocated list headers for each destination it may need.pnfs_commit_list() is how the driver actually takes control, it is
used instead of nfs_commit_list().In order to pass information between the above functions, we create
a union in nfs_page to hold a lseg (which is possible because the req is
not on any list while in transition), and add some flags to indicate
if we need to use the pnfs code.Signed-off-by: Fred Isaman
Signed-off-by: Trond Myklebust
22 Mar, 2011
1 commit
-
If we're only doing a single write, and there are no other unstable
writes being queued up, we might want to just flip to using a stable
write RPC call.Reviewed-by: NeilBrown
Signed-off-by: Trond Myklebust
12 Mar, 2011
3 commits
-
This will make it possible to clear the lseg pointer in the same
function as it is put, instead of in the caller nfs_pageio_doio().Signed-off-by: Fred Isaman
Signed-off-by: Trond Myklebust -
Move the pnfs_update_layout call location to nfs_pageio_do_add_request().
Grab the lseg sent in the doio function to nfs_read_rpcsetup and attach
it to each nfs_read_data so it can be sent to the layout driver.Signed-off-by: Andy Adamson
Signed-off-by: Andy Adamson
Signed-off-by: Dean Hildebrand
Signed-off-by: Fred Isaman
Signed-off-by: Fred Isaman
Signed-off-by: Benny Halevy
Signed-off-by: Boaz Harrosh
Signed-off-by: Oleg Drokin
Signed-off-by: Tao Guo
Signed-off-by: Trond Myklebust -
Add a pg_test layout driver hook which is used to avoid coelescing I/O across
layout stripes.Signed-off-by: Andy Adamson
Signed-off-by: Andy Adamson
Signed-off-by: Dean Hildebrand
Signed-off-by: Fred Isaman
Signed-off-by: Fred Isaman
Signed-off-by: Benny Halevy
Signed-off-by: Boaz Harrosh
Signed-off-by: Oleg Drokin
Signed-off-by: Tao Guo
Signed-off-by: Trond Myklebust
08 Dec, 2010
1 commit
-
When a nfs_page is freed, nfs_free_request is called which also calls
nfs_clear_request to clean out the lock and open contexts and free the
pagecache page.However, a couple of places in the nfs code call nfs_clear_request
themselves. What happens here if the refcount on the request is still high?
We'll be releasing contexts and freeing pointers while the request is
possibly still in use.Remove those bare calls to nfs_clear_context. That should only be done when
the request is being freed.Note that when doing this, we need to watch out for tests of req->wb_page.
Previously, nfs_set_page_tag_locked() and nfs_clear_page_tag_locked()
would check the value of req->wb_page to figure out if the page is mapped
into the nfsi->nfs_page_tree. We now indicate the page is mapped using
the new bit PG_MAPPED in req->wb_flags .Reported-by: Jeff Layton
Signed-off-by: Trond Myklebust
31 Jul, 2010
1 commit
-
This patch fixes bugzilla entry 14501:
https://bugzilla.kernel.org/show_bug.cgi?id=14501Signed-off-by: Trond Myklebust
10 Jul, 2008
1 commit
-
Currently, if an unstable write completes, we cannot redirty the page in
order to reflect a new change in the page data until after we've sent a
COMMIT request.This patch allows a page rewrite to proceed without the unnecessary COMMIT
step, putting it immediately back onto the dirty page list, undoing the
VM unstable write accounting, and removing the NFS_PAGE_TAG_COMMIT tag from
the NFS radix tree.Signed-off-by: Trond Myklebust
30 Jan, 2008
1 commit
-
Ensure that we set/clear NFS_PAGE_TAG_LOCKED when the nfs_page is hashed.
Signed-off-by: Trond Myklebust
10 Oct, 2007
1 commit
-
The addition of nfs_page_mkwrite means that We should no longer need to
create requests inside nfs_writepage()Signed-off-by: Trond Myklebust
11 Jul, 2007
4 commits
-
Signed-off-by: Trond Myklebust
-
Add a tag for requests that are waiting for a COMMIT
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
24 May, 2007
1 commit
-
When processes are allowed to attempt to lock a non-contiguous range of nfs
write requests, it is possible for generic_writepages to 'wrap round' the
address space, and call writepage() on a request that is already locked by
the same process.We avoid the deadlock by checking if the page index is contiguous with the
list of nfs write requests that is already held in our
nfs_pageio_descriptor prior to attempting to lock a new request.Signed-off-by: Trond Myklebust
01 May, 2007
6 commits
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Currently we do write coalescing in a very inefficient manner: one pass in
generic_writepages() in order to lock the pages for writing, then one pass
in nfs_flush_mapping() and/or nfs_sync_mapping_wait() in order to gather
the locked pages for coalescing into RPC requests of size "wsize".In fact, it turns out there is actually a deadlock possible here since we
only start I/O on the second pass. If the user signals the process while
we're in nfs_sync_mapping_wait(), for instance, then we may exit before
starting I/O on all the requests that have been queued up.Signed-off-by: Trond Myklebust
-
Do the coalescing of read requests into block sized requests at start of
I/O as we scan through the pages instead of going through a second pass.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
21 Apr, 2007
1 commit
-
Get rid of the inlined #ifdefs.
Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds
15 Apr, 2007
1 commit
-
If the writebacks are cancelled via nfs_cancel_dirty_list, or due to the
memory allocation failing in nfs_flush_one/nfs_flush_multi, then we must
ensure that the PG_writeback flag is cleared.Also ensure that we actually own the PG_writeback flag whenever we
schedule a new writeback by making nfs_set_page_writeback() return the
value of test_set_page_writeback().
The PG_writeback page flag ends up replacing the functionality of the
PG_FLUSHING nfs_page flag, so we rip that out too.Signed-off-by: Trond Myklebust
Cc: Peter Zijlstra
Signed-off-by: Linus Torvalds
06 Dec, 2006
3 commits
-
This will ensure that we can call set_page_writeback() from within
nfs_writepage(), which is always called with the page lock set.Signed-off-by: Trond Myklebust
-
We will want to allow nfs_writepage() to distinguish between pages that
have been marked as dirty by the VM, and those that have been marked as
dirty by nfs_updatepage().
In the former case, the entire page will want to be written out, and so any
requests that were pending need to be flushed out first.Signed-off-by: Trond Myklebust
-
Pass down struct writeback control.
Signed-off-by: Trond Myklebust
09 Jun, 2006
2 commits
-
This should enable us to detect if we are crossing a mountpoint in the
case where the server is exporting "nohide" mounts.Signed-off-by: Trond Myklebust
-
In the case of a call to truncate_inode_pages(), we should really try to
cancel any pending writes on the page.Signed-off-by: Trond Myklebust
07 Jan, 2006
1 commit
-
Minor cleanup: inlined bit ops in nfs_page.h can be simpler.
Test plan:
Write-intensive workload against a server that requires COMMITs.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
23 Jun, 2005
1 commit
-
Signed-off-by: Trond Myklebust