Eric Lee / smarc-fsl-linux-kernel

30 Oct, 2009

1 commit

  • e8e0929d7   ALSA: sound/parisc: Move dereference after NULL test ... Browse Code »

    If the NULL test on h is needed in snd_harmony_mixer_init, then the
    dereference should be after the NULL test.

    Actually, there is a sequence of calls: snd_harmony_create, then
    snd_harmony_pcm_init, and then snd_harmony_mixer_init. snd_harmony_create
    initializes h, but may indeed leave it as NULL. There was no NULL test at
    the beginning of snd_harmony_pcm_init, so I have added one. The NULL test
    in snd_harmony_mixer_init is then not necessary, but in case the ordering
    of the calls changes, I have left it, and moved the dereference after it.

    A simplified version of the semantic match that detects this problem is as
    follows (http://coccinelle.lip6.fr/):

    //
    @match exists@
    expression x, E;
    identifier fld;
    @@

    * x->fld
    ... when != \(x = E\|&x\)
    * x == NULL
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

10 Jun, 2009

1 commit

04 Jun, 2009

1 commit

15 May, 2009

1 commit

12 Jan, 2009

1 commit

04 Sep, 2008

1 commit

13 Aug, 2008

1 commit

27 May, 2008

1 commit

01 Feb, 2008

1 commit

  • 9004acc70   [ALSA] Remove sound/driver.h ... Browse Code »

    This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

17 Feb, 2007

1 commit

  • 992378a06   [PARISC] fix section mismatch warnings in harmony sound driver ... Browse Code »

    fix for two warnings:
    - Section mismatch: reference to .init.text:snd_harmony_mixer_init from .text.snd_harmony_probe after 'snd_harmony_probe'
    - Section mismatch: reference to .init.text:snd_harmony_mixer_reset from .text.snd_harmony_mixer_init after 'snd_harmony_mixer_init'

    Signed-off-by: Helge Deller
    Signed-off-by: Kyle McMartin

    Helge Deller
     

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

03 Jan, 2006

2 commits

22 Oct, 2005

2 commits

  • 3a1656801   [PARISC] Update harmony from parisc tree ... Browse Code »

    o Added a control for the input source (which can be either
    "line" or "mic")

    o Mute the speaker/line-out/headphone outputs by default.

    o Increased the buffer size from 10 pages to 16.

    Signed-off-by: Stuart Brady

    ALSA Harmony was resetting the capture position when
    preparing the capture substream, which it shouldn't do.
    This should fix the problem.

    Signed-off-by: Stuart Brady

    ALSA Harmony should no longer play junk (left in the buffers
    from a previous stream) at the start of a new stream.

    Implement the monitor mixer channel for ALSA Harmony.

    Also prevent snd_harmony_volume_get from returning negative values.

    Signed-off-by: Stuart Brady

    Use the graveyard/silence buffers in ALSA Harmony.

    Signed-off-by: Stuart Brady

    Signed-off-by: Kyle McMartin

    Stuart Brady
     
  • 53f01bba4   [PARISC] Convert parisc_device to use struct resource for hpa ... Browse Code »

    Convert pa_dev->hpa from an unsigned long to a struct resource.

    Signed-off-by: Matthew Wilcox

    Fix up users of ->hpa to use ->hpa.start instead.

    Signed-off-by: Matthew Wilcox

    Signed-off-by: Kyle McMartin

    Matthew Wilcox
     

12 Sep, 2005

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds