24 Jun, 2008

1 commit

  • Rename nfsd_permission() specific MAY_* flags to NFSD_MAY_* to make it
    clear, that these are not used outside nfsd, and to avoid name and
    number space conflicts with the VFS.

    [comment from hch: rename MAY_READ, MAY_WRITE and MAY_EXEC as well]

    Signed-off-by: Miklos Szeredi
    Signed-off-by: J. Bruce Fields

    Miklos Szeredi
     

13 Nov, 2007

1 commit

  • The v2/v3 acl code in nfsd is translating any return from fh_verify() to
    nfserr_inval. This is particularly unfortunate in the case of an
    nfserr_dropit return, which is an internal error meant to indicate to
    callers that this request has been deferred and should just be dropped
    pending the results of an upcall to mountd.

    Thanks to Roland for bug report and data collection.

    Cc: Roland
    Acked-by: Andreas Gruenbacher
    Signed-off-by: J. Bruce Fields
    Reviewed-By: NeilBrown
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     

09 Dec, 2006

1 commit

  • NFS3: Calculate 'w' a bit later in nfs3svc_encode_getaclres()
    This is a small performance optimization since we can return before
    needing 'w'. It also saves a few bytes of .text :
    Before:
    text data bss dec hex filename
    1632 140 0 1772 6ec fs/nfsd/nfs3acl.o
    After:
    text data bss dec hex filename
    1624 140 0 1764 6e4 fs/nfsd/nfs3acl.o

    Signed-off-by: Jesper Juhl
    Cc: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

21 Oct, 2006

3 commits


04 Oct, 2006

2 commits

  • The NFSACL patches introduced support for multiple RPC services listening on
    the same transport. However, only the first of these services was registered
    with portmapper. This was perfectly fine for nfsacl, as you traditionally do
    not want these to show up in a portmapper listing.

    The patch below changes the default behavior to always register all services
    listening on a given transport, but retains the old behavior for nfsacl
    services.

    Signed-off-by: Olaf Kirch
    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Olaf Kirch
     
  • We are planning to increase RPCSVC_MAXPAGES from about 8 to about 256. This
    means we need to be a bit careful about arrays of size RPCSVC_MAXPAGES.

    struct svc_rqst contains two such arrays. However the there are never more
    that RPCSVC_MAXPAGES pages in the two arrays together, so only one array is
    needed.

    The two arrays are for the pages holding the request, and the pages holding
    the reply. Instead of two arrays, we can simply keep an index into where the
    first reply page is.

    This patch also removes a number of small inline functions that probably
    server to obscure what is going on rather than clarify it, and opencode the
    needed functionality.

    Also remove the 'rq_restailpage' variable as it is *always* 0. i.e. if the
    response 'xdr' structure has a non-empty tail it is always in the same pages
    as the head.

    check counters are initilised and incr properly
    check for consistant usage of ++ etc
    maybe extra some inlines for common approach
    general review

    Signed-off-by: Neil Brown
    Cc: Magnus Maatta
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     

21 Dec, 2005

1 commit


23 Jun, 2005

1 commit