Eric Lee / smarc-fsl-linux-kernel

25 Apr, 2011

1 commit

31 Mar, 2011

1 commit

15 Mar, 2011

1 commit

13 Feb, 2011

4 commits

25 Jan, 2011

6 commits

  • 940d7faa4   [SCSI] scsi_dh: Use scsi_devinfo functions to do matching of device_handler tables. ... Browse Code »

    Previously we were using strncmp in order to avoid having to include
    whitespace in the devlist, but this means "HSV1000" matches a device
    list entry that says "HSV100", which is wrong. This patch changes
    scsi_dh.c to use scsi_devinfo's matching functions instead, since they
    handle these cases correctly.

    Signed-off-by: James Bottomley

    Peter Jones
     
  • 5fd1062fd   [SCSI] scsi_dh_alua: add scalable ONTAP lun to dev list ... Browse Code »

    Currently NetApp's VID/PID details in the INQUIRY response shows up as
    'NETAPP' and 'LUN'. With upcoming scalable SAN ONTAP version on NetApp
    controllers, the PID entry alone is being modified to 'LUN C-Mode' (to
    distinguish current ONTAP LUNs from scalable ONTAP LUNs).

    'LUN' would still suffice for matching 'LUN C-Mode' but best to
    explicitly add these new NetApp LUNs to the device list.

    Reported-by: Martin George
    Acked-by: Mike Christie
    Signed-off-by: Mike Snitzer
    Signed-off-by: James Bottomley

    Mike Snitzer
     
  • a3b1eff70   [SCSI] scsi_dh_alua: Add Promise VTrak to dev list ... Browse Code »

    Adds Promise VTrak devices to the ALUA device handler.

    Signed-off-by: Ilgu Hong
    Signed-off-by: Joseph Gruher
    Signed-off-by: Mike Snitzer
    Signed-off-by: James Bottomley

    Ilgu Hong
     
  • 9349923d3   [SCSI] scsi_dh_alua: fix stpg_endio group state reporting ... Browse Code »

    Initialize stpg_endio() 'err' to SCSI_DH_OK and only change it to
    SCSI_DH_IO accordingly. This allows the switching of target group state
    to be properly reported when no error has occurred.

    Signed-off-by: Joseph Gruher
    Signed-off-by: Ilgu Hong
    Signed-off-by: Mike Snitzer
    Signed-off-by: James Bottomley

    Joseph Gruher
     
  • ed0f36bc5   [SCSI] scsi_dh_alua: fix deadlock in stpg_endio ... Browse Code »

    The use of blk_execute_rq_nowait() implies __blk_put_request() is needed
    in stpg_endio() rather than blk_put_request() -- blk_finish_request() is
    called with queue lock already held.

    Signed-off-by: Joseph Gruher
    Signed-off-by: Ilgu Hong
    Signed-off-by: Mike Snitzer
    Cc: stable@kernel.org
    Signed-off-by: James Bottomley

    Joseph Gruher
     
  • 7c66e9a5e   [SCSI] scsi_dh_alua: fix submit_stpg return ... Browse Code »

    submit_stpg() will always return failure so alua_activate() will report
    failure via dm-multipath callback function. Even though the stpg fired
    successfuly dm-multipath does not know and always fails to change the
    valid path.

    By returning SCSI_DH_OK we're now skipping alua_activate()'s call to
    activate_complete 'fn'. But this is fine because stpg_endio() will call
    it via h->callback_fn().

    Signed-off-by: Joseph Gruher
    Signed-off-by: Ilgu Hong
    Signed-off-by: Mike Snitzer
    Signed-off-by: James Bottomley

    Joseph Gruher
     

22 Dec, 2010

1 commit

  • db422318c   [SCSI] scsi_dh: propagate SCSI device deletion ... Browse Code »

    Currently, when scsi_dh_activate() returns with an error
    (e.g. SCSI_DH_NOSYS) the activate_complete callback is not called and
    the error is not propagated to DM mpath.

    When a SCSI device attached to a device handler is deleted, userland
    processes currently performing I/O on the device will have their I/O
    hang forever.

    - Set SCSI_DH_NOSYS error when the handler is in the process of being
    deleted (e.g. the SCSI device is in a SDEV_CANCEL or SDEV_DEL state).

    - Set SCSI_DH_DEV_OFFLINED error when device is in SDEV_OFFLINE state.

    - Call the activate_complete callback function directly from
    scsi_dh_activate if an error has been set (when either the scsi_dh
    internal data has already been deleted or is in the process of being
    deleted).

    The patch was tested in an iSCSI environment, RDAC H/W handler and
    multipath. In the following reproduction process, dd will I/O hang
    forever and the only way to release it will be to reboot the machine:
    1) Perform I/O on a multipath device:
    dd if=/dev/dm-0 of=/dev/zero bs=8k count=1000000 &
    2) Delete all slave SCSI devices contained in the mpath device:
    I) In an iSCSI environment, the easiest way to do this is by
    stopping iSCSI:
    /etc/init.d/iscsi stop
    II) Another way to delete the devices is by applying the following
    bash scriptlet:
    dm_devs=$(ls /sys/block/ | grep dm- | xargs)
    for dm_dev in $dm_devs; do
    devices=$(ls /sys/block/$dm_dev/slaves)
    for device in $devices; do
    echo 1 > /sys/block/$device/device/delete
    done
    done

    NOTE: when DM mpath's fail_path uses blk_abort_queue this scsi_dh change
    isn't strictly required. However, DM mpath's call to blk_abort_queue
    will soon be reverted because it has proven to be unsafe due to a race
    (between blk_abort_queue and scsi_request_fn) that can lead to list
    corruption. Therefore we cannot rely on blk_abort_queue via fail_path,
    but even if we could this scsi_dh change is still preferrable.

    Signed-off-by: Menny Hamburger
    Signed-off-by: Mike Snitzer
    Reviewed-by: Babu Moger
    Signed-off-by: James Bottomley

    Menny Hamburger
     

26 Oct, 2010

1 commit

08 Oct, 2010

1 commit

  • 69723d178   [SCSI] scsi_dh_alua: Handle all states correctly ... Browse Code »

    For ALUA we should be handling all states, independent of whether
    the mode is explicit or implicit. For 'Transitioning' we should retry
    for a certain amount of time; after that we're setting the port
    to 'Standby' and return SCSI_DH_RETRY to signal upper layers
    a retry is in order here.

    Signed-off-by: Hannes Reinecke
    Acked-by: Mike Snitzer
    Signed-off-by: James Bottomley

    Hannes Reinecke
     

28 Jul, 2010

1 commit

12 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

03 Mar, 2010

1 commit

  • 6c71dcb28   [SCSI] scsi_dh_emc: fix mode select request setup ... Browse Code »

    This patch fixes the request setup code for mode selects. I got the fixes from
    Hannes Reinecke while trying to hunt down some problems and merged it
    into one patch. I am sending it because Hannes is busy with other things.

    The patch fixes:
    - setting of the length for mode selects.
    - setting of the data direction for mode select 10.

    Signed-off-by: Hannes Reinecke
    Signed-off-by: Mike Christie
    Signed-off-by: James Bottomley

    Hannes Reinecke
     

20 Feb, 2010

2 commits

10 Dec, 2009

1 commit

05 Dec, 2009

5 commits

02 Oct, 2009

1 commit

12 Sep, 2009

4 commits

05 Sep, 2009

1 commit

23 Aug, 2009

5 commits

  • 4dbfb544a   [SCSI] scsi_dh: add two SUN devices to the list of devices supported by default ... Browse Code »

    Reported-by: Rice Brown
    Signed-Off-by: Chandra Seetharaman
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 14d9cb5f7   [SCSI] scsi_dh: Provide set_params interface in emc device handler ... Browse Code »

    Handle the parameters provided by user thru multipath.

    This handler expects only 2 parameters and their value can either be 0 or 1.

    This code originates from the old dm-emc.c file. Appropriate changes have
    been made to make it work in the new design.

    Reported-by: Eddie Williams
    Signed-off-by: Chandra Seetharaman
    Tested-by: Eddie Williams
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 18ee70c9d   [SCSI] scsi_dh: add the interface scsi_dh_set_params() ... Browse Code »

    When we moved the device handler functionality from dm layer to SCSI layer
    we dropped the parameter functionality.

    This path adds an interface to scsi dh layer to set device handler
    parameters.

    Basically, multipath layer need to create a string with all the parameters
    and call scsi_dh_set_params() after it called scsi_dh_attach() on a
    device.

    If a device handler provides such an interface it will handle the parameters
    as it expects them.

    Reported-by: Eddie Williams
    Signed-off-by: Chandra Seetharaman
    Tested-by: Eddie Williams
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     
  • 3c0d1d94a   [SCSI] ALUA: send STPG if explicit and implicit is supported ... Browse Code »

    alua_activate only sends a STPG if only explicit is suppored.
    As a result, for EMC targets that support both we end up doing
    a implicit failover when X commands are finally sent to
    the other SP.

    This patch does a AND on the h->tpgs, so we do a explicit failover
    right away.

    Signed-off-by: Mike Christie
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Mike Christie
     
  • 6c10db72c   [SCSI] scsi_dh: Reference count scsi_dh_attach ... Browse Code »

    Problem reported: http://marc.info/?l=dm-devel&m=124585978305866&w=2

    scsi_dh does not do a refernce count for attach/detach, and this affects
    the way it is supposed to work with multipath when a device is not
    in the dev_list of the hardware handler.

    This patch adds a reference count that counts each attach.

    Signed-off-by: Chandra Seetharaman
    Signed-off-by: James Bottomley
    Signed-off-by: James Bottomley

    Chandra Seetharaman
     

21 May, 2009

1 commit