27 Apr, 2011
1 commit
-
These changes were incorrectly fixed by codespell. They were now
manually corrected.Signed-off-by: Lucas De Marchi
26 Apr, 2011
9 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable:
Btrfs: cleanup error handling in inode.c
Btrfs: put the right bio if we have an error
Btrfs: free bitmaps properly when evicting the cache
Btrfs: Free free_space item properly in btrfs_trim_block_group()
btrfs: add missing spin_unlock to a rare exit path
Btrfs: check return value of kmalloc()
btrfs: fix wrong allocating flag when reading page
Btrfs: fix missing mutex_unlock in btrfs_del_dir_entries_in_log() -
The error processing of several places is changed like setting the
error number only at the error.Signed-off-by: Tsutomu Itoh
Signed-off-by: Chris Mason -
In btrfs_submit_direct_hook if the first btrfs_map_block fails we need to put
the orig_bio, not bio.Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
If our space cache is wrong, we do the right thing and free up everything that
we loaded, however we don't reset the total_bitmaps counter or the thresholds or
anything. So in btrfs_remove_free_space_cache make sure to call free_bitmap()
if it's a bitmap, this will keep us from panicing when we check to make sure we
don't have too many bitmaps. Thanks,Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
Since commit dc89e9824464e91fa0b06267864ceabe3186fd8b, we've changed
to use a specific slab for alocation of free_space items.Signed-off-by: Li Zefan
Signed-off-by: Chris Mason -
Signed-off-by: David Sterba
Signed-off-by: Chris Mason -
The check on the return value of kmalloc() is added to some places.
Signed-off-by: Tsutomu Itoh
Signed-off-by: Chris Mason -
the space cache use extent_readpages() to read free space information,
so we can not use GFP_KERNEL flag to allocate memory, or it may lead
to deadlock.Signed-off-by: Itaru Kitayama
Signed-off-by: Miao Xie
Signed-off-by: Chris Mason -
It is necessary to unlock mutex_lock before it return an error when
btrfs_alloc_path() fails.Signed-off-by: Tsutomu Itoh
Signed-off-by: Chris Mason
20 Apr, 2011
1 commit
-
The Btrfs submit bio threads have a small number of
threads responsible for pushing down bios we've collected
for a large number of devices.Since we do all the bios for a single device at once,
we want to make sure we unplug and send down the bios
for each device as we're done processing them.The new plugging API removed the btrfs code to
unplug while processing bios, this adds it back with
the new API.Signed-off-by: Chris Mason
19 Apr, 2011
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable: (24 commits)
Btrfs: fix free space cache leak
Btrfs: avoid taking the chunk_mutex in do_chunk_alloc
Btrfs end_bio_extent_readpage should look for locked bits
Btrfs: don't force chunk allocation in find_free_extent
Btrfs: Check validity before setting an acl
Btrfs: Fix incorrect inode nlink in btrfs_link()
Btrfs: Check if btrfs_next_leaf() returns error in btrfs_real_readdir()
Btrfs: Check if btrfs_next_leaf() returns error in btrfs_listxattr()
Btrfs: make uncache_state unconditional
btrfs: using cached extent_state in set/unlock combinations
Btrfs: avoid taking the trans_mutex in btrfs_end_transaction
Btrfs: fix subvolume mount by name problem when default mount subvolume is set
fix user annotation in ioctl.c
Btrfs: check for duplicate iov_base's when doing dio reads
btrfs: properly handle overlapping areas in memmove_extent_buffer
Btrfs: fix memory leaks in btrfs_new_inode()
Btrfs: check for duplicate iov_base's when doing dio reads
Btrfs: reuse the extent_map we found when calling btrfs_get_extent
Btrfs: do not use async submit for small DIO io's
Btrfs: don't split dio bios if we don't have to
...
18 Apr, 2011
1 commit
-
The free space caching code was recently reworked to
cache all the pages it needed instead of using find_get_page everywhere.One loop was missed though, so it ended up leaking pages. This fixes
it to use our page array instead of find_get_page.Signed-off-by: Chris Mason
16 Apr, 2011
3 commits
-
Everytime we try to allocate disk space we try and see if we can pre-emptively
allocate a chunk, but in the common case we don't allocate anything, so there is
no sense in taking the chunk_mutex at all. So instead if we are allocating a
chunk, mark it in the space_info so we don't get two people trying to allocate
at the same time. Thanks,Signed-off-by: Josef Bacik
Reviewed-by: Liu Bo -
A recent commit caches the extent state in end_bio_extent_readpage,
but the search it does should look for locked extents. This
fixes things to make it more effective.Signed-off-by: Chris Mason
-
find_free_extent likes to allocate in contiguous clusters,
which makes writeback faster, especially on SSD storage. As
the FS fragments, these clusters become harder to find and we have
to decide between allocating a new chunk to make more clusters
or giving up on the cluster to allocate from the free space
we have.Right now it creates too many chunks, and you can end up with
a whole FS that is mostly empty metadata chunks. This commit
changes the allocation code to be more strict and only
allocate new chunks when we've made good use of the chunks we
already have.Signed-off-by: Chris Mason
13 Apr, 2011
5 commits
-
Call posix_acl_valid() to check if an acl is valid or not.
Signed-off-by: Miao Xie
Signed-off-by: Li Zefan -
Link count of the inode is not decreased if btrfs_set_inode_index()
fails.Signed-off-by: Miao Xie
Singed-off-by: Li Zefan -
btrfs_next_leaf() can return -errno, and we should propagate
it to userspace.This also simplifies how we walk the btree path.
Signed-off-by: Li Zefan
-
btrfs_next_leaf() can return -errno, and we should propagate
it to userspace.This also simplifies how we walk the btree path.
Signed-off-by: Li Zefan
-
The extent_io code can take cached pointers into the extent state trees,
and these can make lookups much faster in common operations. The
caching only happens when specific bits are set that prevent merging
and splitting of the extent state.A help function was added to uncache the state, and it was testing
the same set of conditionals. This can leak in very strange corner
cases where the lock bit goes away unexpectedly.The uncaching should be unconditional. Once we have a ref on the
extent we should always give it up.Signed-off-by: Chris Mason
12 Apr, 2011
8 commits
-
…btrfs-work into for-linus
-
In several places the sequence (set_extent_uptodate, unlock_extent) is used.
This leads to a duplicate lookup of the extent state. This patch lets
set_extent_uptodate return a cached extent_state which can be passed to
unlock_extent_cached.
The occurences of the above sequences are updated to use the cache. Only
end_bio_extent_readpage is updated that it first gets a cached state to
pass it to the readpage_end_io_hook as the prototype requested and is later
on being used for set/unlock.Signed-off-by: Arne Jansen
Signed-off-by: Chris Mason -
I've been working on making our O_DIRECT latency not suck and I noticed we were
taking the trans_mutex in btrfs_end_transaction. So to do this we convert
num_writers and use_count to atomic_t's and just decrement them in
btrfs_end_transaction. Instead of deleting the transaction from the trans list
in put_transaction we do that in btrfs_commit_transaction() since that's the
only time it actually needs to be removed from the list. Thanks,Signed-off-by: Josef Bacik
-
We create two subvolumes (meego_root and meego_home) in
btrfs root directory. And set meego_root as default mount
subvolume. After we remount btrfs, meego_root is mounted
to top directory by default. Then when we try to mount
meego_home (subvol=meego_home) to a subdirectory, it failed.
The problem is when default mount subvolume is set to
meego_root, we search meego_home in meego_root but can not find
it. So the solution is to add a new mount option (subvolrootid)
to specify subvol id of root and search subvol name in it. For
our case, now we can use "-o subvolrootid=0,subvol=meego_home)
to mount meego_home.Detail information can be found in meego bugzilla:
https://bugs.meego.com/show_bug.cgi?id=15055Signed-off-by: Zhong, Xin
Signed-off-by: Chris Mason -
Fix address space annotation correct in ioctl.c.
Signed-off-by: Daniel J Blueman
BTRFS_BLOCK_GROUP_SYSTEM,
@@ -2387,7 +2387,7 @@ long btrfs_ioctl_space_info(struct btrfs_root
*root, void __user *arg)
up_read(&info->groups_sem);
}- user_dest = (struct btrfs_ioctl_space_info *)
+ user_dest = (struct btrfs_ioctl_space_info __user *)
(arg + sizeof(struct btrfs_ioctl_space_args));if (copy_to_user(user_dest, dest_orig, alloc_size))
Reviewed-by: Josef Bacik
Signed-off-by: Chris Mason -
Apparently it is ok to submit a read to an IDE device with the same target page
for different offsets. This is what Windows does under qemu. The problem is
under DIO we expect them to be different buffers for checksumming reasons, and
so this sort of thing will result in checksum errors, when in reality the file
is fine. So when reading, check to make sure that all iov bases are different,
and if they aren't fall back to buffered mode, since that will work out right.
Thanks,Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
Fix data corruption caused by memcpy() usage on overlapping data.
I've observed it first when found out usermode linux crash on btrfs.?all chain is the following:
------------[ cut here ]------------
WARNING: at /home/slyfox/linux-2.6/fs/btrfs/extent_io.c:3900 memcpy_extent_buffer+0x1a5/0x219()
Call Trace:
6fa39a58: [] _raw_spin_unlock_irqrestore+0x18/0x1c
6fa39a68: [] warn_slowpath_common+0x59/0x70
6fa39aa8: [] warn_slowpath_null+0x15/0x17
6fa39ab8: [] memcpy_extent_buffer+0x1a5/0x219
6fa39b48: [] memmove_extent_buffer+0x94/0x208
6fa39bc8: [] btrfs_del_items+0x214/0x473
6fa39c78: [] btrfs_delete_one_dir_name+0x7c/0xda
6fa39cc8: [] __btrfs_unlink_inode+0xad/0x25d
6fa39d08: [] btrfs_start_transaction+0xe/0x10
6fa39d48: [] btrfs_unlink_inode+0x1b/0x3b
6fa39d78: [] btrfs_unlink+0x70/0xef
6fa39dc8: [] vfs_unlink+0x58/0xa3
6fa39df8: [] do_unlinkat+0xd4/0x162
6fa39e48: [] call_rcu_sched+0xe/0x10
6fa39e58: [] __put_cred+0x58/0x5a
6fa39e78: [] sys_faccessat+0x154/0x166
6fa39ed8: [] sys_unlink+0x11/0x13
6fa39ee8: [] handle_syscall+0x58/0x70
6fa39f08: [] userspace+0x2d4/0x381
6fa39fc8: [] fork_handler+0x62/0x69
---[ end trace 70b0ca2ef0266b93 ]---http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg09302.html
Signed-off-by: Sergei Trofimovich
Reviewed-by: Josef Bacik
Signed-off-by: Chris Mason -
This patch fixes memory leaks in btrfs_new_inode().
Signed-off-by: Yoshinori Sano
Signed-off-by: Chris Mason
09 Apr, 2011
8 commits
-
Apparently it is ok to submit a read to an IDE device with the same target page
for different offsets. This is what Windows does under qemu. The problem is
under DIO we expect them to be different buffers for checksumming reasons, and
so this sort of thing will result in checksum errors, when in reality the file
is fine. So when reading, check to make sure that all iov bases are different,
and if they aren't fall back to buffered mode, since that will work out right.
Thanks,Signed-off-by: Josef Bacik
-
In btrfs_get_block_direct we call btrfs_get_extent to lookup the extent for the
range that we are looking for. If we don't find an extent, btrfs_get_extent
will insert a extent_map for that area and mark it as a hole. So it does the
job of allocating a new extent map and inserting it into the io tree. But if
we're creating a new extent we free it up and redo all of that work. So instead
pass the em to btrfs_new_extent_direct(), and if it will work just allocate the
disk space and set it up properly and bypass the freeing/allocating of a new
extent map and the expensive operation of inserting the thing into the io_tree.
Thanks,Signed-off-by: Josef Bacik
-
When looking at our DIO performance Chris said that for small IO's doing the
async submit stuff tends to be more overhead than it's worth. With this on top
of my other fixes I get about a 17-20% speedup doing a sequential dd with 4k
IO's. Basically if we don't have to split the bio for the map length it's small
enough to be directly submitted, otherwise go back to the async submit. Thanks,Signed-off-by: Josef Bacik
-
We have been unconditionally allocating a new bio and re-adding all pages from
our original bio to the new bio. This is needed if our original bio is larger
than our stripe size, but if it is smaller than the stripe size then there is no
need to do this. So check the map length and if we are under that then go ahead
and submit the original bio. Thanks,Signed-off-by: Josef Bacik
-
In the DIO code we often don't update the i_disk_size because the i_size isn't
updated until after the DIO is completed, so basically we are allocating a path,
doing a search, and updating the inode item for no reason since nothing changed.
btrfs_ordered_update_i_size will return 1 if it didn't update i_disk_size, so
only run btrfs_update_inode if btrfs_ordered_update_i_size returns 0. Thanks,Signed-off-by: Josef Bacik
-
Instead of calling kmap_atomic for every thing we set in the inode item, map the
entire inode item at the start and unmap it at the end. This makes a sequential
dd of 400mb O_DIRECT something like 1% faster. Thanks,Signed-off-by: Josef Bacik
-
I saw a lockup where we kept getting into this start transaction->commit
transaction loop because of enospce. The fact is if we fail to make our
reservation, we've tried _everything_ several times, so we only need to try and
commit the transaction once, and if that doesn't work then we really are out of
space and need to just exit. Thanks,Signed-off-by: Josef Bacik
-
Currently we don't handle running out of space in the cache, so to fix this we
keep track of how far in the cache we are. Then we only dirty the pages if we
successfully modify all of them, otherwise if we have an error or run out of
space we can just drop them and not worry about the vm writing them out.
Thanks,Tested-by Johannes Hirte
Signed-off-by: Josef Bacik
08 Apr, 2011
1 commit
-
* 'for-linus2' of git://git.profusion.mobi/users/lucas/linux-2.6:
Fix common misspellings
06 Apr, 2011
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable:
Btrfs: don't warn in btrfs_add_orphan
Btrfs: fix free space cache when there are pinned extents and clusters V2
Btrfs: Fix uninitialized root flags for subvolumes
btrfs: clear __GFP_FS flag in the space cache inode
Btrfs: fix memory leak in start_transaction()
Btrfs: fix memory leak in btrfs_ioctl_start_sync()
Btrfs: fix subvol_sem leak in btrfs_rename()
Btrfs: Fix oops for defrag with compression turned on
Btrfs: fix /proc/mounts info.
Btrfs: fix compiler warning in file.c
05 Apr, 2011
1 commit
-
When I moved the orphan adding to btrfs_truncate I missed the fact that during
orphan cleanup we just add the orphan items to the orphan list without going
through btrfs_orphan_add, which results in lots of warnings on mount if you have
any orphan items that need to be truncated. Just remove this warning since it's
ok, this will allow all of the normal space accounting take place. Thanks,Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason