06 Jan, 2012
4 commits
-
BMR4xx devices don't have an external temperature sensor,
and instantiating it does not provide value anyway if it is disabled.
Only instantiate it if it is enabled.Also optimize wait time between I2C chip accesses in the probe function, and
replace unnecessary check for support for I2C_FUNC_SMBUS_READ_BYTE_DATA with
now required support for I2C_FUNC_SMBUS_READ_WORD_DATA.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for Ericsson BMR450, BMR451, BMR462, BMR463, and BMR464, which are
based on ZL2005 and ZL2008, to zl6100 driver. Remove BMR450 and BMR451 device
IDs from generic PMBus driver.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add explicit support for ZL2005. Functionality is almost the same as with other
Zilker Labs / Intersil chips, but limit register detection does not work reliably.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Since manufacturer and device ID are known, read and validate it.
Signed-off-by: Guenter Roeck
[Dan Carpenter : Fixed memory leak]
Reviewed-by: Robert Coulson
25 Oct, 2011
12 commits
-
Shift operations can be used for sign extensions. Use it.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add device IDs and reference to datasheets for Lineage Power DC-DC converters.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
The LTC3880 PMBus command set is comparable to LTC2978. Add support for it
to the LTC2978 driver.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Provide explicit driver for LTC2978 to enable support for minimum and peak
attributes. Remove ltc2978 chip id from generic pmbus driver.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
At least one PMBus chip supports peak attributes for READ_TEMPERATURE2.
Add virtual registers to be able to report it to the user.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for Intersil / Zilker Labs ZL2004, ZL2006, ZL2008, ZL2105, ZL2106,
ZL6100, and ZL6105.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Always call _pmbus_read_byte() instead of pmbus_read_byte() in PMBus core
driver. With this change, device specific read functions can be implemented for
all registers.Since the device specific read_byte function is now always called, we need to be
more careful with page validations. Only fail if the passed page number is larger
than 0, since -1 means "current page".Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
EINVAL was over-used in the code. Replace it with more appropriate errors.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
ADM1276 is mostly compatible to ADM1275, with added support for input power
measurement. Add support for it to the ADM1275 driver.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare -
ADM1275 supports a second current limit, which can be configured as either lower
or upper limit. Add support for it and report it as either lower or upper
critical current limit.Also replace error return code EINVAL for unsupported pages with ENXIO as this
is more appropriate for the observed condition.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare -
Driver remove functions have an error return value, but rarely return an error
in practice. If a driver does return an error from its remove function, the
driver won't be unloaded and is expected to stay alive.pmbus_do_remove() is defined as returning an int, but always returns 0 (no
error). Calling code passes that return value on to high level driver
remove functions, but does not evaluate it and removes driver data even if
pmbus_do_remove() returned an error (which it in practice never does). Even if
this code could never cause a real problem, it is nevertheless conceptually
wrong.To reduce confusion and simplify the code, change pmbus_do_remove() to be a void
function, and have PMBus client drivers always return zero in their driver
remove functions.Reported-by: Jean Delvare
Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare -
Return values for functions reading/writing manufacturer specific registers are
poorly explained. Add comments to improve documentation.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare
13 Sep, 2011
1 commit
-
Temperature alarms are detected by checking the alarm bit and comparing
temperature limits against the current temperature. For low limits, this
comparison needs to be reversed (temp < limit instead of temp > limit).
This was not taken into account, resulting in wrong alarms if a temperature
fell below a low limit.Fix by adding a low limit flag in the limit data structure. When creating the
sensor entry, the order of registers to compare is now reversed for low limits.Signed-off-by: Guenter Roeck
Acked-by: Jean Delvare
Cc: stable@kernel.org # 3.0+
06 Sep, 2011
1 commit
-
Rewrite the loop walking the id array during probe. The new code is
better adapted to a null-terminated array, and is also clearer and
more efficient than the original.Signed-off-by: Jean Delvare
Cc: Axel Lin
Cc: Guenter Roeck
Signed-off-by: Guenter Roeck
12 Aug, 2011
2 commits
-
pmbus_clear_faults() attempts to clear faults on non-existing real pages.
As a result, the command error bit in the status register is set, and faults
are not really cleared.All byte writes to non-zero pages are requests to clear the status register
on that page. Since non-zero pages are virtual and do not exist on the chip,
there is nothing to do, and such requests have to be ignored. This fixes
above problem.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
With virtual pages and to be able to handle more chips, it is necessary to
virtualise pmbus_write_byte().Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson
29 Jul, 2011
13 commits
-
PMBus client driver supporting National Semiconductor LM25066, LM5064, and LM5066.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage, current, and temperature peak (historic maximum)
attributes.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage, current, and temperature peak (historic maximum)
attributes.Signed-off-by: Guenter Roeck
-
Add support for voltage and temperature peak (historic maximum) attributes.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add support for voltage and current peak (historic maximum) attributes.
Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Most PMBus devices provide manufacturer specific commands to read low and/or
high peak values for some or all of its sensors.To support providing those values as lowest/highest attributes to the user,
introduce virtual PMBus commands. Those commands reside outside the normal
command set and have to be implemented in device specific code, which map the
virtual commands to device specific commands.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
With virtual register page support, it is now possible that the status register
on virtual pages does not exist or is itself virtual. To take this into account
when creating alarm attributes, generate those attributes only if the status
register on the respective page is known to exist.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some PMBus chips have non-standard sensor registers. An easy way to
support such sensors is to introduce virtual pages and map the non-standard
registers into standard registers on an extra page.For this to work, the code verifying if the configured number of pages exists
has to be removed. Since a wrong number of pages can only be configured in a
front-end driver, this should not have a practical impact since the resulting
errors should be found during development and testing.Also, functions to read the chip status while checking if a command register
exists must be modified to no longer set the page register before reading the
status, since the physical page associated with the checked register may not
exist. This does not make a functional difference since the page was already set
when the attempt to read the register was made.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some PMBus devices use non-standard registers for some of the sensors and/or
limits. To support such devices, add code to support reading and writing of word
size registers in device specific code.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Some hwmon sysfs attributes have a length of 20 bytes (plus terminating 0).
I2C_NAME_SIZE is defined as 20 and thus can not be used to define the length
of hwmon sysfs attributes. Replace it with PMBUS_NAME_SIZE, set to 24.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Add ADP4000, NCP4200 and NCP4208 to the list of devices supported by the generic
PMBus driver, and add device IDs to enable explicit instantiation.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson
Acked-by: Jean Delvare -
In VID mode, output voltages are measured and reported as VID values, and
have to be converted to voltages using VID conversion tables or functions.
Support is added for VR11 only at this time.This patch enables support for PMBus devices supporting VID VR11 based output
voltage selection such as NCP4200 and NCP4208.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson -
Since the number of PMBus drivers is getting large, move them into
directory drivers/hwmon/pmbus to improve readability and scalability.Signed-off-by: Guenter Roeck
Reviewed-by: Robert Coulson