28 Jun, 2011

1 commit


27 Oct, 2010

1 commit

  • Prefix cname and ctype constants with CN/CT_. This is especially for the
    conflict on BUG which causes a build break if arch defines it as a inline
    function, i.e. MIPS.

    Signed-off-by: Namhyung Kim
    Cc: Ankita Garg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Namhyung Kim
     

16 Sep, 2010

1 commit

  • When the default llseek behavior gets changed to
    not allowing seek, all file operations that rely
    on the current behaviour need to use an explicit
    .llseek operation.

    The files that lkdtm uses in debugfs are regular
    files and they get read using simple_read_from_buffer,
    so generic_file_llseek is the right operation.

    Signed-off-by: Arnd Bergmann

    Arnd Bergmann
     

11 Aug, 2010

1 commit

  • sysfs-writable charp arguments need to be locked against modification
    (since the old ones may be kfreed underneath us). String arguments
    are much simpler, so use them for small strings (eg. IFNAMSIZ).

    lkdtm only uses the parameters at module initialization time, so there's
    not much point making them writable.

    Signed-off-by: Rusty Russell
    Reviewed-by: Takashi Iwai
    Tested-by: Phil Carmody
    Cc: Andrew Morton
    Cc: M. Mohan Kumar
    Cc: Greg Kroah-Hartman
    Cc: Bartlomiej Zolnierkiewicz
    Cc: Jeff Mahoney
    Cc: Julia Lawall
    Cc: devel@driverdev.osuosl.org

    Rusty Russell
     

28 May, 2010

1 commit

  • This adds three new types of kernel "crashes" in the lkdtm driver to
    trigger hardlockups, softlockups and task hung states at will.

    The first two are useful to test the new generic lockup detector and check
    its further regressions. The latter one is a bonus to check the hung task
    detector regressions even though it's not currently in rework.

    Signed-off-by: Frederic Weisbecker
    Cc: Simon Kagstrom
    Cc: Ingo Molnar
    Cc: Don Zickus
    Cc: Cyrill Gorcunov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Frederic Weisbecker
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

07 Mar, 2010

1 commit

  • Add adds a debugfs interface and additional failure modes to LKDTM to
    provide similar functionality to the provoke-crash driver submitted here:

    http://lwn.net/Articles/371208/

    Crashes can now be induced either through module parameters (as before)
    or through the debugfs interface as in provoke-crash.

    The patch also provides a new "direct" interface, where KPROBES are not
    used, i.e., the crash is invoked directly upon write to the debugfs
    file. When built without KPROBES configured, only this mode is available.

    Signed-off-by: Simon Kagstrom
    Cc: M. Mohan Kumar
    Cc: Americo Wang
    Cc: David Woodhouse
    Cc: Ingo Molnar
    Cc: "Eric W. Biederman" ,
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Simon Kagstrom
     

23 Sep, 2009

1 commit

  • Current lkdtm code puts a probe on __do_IRQ for some of the kdump test
    cases. Since __do_IRQ is deprecated, change lkdtm code to use do_IRQ
    function.

    Signed-off-by: M. Mohan Kumar
    Cc: Ankita Garg
    Cc: Ingo Molnar
    Cc: Ananth N Mavinakayanahalli
    Cc: Anil S Keshavamurthy
    Cc: "David S. Miller"
    Cc: Masami Hiramatsu
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    M. Mohan Kumar
     

31 Mar, 2008

1 commit


07 Feb, 2008

1 commit


10 Feb, 2007

1 commit


06 Nov, 2006

1 commit

  • The MEM_SWAPOUT crashpoint in LKDTM could be broken as some compilers
    inline the call to shrink_page_list() and symbol lookup for this function
    name fails. Replacing it with the function shrink_inactive_list(), which
    is the only function calling shrink_page_list().

    Signed-off-by: Ankita Garg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ankita Garg
     

04 Nov, 2006

1 commit

  • Fix module_param/sysfs file permission typo.

    Clean up MODULE_PARM_DESC strings to avoid fancy (and incorrect)
    formatting.

    Fix header includes for lkdtm; add some needed ones, remove unused ones;
    and fix this gcc warning:
    drivers/misc/lkdtm.c:150: warning: 'struct buffer_head' declared inside parameter list
    drivers/misc/lkdtm.c:150: warning: its scope is only this definition or declaration, which is probably not what you want

    Signed-off-by: Randy Dunlap
    Cc: Ankita Garg
    Cc: Vivek Goyal
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

02 Oct, 2006

1 commit

  • A simple module to test Linux Kernel Dump mechanism. This module uses
    jprobes to install/activate pre-defined crash points. At different crash
    points, various types of crashing scenarios are created like a BUG(),
    panic(), exception, recursive loop and stack overflow. The user can
    activate a crash point with specific type by providing parameters at the
    time of module insertion. Please see the file header for usage
    information. The module is based on the Linux Kernel Dump Test Tool by
    Fernando .

    This module could be merged with mainline. Jprobes is used here so that the
    context in which crash point is hit, could be maintained. This implements
    all the crash points as done by LKDTT except the one in the middle of
    tasklet_action().

    Signed-off-by: Ankita Garg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ankita Garg